dohertj2/scadaproj
1
0
Fork 0
Code Issues 16 Pull Requests Actions Packages Projects Releases Wiki Activity

[Theme] Review layout.css calc(100vh - 3.3rem) min-height rule #10

New Issue
Open
opened 2026-11-06 15:24:41 -05:00 by dohertj2 · 0 comments
dohertj2 commented 2026-11-06 15:24:41 -05:00
Owner
Copy Link
Copy Source

What: Review the kit's layout.css min-height: calc(100vh - 3.3rem) rule (now line ~65 of src/ZB.MOM.WW.Theme/wwwroot/css/layout.css), deferred since the 2026-06-03 post-adoption CSS prune.

Why: a hard-coded 3.3rem couples the content height to the brand-bar height, and 100vh is the classic mobile-browser overflow trap (dynamic toolbars); 100dvh or a flex-fill shell may be the right fix. 0.5.0 reworked the mobile shell, so check whether this rule is still needed or now fights the new layout.

Verify still open: the rule is still present in the 0.5.0 source.

Source: components/ui-theme/GAPS.md (header note: "Still deferred: a kit-side layout.css calc(100vh - 3.3rem) review")

**What:** Review the kit's `layout.css` `min-height: calc(100vh - 3.3rem)` rule (now line ~65 of `src/ZB.MOM.WW.Theme/wwwroot/css/layout.css`), deferred since the 2026-06-03 post-adoption CSS prune. **Why:** a hard-coded `3.3rem` couples the content height to the brand-bar height, and `100vh` is the classic mobile-browser overflow trap (dynamic toolbars); `100dvh` or a flex-fill shell may be the right fix. 0.5.0 reworked the mobile shell, so check whether this rule is still needed or now fights the new layout. **Verify still open:** the rule is still present in the 0.5.0 source. Source: `components/ui-theme/GAPS.md` (header note: "Still deferred: a kit-side `layout.css` `calc(100vh - 3.3rem)` review")
dohertj2 added the type:debtpriority:p3migrated labels 2026-11-06 15:24:41 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
blocked
Blocked by dependency or external hold
 cross-repo
Needs coordinated change in another family repo (wire contract etc.)
 migrated
Migrated from a markdown backlog (2026-11 standardization)
 priority:p0
Must-have / blocking
 priority:p1
High priority
 priority:p2
Normal priority
 priority:p3
Low priority / nice to have
 type:bug
Defect in shipped behaviour
 type:debt
Technical debt / hygiene
 type:deploy-gate
Rollout/deploy/migration step not yet done on an environment
 type:docs
Documentation work
 type:feature
Feature implementation
 type:followup
Follow-up deferred from a plan, PR or gate
 type:infra
Infrastructure and scaffolding
 type:review-finding
Unfixed finding from an architecture/code review
 type:test
Test work
No Label migrated priority:p3 type:debt
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/scadaproj#10
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?