Verify Overview reflow and interactions in Firefox and WebKit

This commit is contained in:
Joseph Doherty
2026-11-13 21:36:28 -05:00
parent 33993296b3
commit fb40fec2d1
6 changed files with 564 additions and 3 deletions
@@ -71,9 +71,10 @@ No alternate card system, theme fork or ornamental content was introduced.
The active Impeccable UI edit hook reported no deterministic issue for the shared The active Impeccable UI edit hook reported no deterministic issue for the shared
CSS edits; this is not an accessibility certification. Keyboard, accessible roles, CSS edits; this is not an accessibility certification. Keyboard, accessible roles,
names/states, live-region source semantics and browser accessibility-tree evidence names/states, live-region source semantics and browser accessibility-tree evidence
are distinct from a human screen-reader listening session. Human VoiceOver/NVDA, are distinct from a human screen-reader listening session. Human VoiceOver/NVDA listening and real production latency remain rollout validation
additional browser engines and real production latency remain rollout validation limits. Additional Firefox/WebKit verification now passes24actual functional/reflow cases
limits. Only the supported light Overview surface is claimed; ScadaBridge's separate (6scenes ×2viewports ×2engines); see validation/overview-ui/additional-engine-notes.md
for exact scope and the retained WebKit actionability harness correction. Only the supported light Overview surface is claimed; ScadaBridge's separate
dark adapter is not an Overview theme. dark adapter is not an Overview theme.
## Rollout and rollback ## Rollout and rollback
@@ -0,0 +1,7 @@
# Additional engine verification
Firefox and WebKit24actual cases passed:6synthetic scenes ×2viewports ×2engines, exact engine versions in JSON. All retain one h1, no document overflow, reduced-motion opacity1 and no browser errors. Mixed attention/clear/focus/pause/resume and phone native rail Enter pass; long escaped diagnostics open through focused Enter. This focused functional run does not add another visual polish pass.
The first WebKit automatic click timed out despite the visible checkbox having a nonzero bounding box. A native coordinate click on that actual box changed7cards to5and updated the summary. Inspection of the installed Playwright injectedScriptSource.js confirmed its WebKit visibility workaround returns false for descendants of closed details regardless of the Theme ::details-content override. The fixture now uses measured native pointer input for WebKit clicks; it does not set open or mutate product state through scripts. Subsequent focus/keyboard and resulting application state are asserted. Retained initial failure is a harness discrepancy, not evidence that the product checkbox was unclickable. Firefox retains normal locator clicks. [Official coordinate-input documentation](https://github.com/microsoft/playwright-python/blob/main/playwright/sync_api/_generated.py) describes bounding_box plus mouse.click.
No human VoiceOver/NVDA listening session is claimed. Existing Chromium AX role/name/state evidence remains distinct from these runtime checks.
@@ -0,0 +1,61 @@
firefox 1440 mixed
firefox 1440 long-error
firefox 1440 split
firefox 1440 pending
firefox 1440 empty
firefox 1440 large
firefox 390 mixed
firefox 390 long-error
firefox 390 split
firefox 390 pending
firefox 390 empty
firefox 390 large
webkit 1440 mixed
Traceback (most recent call last):
File "/Users/dohertj2/.codex/worktrees/scada-ui-consistency/scadaproj/components/ui-theme/validation/overview-ui/additional_engines.py", line 19, in <module>
page.get_by_test_id('attention-filter').check();expect(page.get_by_test_id('attention-summary')).to_contain_text('Showing 5 of 7');assert page.get_by_test_id('instance-card').count()==5
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
File "/opt/homebrew/lib/python3.14/site-packages/playwright/sync_api/_generated.py", line 15535, in check
self._sync(
~~~~~~~~~~^
self._impl_obj.check(
^^^^^^^^^^^^^^^^^^^^^
...<5 lines>...
)
^
)
^
File "/opt/homebrew/lib/python3.14/site-packages/playwright/_impl/_sync_base.py", line 115, in _sync
return task.result()
~~~~~~~~~~~^^
File "/opt/homebrew/lib/python3.14/site-packages/playwright/_impl/_locator.py", line 146, in check
return await self._frame.check(self._selector, strict=True, **params)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/homebrew/lib/python3.14/site-packages/playwright/_impl/_frame.py", line 847, in check
await self._channel.send("check", self._timeout, locals_to_params(locals()))
File "/opt/homebrew/lib/python3.14/site-packages/playwright/_impl/_connection.py", line 69, in send
return await self._connection.wrap_api_call(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...<3 lines>...
)
^
File "/opt/homebrew/lib/python3.14/site-packages/playwright/_impl/_connection.py", line 559, in wrap_api_call
raise rewrite_error(error, f"{parsed_st['apiName']}: {error}") from None
playwright._impl._errors.TimeoutError: Locator.check: Timeout 30000ms exceeded.
Call log:
- waiting for get_by_test_id("attention-filter")
- locator resolved to <input type="checkbox" class="form-check-input" id="overview-needs-attention" data-testid="attention-filter" aria-describedby="attention-help" _bl_ba21441c-cbc4-42d6-8682-4b18069810ca=""/>
- attempting click action
2 × waiting for element to be visible, enabled and stable
- element is not visible
- retrying click action
- waiting 20ms
2 × waiting for element to be visible, enabled and stable
- element is not visible
- retrying click action
- waiting 100ms
57 × waiting for element to be visible, enabled and stable
- element is not visible
- retrying click action
- waiting 500ms
@@ -0,0 +1,429 @@
{
"cases": [
{
"engine": "firefox",
"version": "146.0.1",
"viewport": 1440,
"scene": "mixed",
"measurements": {
"width": 1440,
"scrollWidth": 1440,
"cards": 7,
"headings": 1,
"opacity": [
"1",
"1",
"1"
]
},
"errors": []
},
{
"engine": "firefox",
"version": "146.0.1",
"viewport": 1440,
"scene": "long-error",
"measurements": {
"width": 1440,
"scrollWidth": 1440,
"cards": 1,
"headings": 1,
"opacity": [
"1",
"1",
"1"
]
},
"errors": []
},
{
"engine": "firefox",
"version": "146.0.1",
"viewport": 1440,
"scene": "split",
"measurements": {
"width": 1440,
"scrollWidth": 1440,
"cards": 2,
"headings": 1,
"opacity": [
"1",
"1",
"1"
]
},
"errors": []
},
{
"engine": "firefox",
"version": "146.0.1",
"viewport": 1440,
"scene": "pending",
"measurements": {
"width": 1440,
"scrollWidth": 1440,
"cards": 1,
"headings": 1,
"opacity": [
"1",
"1",
"1"
]
},
"errors": []
},
{
"engine": "firefox",
"version": "146.0.1",
"viewport": 1440,
"scene": "empty",
"measurements": {
"width": 1440,
"scrollWidth": 1440,
"cards": 0,
"headings": 1,
"opacity": [
"1"
]
},
"errors": []
},
{
"engine": "firefox",
"version": "146.0.1",
"viewport": 1440,
"scene": "large",
"measurements": {
"width": 1440,
"scrollWidth": 1440,
"cards": 500,
"headings": 1,
"opacity": [
"1",
"1",
"1"
]
},
"errors": []
},
{
"engine": "firefox",
"version": "146.0.1",
"viewport": 390,
"scene": "mixed",
"measurements": {
"width": 390,
"scrollWidth": 390,
"cards": 7,
"headings": 1,
"opacity": [
"1",
"1",
"1"
]
},
"errors": []
},
{
"engine": "firefox",
"version": "146.0.1",
"viewport": 390,
"scene": "long-error",
"measurements": {
"width": 390,
"scrollWidth": 390,
"cards": 1,
"headings": 1,
"opacity": [
"1",
"1",
"1"
]
},
"errors": []
},
{
"engine": "firefox",
"version": "146.0.1",
"viewport": 390,
"scene": "split",
"measurements": {
"width": 390,
"scrollWidth": 390,
"cards": 2,
"headings": 1,
"opacity": [
"1",
"1",
"1"
]
},
"errors": []
},
{
"engine": "firefox",
"version": "146.0.1",
"viewport": 390,
"scene": "pending",
"measurements": {
"width": 390,
"scrollWidth": 390,
"cards": 1,
"headings": 1,
"opacity": [
"1",
"1",
"1"
]
},
"errors": []
},
{
"engine": "firefox",
"version": "146.0.1",
"viewport": 390,
"scene": "empty",
"measurements": {
"width": 390,
"scrollWidth": 390,
"cards": 0,
"headings": 1,
"opacity": [
"1"
]
},
"errors": []
},
{
"engine": "firefox",
"version": "146.0.1",
"viewport": 390,
"scene": "large",
"measurements": {
"width": 390,
"scrollWidth": 390,
"cards": 500,
"headings": 1,
"opacity": [
"1",
"1",
"1"
]
},
"errors": []
},
{
"engine": "webkit",
"version": "26.0",
"viewport": 1440,
"scene": "mixed",
"measurements": {
"width": 1440,
"scrollWidth": 1440,
"cards": 7,
"headings": 1,
"opacity": [
"1",
"1",
"1"
]
},
"errors": []
},
{
"engine": "webkit",
"version": "26.0",
"viewport": 1440,
"scene": "long-error",
"measurements": {
"width": 1440,
"scrollWidth": 1440,
"cards": 1,
"headings": 1,
"opacity": [
"1",
"1",
"1"
]
},
"errors": []
},
{
"engine": "webkit",
"version": "26.0",
"viewport": 1440,
"scene": "split",
"measurements": {
"width": 1440,
"scrollWidth": 1440,
"cards": 2,
"headings": 1,
"opacity": [
"1",
"1",
"1"
]
},
"errors": []
},
{
"engine": "webkit",
"version": "26.0",
"viewport": 1440,
"scene": "pending",
"measurements": {
"width": 1440,
"scrollWidth": 1440,
"cards": 1,
"headings": 1,
"opacity": [
"1",
"1",
"1"
]
},
"errors": []
},
{
"engine": "webkit",
"version": "26.0",
"viewport": 1440,
"scene": "empty",
"measurements": {
"width": 1440,
"scrollWidth": 1440,
"cards": 0,
"headings": 1,
"opacity": [
"1"
]
},
"errors": []
},
{
"engine": "webkit",
"version": "26.0",
"viewport": 1440,
"scene": "large",
"measurements": {
"width": 1440,
"scrollWidth": 1440,
"cards": 500,
"headings": 1,
"opacity": [
"1",
"1",
"1"
]
},
"errors": []
},
{
"engine": "webkit",
"version": "26.0",
"viewport": 390,
"scene": "mixed",
"measurements": {
"width": 390,
"scrollWidth": 390,
"cards": 7,
"headings": 1,
"opacity": [
"1",
"1",
"1"
]
},
"errors": []
},
{
"engine": "webkit",
"version": "26.0",
"viewport": 390,
"scene": "long-error",
"measurements": {
"width": 390,
"scrollWidth": 390,
"cards": 1,
"headings": 1,
"opacity": [
"1",
"1",
"1"
]
},
"errors": []
},
{
"engine": "webkit",
"version": "26.0",
"viewport": 390,
"scene": "split",
"measurements": {
"width": 390,
"scrollWidth": 390,
"cards": 2,
"headings": 1,
"opacity": [
"1",
"1",
"1"
]
},
"errors": []
},
{
"engine": "webkit",
"version": "26.0",
"viewport": 390,
"scene": "pending",
"measurements": {
"width": 390,
"scrollWidth": 390,
"cards": 1,
"headings": 1,
"opacity": [
"1",
"1",
"1"
]
},
"errors": []
},
{
"engine": "webkit",
"version": "26.0",
"viewport": 390,
"scene": "empty",
"measurements": {
"width": 390,
"scrollWidth": 390,
"cards": 0,
"headings": 1,
"opacity": [
"1"
]
},
"errors": []
},
{
"engine": "webkit",
"version": "26.0",
"viewport": 390,
"scene": "large",
"measurements": {
"width": 390,
"scrollWidth": 390,
"cards": 500,
"headings": 1,
"opacity": [
"1",
"1",
"1"
]
},
"errors": []
}
],
"scope": "24actual functional/reflow cases; reduced motion; mixed attention/clear/focus/pause/resume; long escaped diagnostic Enter; native phone rail Enter. No extra visual polish pass or human screen-reader listening claim."
}
@@ -0,0 +1,25 @@
firefox 1440 mixed
firefox 1440 long-error
firefox 1440 split
firefox 1440 pending
firefox 1440 empty
firefox 1440 large
firefox 390 mixed
firefox 390 long-error
firefox 390 split
firefox 390 pending
firefox 390 empty
firefox 390 large
webkit 1440 mixed
webkit 1440 long-error
webkit 1440 split
webkit 1440 pending
webkit 1440 empty
webkit 1440 large
webkit 390 mixed
webkit 390 long-error
webkit 390 split
webkit 390 pending
webkit 390 empty
webkit 390 large
PASS24additional engine cases
@@ -0,0 +1,38 @@
"""Focused functional/reflow verification in additional engines; no screen-reader listening claim."""
import json
from pathlib import Path
from playwright.sync_api import sync_playwright,expect
OUT=Path(__file__).resolve().parent
BASE='http://127.0.0.1:18138'
results=[]
def native_click(page, locator, engine):
if engine != 'webkit': locator.click(); return
# Playwright's WebKit visibility fallback rejects closed details descendants,
# ignoring the Theme's visible ::details-content override. Use measured native input.
locator.evaluate('(e)=>e.scrollIntoView({block:"center"})')
box=locator.bounding_box();assert box and box['width']>0 and box['height']>0
page.mouse.click(box['x']+box['width']/2,box['y']+box['height']/2)
with sync_playwright() as p:
for engine in ['firefox','webkit']:
b=getattr(p,engine).launch()
for width in [1440,390]:
page=b.new_page(viewport={'width':width,'height':900},reduced_motion='reduce');errors=[];page.on('pageerror',lambda e:errors.append(str(e)))
for scene in ['mixed','long-error','split','pending','empty','large']:
print(engine,width,scene,flush=True)
page.request.post(BASE+'/canary/scene/'+scene);page.goto(BASE);page.wait_for_selector('html[data-overview-ready="true"]');page.evaluate('document.fonts.ready')
d=page.evaluate('''()=>({width:innerWidth,scrollWidth:document.documentElement.scrollWidth,cards:document.querySelectorAll('.inst').length,headings:document.querySelectorAll('h1').length,opacity:[...document.querySelectorAll('.rise')].map(e=>getComputedStyle(e).opacity)})''')
assert d['width']==d['scrollWidth'] and d['headings']==1 and all(x=='1' for x in d['opacity']),d
if scene=='mixed':
native_click(page,page.get_by_test_id('attention-filter'),engine);expect(page.get_by_test_id('attention-summary')).to_contain_text('Showing 5 of 7');assert page.get_by_test_id('instance-card').count()==5
native_click(page,page.get_by_test_id('attention-clear'),engine);expect(page.get_by_test_id('attention-filter')).to_be_focused();assert page.get_by_test_id('instance-card').count()==7
pause=page.get_by_test_id('pause-toggle');native_click(page,pause,engine);expect(pause).to_have_attribute('aria-pressed','true');native_click(page,pause,engine)
if width==390:
nav=page.locator('summary.rail-toggle');nav.focus();page.keyboard.press('Enter');expect(page.locator('details.app-shell')).to_have_attribute('open','');page.keyboard.press('Enter');expect(page.locator('details.app-shell')).not_to_have_attribute('open','')
if scene=='long-error':
summary=page.locator('details.probe-error summary').first;summary.focus();page.keyboard.press('Enter');assert summary.evaluate('(e)=>e.parentElement.open');expect(page.locator('details.probe-error').first).to_contain_text('diagnostic end');assert not page.locator('main script').count()
results.append({'engine':engine,'version':b.version,'viewport':width,'scene':scene,'measurements':d,'errors':errors.copy()});assert not errors
(OUT/'additional-engines.json').write_text(json.dumps({'cases':results},indent=2)+'\n')
page.close()
b.close()
(OUT/'additional-engines.json').write_text(json.dumps({'cases':results,'scope':'24actual functional/reflow cases; reduced motion; mixed attention/clear/focus/pause/resume; long escaped diagnostic Enter; native phone rail Enter. No extra visual polish pass or human screen-reader listening claim.'},indent=2)+'\n');print('PASS24additional engine cases')