fix(secrets-grpc): hub-call cancellation surfaces as cancellation, not a failed sweep (scadaproj#45)

Secrets-019: the hub channels are created with ThrowOperationCanceledOnCancellation = true, so a
call cancelled through its token throws OperationCanceledException. Defensively, the failover
reader rethrows RpcException(Cancelled)-with-a-cancelled-token as cancellation instead of dialing
every fallback with the same cancelled token, and the sweep treats it as shutdown, not a failure
recorded in ISecretsHubSyncStatus. A server-side Cancelled status (token not cancelled) still fails
over.

Claude-Session: https://claude.ai/code/session_01GT67AEHd2Acv1YPwGfXEoV
This commit is contained in:
Joseph Doherty
2026-11-09 15:23:02 -05:00
parent 3aa7c728d5
commit fac3c5355c
4 changed files with 174 additions and 4 deletions
@@ -1,3 +1,4 @@
using Grpc.Core;
using Microsoft.Extensions.Hosting;
using Microsoft.Extensions.Logging;
using Microsoft.Extensions.Options;
@@ -177,6 +178,12 @@ internal sealed partial class GrpcSecretSyncService : BackgroundService
{
// Host shutdown — not a failure.
}
catch (RpcException ex) when (ex.StatusCode == StatusCode.Cancelled && ct.IsCancellationRequested)
{
// Host shutdown, reported gRPC-style by a channel not created through this library's
// registration (which sets ThrowOperationCanceledOnCancellation) — also not a failure
// (Secrets-019).
}
catch (Exception ex)
{
// Deliberately catch-all. Everything reachable from here — an unreachable hub, a