fix(secrets-ui): isolate drafts and pending operations by editor target

This commit is contained in:
Joseph Doherty
2026-11-13 16:21:37 -05:00
parent be1ce9ef3a
commit f07bd3c776
15 changed files with 2006 additions and 93 deletions
@@ -0,0 +1,109 @@
Determining projects to restore...
All projects are up-to-date for restore.
ZB.MOM.WW.Secrets.Abstractions -> /Users/dohertj2/.codex/worktrees/scada-ui-consistency/scadaproj/ZB.MOM.WW.Secrets/src/ZB.MOM.WW.Secrets.Abstractions/bin/Release/net10.0/ZB.MOM.WW.Secrets.Abstractions.dll
ZB.MOM.WW.Secrets.Ui -> /Users/dohertj2/.codex/worktrees/scada-ui-consistency/scadaproj/ZB.MOM.WW.Secrets/src/ZB.MOM.WW.Secrets.Ui/bin/Release/net10.0/ZB.MOM.WW.Secrets.Ui.dll
ZB.MOM.WW.Secrets.Ui.Tests -> /Users/dohertj2/.codex/worktrees/scada-ui-consistency/scadaproj/ZB.MOM.WW.Secrets/tests/ZB.MOM.WW.Secrets.Ui.Tests/bin/Release/net10.0/ZB.MOM.WW.Secrets.Ui.Tests.dll
Test run for /Users/dohertj2/.codex/worktrees/scada-ui-consistency/scadaproj/ZB.MOM.WW.Secrets/tests/ZB.MOM.WW.Secrets.Ui.Tests/bin/Release/net10.0/ZB.MOM.WW.Secrets.Ui.Tests.dll (.NETCoreApp,Version=v10.0)
A total of 1 test files matched the specified pattern.
[xUnit.net 00:00:00.26] ZB.MOM.WW.Secrets.Ui.Tests.SecretsListTests.ChangingRows_ReplacesTheEditorAndClearsAnotherRowsDraft [FAIL]
[xUnit.net 00:00:00.26] ZB.MOM.WW.Secrets.Ui.Tests.SecretEditorTests.PendingWrite_CannotBeCancelledOrSubmittedTwice [FAIL]
Failed ZB.MOM.WW.Secrets.Ui.Tests.SecretsListTests.ChangingRows_ReplacesTheEditorAndClearsAnotherRowsDraft [3 ms]
Error Message:
Assert.NotSame() Failure: Values are the same instance
Stack Trace:
at ZB.MOM.WW.Secrets.Ui.Tests.SecretsListTests.ChangingRows_ReplacesTheEditorAndClearsAnotherRowsDraft() in /Users/dohertj2/.codex/worktrees/scada-ui-consistency/scadaproj/ZB.MOM.WW.Secrets/tests/ZB.MOM.WW.Secrets.Ui.Tests/SecretsListTests.cs:line 118
at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
Failed ZB.MOM.WW.Secrets.Ui.Tests.SecretEditorTests.PendingWrite_CannotBeCancelledOrSubmittedTwice [181 ms]
Error Message:
Assert.True() Failure
Expected: True
Actual: False
Stack Trace:
at ZB.MOM.WW.Secrets.Ui.Tests.SecretEditorTests.PendingWrite_CannotBeCancelledOrSubmittedTwice() in /Users/dohertj2/.codex/worktrees/scada-ui-consistency/scadaproj/ZB.MOM.WW.Secrets/tests/ZB.MOM.WW.Secrets.Ui.Tests/SecretEditorTests.cs:line 311
at ZB.MOM.WW.Secrets.Ui.Tests.SecretEditorTests.PendingWrite_CannotBeCancelledOrSubmittedTwice() in /Users/dohertj2/.codex/worktrees/scada-ui-consistency/scadaproj/ZB.MOM.WW.Secrets/tests/ZB.MOM.WW.Secrets.Ui.Tests/SecretEditorTests.cs:line 318
--- End of stack trace from previous location ---
[xUnit.net 00:00:00.28] ZB.MOM.WW.Secrets.Ui.Tests.SecretsListTests.SupersededSavedCallback_DoesNotCloseANewerEditor [FAIL]
[xUnit.net 00:00:00.28] ZB.MOM.WW.Secrets.Ui.Tests.SecretEditorTests.TargetChange_ResetsTombstoneRestoreConfirmation [FAIL]
[xUnit.net 00:00:00.28] ZB.MOM.WW.Secrets.Ui.Tests.SecretsListTests.PendingMutation_DisablesParentTargetSwitchingUntilCompletion [FAIL]
[xUnit.net 00:00:00.28] ZB.MOM.WW.Secrets.Ui.Tests.SecretEditorTests.SupersededMetadataRead_IsCancelledAndCannotOverwriteNewTarget [FAIL]
[xUnit.net 00:00:00.28] ZB.MOM.WW.Secrets.Ui.Tests.SecretEditorTests.ChangingRotateTarget_DoesNotReuseAnotherSecretsDraft [FAIL]
[xUnit.net 00:00:00.29] ZB.MOM.WW.Secrets.Ui.Tests.SecretEditorTests.ReturningToSameName_StillRejectsAnOlderGenerationRead [FAIL]
[xUnit.net 00:00:00.29] ZB.MOM.WW.Secrets.Ui.Tests.SecretEditorTests.SupersededPendingWrite_PreservesCapturedTargetAuditAndCacheButNotSavedCallback [FAIL]
Failed ZB.MOM.WW.Secrets.Ui.Tests.SecretsListTests.SupersededSavedCallback_DoesNotCloseANewerEditor [4 ms]
Error Message:
Assert.Single() Failure: The collection was empty
Stack Trace:
at ZB.MOM.WW.Secrets.Ui.Tests.SecretsListTests.SupersededSavedCallback_DoesNotCloseANewerEditor() in /Users/dohertj2/.codex/worktrees/scada-ui-consistency/scadaproj/ZB.MOM.WW.Secrets/tests/ZB.MOM.WW.Secrets.Ui.Tests/SecretsListTests.cs:line 147
--- End of stack trace from previous location ---
Failed ZB.MOM.WW.Secrets.Ui.Tests.SecretEditorTests.TargetChange_ResetsTombstoneRestoreConfirmation [7 ms]
Error Message:
Assert.Empty() Failure: Collection was not empty
Collection: [StoredSecret { Name = app/retired, Description = , ContentType = Text, Ciphertext = System.Byte[], Nonce = System.Byte[], Tag = System.Byte[], WrappedDek = System.Byte[], WrapNonce = System.Byte[], WrapTag = System.Byte[], KekId = fake-kek, Revision = 0, IsDeleted = False, DeletedUtc = , CreatedUtc = 1/1/0001 12:00:00 AM +00:00, UpdatedUtc = 1/1/0001 12:00:00 AM +00:00, CreatedBy = reviewer, UpdatedBy = reviewer }]
Stack Trace:
at ZB.MOM.WW.Secrets.Ui.Tests.SecretEditorTests.TargetChange_ResetsTombstoneRestoreConfirmation() in /Users/dohertj2/.codex/worktrees/scada-ui-consistency/scadaproj/ZB.MOM.WW.Secrets/tests/ZB.MOM.WW.Secrets.Ui.Tests/SecretEditorTests.cs:line 290
at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
Failed ZB.MOM.WW.Secrets.Ui.Tests.SecretsListTests.PendingMutation_DisablesParentTargetSwitchingUntilCompletion [7 ms]
Error Message:
Assert.True() Failure
Expected: True
Actual: False
Stack Trace:
at ZB.MOM.WW.Secrets.Ui.Tests.SecretsListTests.PendingMutation_DisablesParentTargetSwitchingUntilCompletion() in /Users/dohertj2/.codex/worktrees/scada-ui-consistency/scadaproj/ZB.MOM.WW.Secrets/tests/ZB.MOM.WW.Secrets.Ui.Tests/SecretsListTests.cs:line 165
at ZB.MOM.WW.Secrets.Ui.Tests.SecretsListTests.PendingMutation_DisablesParentTargetSwitchingUntilCompletion() in /Users/dohertj2/.codex/worktrees/scada-ui-consistency/scadaproj/ZB.MOM.WW.Secrets/tests/ZB.MOM.WW.Secrets.Ui.Tests/SecretsListTests.cs:line 173
--- End of stack trace from previous location ---
Failed ZB.MOM.WW.Secrets.Ui.Tests.SecretEditorTests.SupersededMetadataRead_IsCancelledAndCannotOverwriteNewTarget [4 ms]
Error Message:
Assert.True() Failure
Expected: True
Actual: False
Stack Trace:
at ZB.MOM.WW.Secrets.Ui.Tests.SecretEditorTests.SupersededMetadataRead_IsCancelledAndCannotOverwriteNewTarget() in /Users/dohertj2/.codex/worktrees/scada-ui-consistency/scadaproj/ZB.MOM.WW.Secrets/tests/ZB.MOM.WW.Secrets.Ui.Tests/SecretEditorTests.cs:line 243
at ZB.MOM.WW.Secrets.Ui.Tests.SecretEditorTests.SupersededMetadataRead_IsCancelledAndCannotOverwriteNewTarget() in /Users/dohertj2/.codex/worktrees/scada-ui-consistency/scadaproj/ZB.MOM.WW.Secrets/tests/ZB.MOM.WW.Secrets.Ui.Tests/SecretEditorTests.cs:line 250
--- End of stack trace from previous location ---
Failed ZB.MOM.WW.Secrets.Ui.Tests.SecretEditorTests.ChangingRotateTarget_DoesNotReuseAnotherSecretsDraft [2 ms]
Error Message:
Assert.Equal() Failure: Strings differ
↓ (pos 0)
Expected: "B"
Actual: "A"
↑ (pos 0)
Stack Trace:
at ZB.MOM.WW.Secrets.Ui.Tests.SecretEditorTests.ChangingRotateTarget_DoesNotReuseAnotherSecretsDraft() in /Users/dohertj2/.codex/worktrees/scada-ui-consistency/scadaproj/ZB.MOM.WW.Secrets/tests/ZB.MOM.WW.Secrets.Ui.Tests/SecretEditorTests.cs:line 187
at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
Failed ZB.MOM.WW.Secrets.Ui.Tests.SecretEditorTests.ReturningToSameName_StillRejectsAnOlderGenerationRead [2 ms]
Error Message:
Assert.Equal() Failure: Strings differ
↓ (pos 0)
Expected: "fresh metadata"
Actual: "stale metadata"
↑ (pos 0)
Stack Trace:
at ZB.MOM.WW.Secrets.Ui.Tests.SecretEditorTests.ReturningToSameName_StillRejectsAnOlderGenerationRead() in /Users/dohertj2/.codex/worktrees/scada-ui-consistency/scadaproj/ZB.MOM.WW.Secrets/tests/ZB.MOM.WW.Secrets.Ui.Tests/SecretEditorTests.cs:line 271
--- End of stack trace from previous location ---
Failed ZB.MOM.WW.Secrets.Ui.Tests.SecretEditorTests.SupersededPendingWrite_PreservesCapturedTargetAuditAndCacheButNotSavedCallback [3 ms]
Error Message:
Assert.Equal() Failure: Strings differ
↓ (pos 7)
Expected: "secret.rotate"
Actual: "secret.add"
↑ (pos 7)
Stack Trace:
at ZB.MOM.WW.Secrets.Ui.Tests.SecretEditorTests.SupersededPendingWrite_PreservesCapturedTargetAuditAndCacheButNotSavedCallback() in /Users/dohertj2/.codex/worktrees/scada-ui-consistency/scadaproj/ZB.MOM.WW.Secrets/tests/ZB.MOM.WW.Secrets.Ui.Tests/SecretEditorTests.cs:line 345
--- End of stack trace from previous location ---
[xUnit.net 00:00:00.29] ZB.MOM.WW.Secrets.Ui.Tests.SecretEditorTests.RotateToAdd_ClearsTargetMetadataAndValue [FAIL]
Failed ZB.MOM.WW.Secrets.Ui.Tests.SecretEditorTests.RotateToAdd_ClearsTargetMetadataAndValue [1 ms]
Error Message:
Assert.Equal() Failure: Strings differ
Expected: ""
Actual: "app/a"
↑ (pos 0)
Stack Trace:
at ZB.MOM.WW.Secrets.Ui.Tests.SecretEditorTests.RotateToAdd_ClearsTargetMetadataAndValue() in /Users/dohertj2/.codex/worktrees/scada-ui-consistency/scadaproj/ZB.MOM.WW.Secrets/tests/ZB.MOM.WW.Secrets.Ui.Tests/SecretEditorTests.cs:line 201
at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
Results File: /Users/dohertj2/.codex/worktrees/scada-ui-consistency/scadaproj/components/ui-theme/validation/secrets-ui/SEC01-red.trx
Failed! - Failed: 10, Passed: 10, Skipped: 0, Total: 20, Duration: 229 ms - ZB.MOM.WW.Secrets.Ui.Tests.dll (net10.0)