fix(secrets-ui): isolate drafts and pending operations by editor target
This commit is contained in:
@@ -12,8 +12,18 @@ public sealed class RecordingSecretStore : ISecretStore
|
||||
{
|
||||
private readonly ConcurrentDictionary<string, StoredSecret> _rows = new();
|
||||
private readonly ConcurrentQueue<StoredSecret> _upserts = new();
|
||||
private readonly ConcurrentQueue<SecretName> _gets = new();
|
||||
private readonly ConcurrentQueue<(SecretName Name, string? Actor)> _deletes = new();
|
||||
|
||||
/// <summary>Names read, in call order; never plaintext.</summary>
|
||||
public IReadOnlyList<SecretName> Gets => _gets.ToArray();
|
||||
|
||||
/// <summary>Optional controlled read, including fixtures that deliberately ignore cancellation.</summary>
|
||||
public Func<SecretName, CancellationToken, Task<StoredSecret?>>? GetOverride { get; set; }
|
||||
|
||||
/// <summary>Optional hook awaited before the normal recorded upsert commits.</summary>
|
||||
public Func<StoredSecret, CancellationToken, Task>? UpsertOverride { get; set; }
|
||||
|
||||
/// <summary>Rows upserted, in call order.</summary>
|
||||
public IReadOnlyList<StoredSecret> Upserts => _upserts.ToArray();
|
||||
|
||||
@@ -32,11 +42,20 @@ public sealed class RecordingSecretStore : ISecretStore
|
||||
|
||||
/// <inheritdoc />
|
||||
public Task<StoredSecret?> GetAsync(SecretName name, CancellationToken ct)
|
||||
=> Task.FromResult(_rows.TryGetValue(name.Value, out StoredSecret? row) ? row : null);
|
||||
{
|
||||
_gets.Enqueue(name);
|
||||
return GetOverride is null
|
||||
? Task.FromResult(_rows.TryGetValue(name.Value, out StoredSecret? row) ? row : null)
|
||||
: GetOverride(name, ct);
|
||||
}
|
||||
|
||||
/// <inheritdoc />
|
||||
public Task UpsertAsync(StoredSecret row, CancellationToken ct)
|
||||
public async Task UpsertAsync(StoredSecret row, CancellationToken ct)
|
||||
{
|
||||
if (UpsertOverride is not null)
|
||||
{
|
||||
await UpsertOverride(row, ct);
|
||||
}
|
||||
if (UpsertFault is not null)
|
||||
{
|
||||
throw UpsertFault;
|
||||
@@ -44,7 +63,6 @@ public sealed class RecordingSecretStore : ISecretStore
|
||||
|
||||
_rows[row.Name.Value] = row;
|
||||
_upserts.Enqueue(row);
|
||||
return Task.CompletedTask;
|
||||
}
|
||||
|
||||
/// <inheritdoc />
|
||||
|
||||
@@ -1,6 +1,9 @@
|
||||
using Bunit;
|
||||
using Bunit.TestDoubles;
|
||||
using Microsoft.AspNetCore.Components;
|
||||
using Microsoft.AspNetCore.Components.Web;
|
||||
using Microsoft.AspNetCore.Components.Authorization;
|
||||
using System.Security.Claims;
|
||||
using Microsoft.Extensions.DependencyInjection;
|
||||
using ZB.MOM.WW.Audit;
|
||||
using ZB.MOM.WW.Secrets.Abstractions;
|
||||
@@ -171,6 +174,303 @@ public class SecretEditorTests : BunitContext
|
||||
Assert.NotEmpty(cut.FindAll("[data-testid=editor-error]"));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ChangingRotateTarget_DoesNotReuseAnotherSecretsDraft()
|
||||
{
|
||||
var (store, _, cipher) = RegisterServices();
|
||||
var a = new SecretName("app/a");
|
||||
var b = new SecretName("app/b");
|
||||
store.Seed(cipher.Encrypt(a, "old-a", SecretContentType.Text) with { Description = "A" });
|
||||
store.Seed(cipher.Encrypt(b, "old-b", SecretContentType.Json) with { Description = "B" });
|
||||
AuthorizeManager();
|
||||
var cut = Render<SecretEditor>(p => p.Add(x => x.ExistingName, a));
|
||||
cut.Find("[data-testid=secret-value]").Change("draft-for-a");
|
||||
cut.Render(p => p.Add(x => x.ExistingName, b));
|
||||
Assert.Equal("B", cut.Find("[data-testid=secret-description]").GetAttribute("value"));
|
||||
Assert.Equal(nameof(SecretContentType.Json), cut.Find("[data-testid=secret-content-type]").GetAttribute("value"));
|
||||
Assert.Equal("", cut.Find("[data-testid=secret-value]").GetAttribute("value") ?? "");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void RotateToAdd_ClearsTargetMetadataAndValue()
|
||||
{
|
||||
var (store, _, cipher) = RegisterServices();
|
||||
var a = new SecretName("app/a");
|
||||
store.Seed(cipher.Encrypt(a, "old", SecretContentType.Json) with { Description = "A" });
|
||||
var cut = Render<SecretEditor>(p => p.Add(x => x.ExistingName, a));
|
||||
cut.Find("[data-testid=secret-value]").Change("draft-for-a");
|
||||
cut.Render(p => p.Add(x => x.ExistingName, (SecretName?)null));
|
||||
Assert.Equal("", cut.Find("[data-testid=secret-name]").GetAttribute("value") ?? "");
|
||||
Assert.Equal("", cut.Find("[data-testid=secret-description]").GetAttribute("value") ?? "");
|
||||
Assert.Equal("", cut.Find("[data-testid=secret-value]").GetAttribute("value") ?? "");
|
||||
Assert.Equal(nameof(SecretContentType.Text), cut.Find("[data-testid=secret-content-type]").GetAttribute("value"));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void SameTargetRerender_PreservesUnsavedDraftAndFailedSaveError()
|
||||
{
|
||||
var (store, _, cipher) = RegisterServices();
|
||||
var a = new SecretName("app/a");
|
||||
store.Seed(cipher.Encrypt(a, "old", SecretContentType.Text) with { Description = "A" });
|
||||
store.UpsertFault = new IOException("synthetic write failure");
|
||||
AuthorizeManager();
|
||||
var cut = Render<SecretEditor>(p => p.Add(x => x.ExistingName, a));
|
||||
cut.Find("[data-testid=secret-description]").Change("unsaved description");
|
||||
cut.Find("[data-testid=secret-value]").Change("unsaved value");
|
||||
cut.Find("[data-testid=editor-submit]").Click();
|
||||
cut.Render(p => p.Add(x => x.ExistingName, a));
|
||||
Assert.Equal("unsaved description", cut.Find("[data-testid=secret-description]").GetAttribute("value"));
|
||||
Assert.Equal("unsaved value", cut.Find("[data-testid=secret-value]").GetAttribute("value"));
|
||||
Assert.NotEmpty(cut.FindAll("[data-testid=editor-error]"));
|
||||
Assert.Single(store.Gets);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task SupersededMetadataRead_IsCancelledAndCannotOverwriteNewTarget()
|
||||
{
|
||||
var (store, _, cipher) = RegisterServices();
|
||||
var a = new SecretName("app/a");
|
||||
var b = new SecretName("app/b");
|
||||
var oldRead = new TaskCompletionSource<StoredSecret?>(TaskCreationOptions.RunContinuationsAsynchronously);
|
||||
CancellationToken readToken = default;
|
||||
store.GetOverride = (name, ct) =>
|
||||
{
|
||||
if (name == a) { readToken = ct; return oldRead.Task; }
|
||||
return Task.FromResult<StoredSecret?>(cipher.Encrypt(b, "old-b", SecretContentType.Json) with { Description = "B" });
|
||||
};
|
||||
var cut = Render<SecretEditor>(p => p.Add(x => x.ExistingName, a));
|
||||
try
|
||||
{
|
||||
cut.Render(p => p.Add(x => x.ExistingName, b));
|
||||
Assert.True(readToken.IsCancellationRequested);
|
||||
}
|
||||
finally
|
||||
{
|
||||
var before = cut.RenderCount;
|
||||
await cut.InvokeAsync(() => oldRead.TrySetResult(cipher.Encrypt(a, "old-a", SecretContentType.Text) with { Description = "A" }));
|
||||
cut.WaitForState(() => cut.RenderCount > before);
|
||||
}
|
||||
Assert.Equal("B", cut.Find("[data-testid=secret-description]").GetAttribute("value"));
|
||||
Assert.Equal("app/b", cut.Find("[data-testid=secret-name]").GetAttribute("value"));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task ReturningToSameName_StillRejectsAnOlderGenerationRead()
|
||||
{
|
||||
var (store, _, cipher) = RegisterServices();
|
||||
var a = new SecretName("app/a");
|
||||
var b = new SecretName("app/b");
|
||||
var oldRead = new TaskCompletionSource<StoredSecret?>(TaskCreationOptions.RunContinuationsAsynchronously);
|
||||
var readsOfA = 0;
|
||||
store.GetOverride = (name, ct) => name == a && ++readsOfA == 1 ? oldRead.Task
|
||||
: Task.FromResult<StoredSecret?>(cipher.Encrypt(name, "old", SecretContentType.Text) with { Description = "fresh metadata" });
|
||||
var cut = Render<SecretEditor>(p => p.Add(x => x.ExistingName, a));
|
||||
cut.Render(p => p.Add(x => x.ExistingName, b));
|
||||
cut.Render(p => p.Add(x => x.ExistingName, a));
|
||||
var before = cut.RenderCount;
|
||||
await cut.InvokeAsync(() => oldRead.SetResult(cipher.Encrypt(a, "old", SecretContentType.Text) with { Description = "stale metadata" }));
|
||||
cut.WaitForState(() => cut.RenderCount > before);
|
||||
Assert.Equal("fresh metadata", cut.Find("[data-testid=secret-description]").GetAttribute("value"));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void TargetChange_ResetsTombstoneRestoreConfirmation()
|
||||
{
|
||||
var (store, _, cipher) = RegisterServices();
|
||||
store.Seed(cipher.Encrypt(new SecretName("app/retired"), "old", SecretContentType.Text) with { IsDeleted = true });
|
||||
AuthorizeManager();
|
||||
var cut = Render<SecretEditor>();
|
||||
cut.Find("[data-testid=secret-name]").Change("app/retired");
|
||||
cut.Find("[data-testid=secret-value]").Change("new");
|
||||
cut.Find("[data-testid=editor-submit]").Click();
|
||||
Assert.Empty(store.Upserts);
|
||||
cut.Render(p => p.Add(x => x.ExistingName, new SecretName("app/other")));
|
||||
cut.Render(p => p.Add(x => x.ExistingName, (SecretName?)null));
|
||||
cut.Find("[data-testid=secret-name]").Change("app/retired");
|
||||
cut.Find("[data-testid=secret-value]").Change("another new value");
|
||||
cut.Find("[data-testid=editor-submit]").Click();
|
||||
Assert.Empty(store.Upserts);
|
||||
Assert.Contains("deleted secret", cut.Find("[data-testid=editor-error]").TextContent);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task PendingWrite_CannotBeCancelledOrSubmittedTwice()
|
||||
{
|
||||
var (store, _, _) = RegisterServices();
|
||||
var entered = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
|
||||
var release = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
|
||||
store.UpsertOverride = (_, _) => { entered.TrySetResult(); return release.Task; };
|
||||
AuthorizeManager();
|
||||
var cancelled = false;
|
||||
var saved = false;
|
||||
var cut = Render<SecretEditor>(p => p.Add(x => x.OnCancelled, () => cancelled = true).Add(x => x.OnSaved, () => saved = true));
|
||||
cut.Find("[data-testid=secret-name]").Change("app/new");
|
||||
cut.Find("[data-testid=secret-value]").Change("synthetic value");
|
||||
var pending = cut.Find("[data-testid=editor-submit]").ClickAsync(new MouseEventArgs());
|
||||
await entered.Task;
|
||||
try
|
||||
{
|
||||
Assert.True(cut.Find("[data-testid=editor-cancel]").HasAttribute("disabled"));
|
||||
cut.Find("[data-testid=editor-cancel]").Click();
|
||||
cut.Find("[data-testid=editor-submit]").Click();
|
||||
Assert.False(cancelled);
|
||||
Assert.False(saved);
|
||||
Assert.Empty(store.Upserts);
|
||||
}
|
||||
finally { release.TrySetResult(); await pending; }
|
||||
Assert.Single(store.Upserts);
|
||||
Assert.True(saved);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task SupersededPendingWrite_PreservesCapturedTargetAuditAndCacheButNotSavedCallback()
|
||||
{
|
||||
var (store, audit, cipher) = RegisterServices();
|
||||
var cache = new RecordingCacheInvalidator();
|
||||
Services.AddSingleton<ISecretCacheInvalidator>(cache);
|
||||
var entered = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
|
||||
var release = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
|
||||
store.UpsertOverride = (_, _) => { entered.TrySetResult(); return release.Task; };
|
||||
var a = new SecretName("app/a");
|
||||
AuthorizeManager();
|
||||
var saved = false;
|
||||
var cut = Render<SecretEditor>(p => p.Add(x => x.ExistingName, a).Add(x => x.OnSaved, () => saved = true));
|
||||
cut.Find("[data-testid=secret-value]").Change("new-a");
|
||||
var pending = cut.Find("[data-testid=editor-submit]").ClickAsync(new MouseEventArgs());
|
||||
await entered.Task;
|
||||
try { cut.Render(p => p.Add(x => x.ExistingName, (SecretName?)null)); }
|
||||
finally { release.TrySetResult(); await pending; }
|
||||
var row = Assert.Single(store.Upserts);
|
||||
Assert.Equal(a, row.Name);
|
||||
Assert.Equal("new-a", cipher.Decrypt(row));
|
||||
var evt = Assert.Single(audit.Events);
|
||||
Assert.Equal("secret.rotate", evt.Action);
|
||||
Assert.Equal(a.Value, evt.Target);
|
||||
Assert.Equal(a, Assert.Single(cache.Invalidated));
|
||||
Assert.False(saved);
|
||||
Assert.Equal("", cut.Find("[data-testid=secret-value]").GetAttribute("value") ?? "");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task TargetChangeDuringAuthorization_DoesNotWriteTheNewTargetWithTheOldDraft()
|
||||
{
|
||||
var (store, _, _) = RegisterServices();
|
||||
AuthorizeManager();
|
||||
var authState = new TaskCompletionSource<AuthenticationState>(TaskCreationOptions.RunContinuationsAsynchronously);
|
||||
RenderFragment EditorFor(SecretName name) => builder =>
|
||||
{
|
||||
builder.OpenComponent<SecretEditor>(0);
|
||||
builder.AddAttribute(1, nameof(SecretEditor.ExistingName), (object)name);
|
||||
builder.CloseComponent();
|
||||
};
|
||||
var cut = Render<CascadingValue<Task<AuthenticationState>>>(p => p
|
||||
.Add(x => x.Value, authState.Task).AddChildContent(EditorFor(new SecretName("app/a"))));
|
||||
cut.Find("[data-testid=secret-value]").Change("draft for a");
|
||||
var pending = cut.Find("[data-testid=editor-submit]").ClickAsync(new MouseEventArgs());
|
||||
cut.Render(p => p.Add(x => x.Value, authState.Task).AddChildContent(EditorFor(new SecretName("app/b"))));
|
||||
authState.SetResult(new AuthenticationState(new ClaimsPrincipal(
|
||||
new ClaimsIdentity([new Claim(ClaimTypes.Name, "reviewer")], "fixture"))));
|
||||
await pending;
|
||||
Assert.Empty(store.Upserts);
|
||||
Assert.Equal("app/b", cut.Find("[data-testid=secret-name]").GetAttribute("value"));
|
||||
Assert.Equal("", cut.Find("[data-testid=secret-value]").GetAttribute("value") ?? "");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task DisposalAfterCommit_StillInvalidatesCapturedTargetWithoutCallingSaved()
|
||||
{
|
||||
var (store, _, _) = RegisterServices();
|
||||
var audit = new DelayedSuccessAuditWriter();
|
||||
var cache = new RecordingCacheInvalidator();
|
||||
Services.AddSingleton<IAuditWriter>(audit);
|
||||
Services.AddSingleton<ISecretCacheInvalidator>(cache);
|
||||
AuthorizeManager();
|
||||
var saved = false;
|
||||
var a = new SecretName("app/a");
|
||||
RenderFragment editor = builder =>
|
||||
{
|
||||
builder.OpenComponent<SecretEditor>(0);
|
||||
builder.AddAttribute(1, nameof(SecretEditor.ExistingName), (object)a);
|
||||
builder.AddAttribute(2, nameof(SecretEditor.OnSaved), EventCallback.Factory.Create(this, () => saved = true));
|
||||
builder.CloseComponent();
|
||||
};
|
||||
var cut = Render<CascadingValue<bool>>(p => p.Add(x => x.Value, true).AddChildContent(editor));
|
||||
cut.Find("[data-testid=secret-value]").Change("synthetic new value");
|
||||
var pending = cut.Find("[data-testid=editor-submit]").ClickAsync(new MouseEventArgs());
|
||||
await audit.Entered.Task;
|
||||
Assert.Single(store.Upserts); // The mutation has already committed.
|
||||
cut.Render(p => p.Add(x => x.Value, true).AddChildContent((RenderFragment)(_ => { }))); // Unmount through the renderer, invoking IDisposable.
|
||||
audit.Release.SetResult();
|
||||
await pending;
|
||||
Assert.Equal(a, Assert.Single(cache.Invalidated));
|
||||
Assert.False(saved);
|
||||
Assert.Equal(AuditOutcome.Success, Assert.Single(audit.Events).Outcome);
|
||||
Assert.Equal(a.Value, audit.Events[0].Target);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task CommittedWrite_EvictsCapturedCacheWhenProviderRejectsLateResolution()
|
||||
{
|
||||
var (store, audit, _) = RegisterServices();
|
||||
// Exercise the logging path too: audit failure after commit must not need the dead scope.
|
||||
audit.SuccessFault = new InvalidOperationException("synthetic audit outage");
|
||||
var cache = new RecordingCacheInvalidator();
|
||||
Services.AddSingleton<ISecretCacheInvalidator>(cache);
|
||||
var provider = new LateResolutionGuardProvider(Services);
|
||||
var entered = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
|
||||
var release = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
|
||||
store.UpsertOverride = (_, _) => { entered.TrySetResult(); return release.Task; };
|
||||
AuthorizeManager();
|
||||
var a = new SecretName("app/a");
|
||||
var cut = Render<SecretEditor>(p => p.Add(x => x.ExistingName, a));
|
||||
// bUnit's built-in IServiceProvider resolves itself. Replace only this injected seam
|
||||
// after rendering so the fixture can model a circuit scope rejecting late resolution.
|
||||
typeof(SecretEditor).GetProperty("Services", System.Reflection.BindingFlags.Instance | System.Reflection.BindingFlags.NonPublic)!
|
||||
.SetValue(cut.Instance, provider);
|
||||
cut.Find("[data-testid=secret-value]").Change("synthetic new value");
|
||||
var pending = cut.Find("[data-testid=editor-submit]").ClickAsync(new MouseEventArgs());
|
||||
await entered.Task;
|
||||
Assert.True(provider.ResolutionCount > 0);
|
||||
provider.RejectResolutions = true;
|
||||
release.SetResult();
|
||||
await pending;
|
||||
Assert.Single(store.Upserts);
|
||||
Assert.Equal(a, Assert.Single(cache.Invalidated));
|
||||
Assert.Empty(cut.FindAll("[data-testid=editor-error]"));
|
||||
}
|
||||
|
||||
private sealed class LateResolutionGuardProvider(IServiceProvider inner) : IServiceProvider
|
||||
{
|
||||
public bool RejectResolutions { get; set; }
|
||||
public int ResolutionCount { get; private set; }
|
||||
public object? GetService(Type serviceType)
|
||||
{
|
||||
++ResolutionCount;
|
||||
if (RejectResolutions) throw new ObjectDisposedException("synthetic circuit provider");
|
||||
return inner.GetService(serviceType);
|
||||
}
|
||||
}
|
||||
|
||||
private sealed class DelayedSuccessAuditWriter : IAuditWriter
|
||||
{
|
||||
public TaskCompletionSource Entered { get; } = new(TaskCreationOptions.RunContinuationsAsynchronously);
|
||||
public TaskCompletionSource Release { get; } = new(TaskCreationOptions.RunContinuationsAsynchronously);
|
||||
public List<AuditEvent> Events { get; } = [];
|
||||
public async Task WriteAsync(AuditEvent evt, CancellationToken ct = default)
|
||||
{
|
||||
Entered.TrySetResult();
|
||||
await Release.Task; // Deliberately ignore cancellation after the captured mutation committed.
|
||||
Events.Add(evt);
|
||||
}
|
||||
}
|
||||
|
||||
private void AuthorizeManager()
|
||||
{
|
||||
var auth = this.AddAuthorization();
|
||||
auth.SetAuthorized("reviewer");
|
||||
auth.SetPolicies(SecretsAuthorization.ManagePolicy);
|
||||
}
|
||||
|
||||
private static void AssertNoValueLeak(AuditEvent evt, string value = EnteredValue)
|
||||
{
|
||||
foreach (string? field in new[] { evt.Action, evt.Actor, evt.Category, evt.Target, evt.DetailsJson, evt.ToString() })
|
||||
|
||||
@@ -1,6 +1,8 @@
|
||||
using Bunit;
|
||||
using Bunit.TestDoubles;
|
||||
using Microsoft.Extensions.DependencyInjection;
|
||||
using Microsoft.AspNetCore.Components.Web;
|
||||
using ZB.MOM.WW.Secrets.Ui.Components;
|
||||
using ZB.MOM.WW.Audit;
|
||||
using ZB.MOM.WW.Secrets.Abstractions;
|
||||
using ZB.MOM.WW.Secrets.Ui;
|
||||
@@ -104,6 +106,115 @@ public class SecretsListTests : BunitContext
|
||||
Assert.Contains("No secrets", cut.Markup);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ChangingRows_ReplacesTheEditorAndClearsAnotherRowsDraft()
|
||||
{
|
||||
RegisterEditableStore();
|
||||
var cut = Render<SecretsList>();
|
||||
cut.Find(".rotate-secret[data-secret-name='db/primary']").Click();
|
||||
var original = cut.FindComponent<SecretEditor>().Instance;
|
||||
cut.Find("[data-testid=secret-value]").Change("draft for primary");
|
||||
cut.Find(".rotate-secret[data-secret-name='api/token']").Click();
|
||||
Assert.NotSame(original, cut.FindComponent<SecretEditor>().Instance);
|
||||
Assert.Equal("api/token", cut.Find("[data-testid=secret-name]").GetAttribute("value"));
|
||||
Assert.Equal("External API token", cut.Find("[data-testid=secret-description]").GetAttribute("value"));
|
||||
Assert.Equal("", cut.Find("[data-testid=secret-value]").GetAttribute("value") ?? "");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void SelectingSameRow_PreservesItsEditorAndDraft()
|
||||
{
|
||||
RegisterEditableStore();
|
||||
var cut = Render<SecretsList>();
|
||||
cut.Find(".rotate-secret[data-secret-name='db/primary']").Click();
|
||||
var original = cut.FindComponent<SecretEditor>().Instance;
|
||||
cut.Find("[data-testid=secret-value]").Change("same target draft");
|
||||
cut.Find(".rotate-secret[data-secret-name='db/primary']").Click();
|
||||
Assert.Same(original, cut.FindComponent<SecretEditor>().Instance);
|
||||
Assert.Equal("same target draft", cut.Find("[data-testid=secret-value]").GetAttribute("value"));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task SupersededSavedCallback_DoesNotCloseANewerEditor()
|
||||
{
|
||||
RegisterEditableStore();
|
||||
var cut = Render<SecretsList>();
|
||||
cut.Find(".rotate-secret[data-secret-name='db/primary']").Click();
|
||||
var oldSaved = cut.FindComponent<SecretEditor>().Instance.OnSaved;
|
||||
cut.Find("[data-testid=add-secret]").Click();
|
||||
cut.Find("[data-testid=secret-name]").Change("app/new-draft");
|
||||
await cut.InvokeAsync(() => oldSaved.InvokeAsync());
|
||||
Assert.Single(cut.FindComponents<SecretEditor>());
|
||||
Assert.Equal("app/new-draft", cut.Find("[data-testid=secret-name]").GetAttribute("value"));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task PendingMutation_DisablesParentTargetSwitchingUntilCompletion()
|
||||
{
|
||||
var store = RegisterEditableStore();
|
||||
var entered = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
|
||||
var release = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
|
||||
store.UpsertOverride = (_, _) => { entered.TrySetResult(); return release.Task; };
|
||||
var cut = Render<SecretsList>();
|
||||
cut.Find(".rotate-secret[data-secret-name='db/primary']").Click();
|
||||
cut.Find("[data-testid=secret-value]").Change("new synthetic value");
|
||||
var pending = cut.Find("[data-testid=editor-submit]").ClickAsync(new MouseEventArgs());
|
||||
await entered.Task;
|
||||
try
|
||||
{
|
||||
Assert.True(cut.Find("[data-testid=add-secret]").HasAttribute("disabled"));
|
||||
Assert.All(cut.FindAll(".rotate-secret, .delete-secret"), button => Assert.True(button.HasAttribute("disabled")));
|
||||
cut.Find("[data-testid=add-secret]").Click();
|
||||
cut.Find(".rotate-secret[data-secret-name='api/token']").Click();
|
||||
cut.Find("[data-testid=editor-cancel]").Click();
|
||||
Assert.Equal("db/primary", cut.Find("[data-testid=secret-name]").GetAttribute("value"));
|
||||
Assert.Empty(store.Upserts);
|
||||
}
|
||||
finally { release.TrySetResult(); await pending; }
|
||||
cut.WaitForAssertion(() => Assert.Empty(cut.FindComponents<SecretEditor>()));
|
||||
Assert.Equal("db/primary", Assert.Single(store.Upserts).Name.Value);
|
||||
Assert.False(cut.Find("[data-testid=add-secret]").HasAttribute("disabled"));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task OldBusyCallback_CannotUnlockANewerPendingEditor()
|
||||
{
|
||||
var store = RegisterEditableStore();
|
||||
var release = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
|
||||
var entered = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
|
||||
store.UpsertOverride = (_, _) => { entered.TrySetResult(); return release.Task; };
|
||||
var cut = Render<SecretsList>();
|
||||
cut.Find(".rotate-secret[data-secret-name='db/primary']").Click();
|
||||
var oldBusy = cut.FindComponent<SecretEditor>().Instance.OnBusyChanged;
|
||||
cut.Find(".rotate-secret[data-secret-name='api/token']").Click();
|
||||
cut.Find("[data-testid=secret-value]").Change("synthetic replacement");
|
||||
var pending = cut.Find("[data-testid=editor-submit]").ClickAsync(new MouseEventArgs());
|
||||
await entered.Task;
|
||||
try
|
||||
{
|
||||
await cut.InvokeAsync(() => oldBusy.InvokeAsync(false));
|
||||
Assert.True(cut.Find("[data-testid=add-secret]").HasAttribute("disabled"));
|
||||
Assert.Equal("api/token", cut.Find("[data-testid=secret-name]").GetAttribute("value"));
|
||||
}
|
||||
finally { release.TrySetResult(); await pending; }
|
||||
Assert.Single(store.Upserts);
|
||||
}
|
||||
|
||||
private RecordingSecretStore RegisterEditableStore()
|
||||
{
|
||||
var store = new RecordingSecretStore();
|
||||
var cipher = new FakeCipher();
|
||||
foreach (var metadata in new[] { SecretOne, SecretTwo })
|
||||
store.Seed(cipher.Encrypt(metadata.Name, "synthetic fixture", metadata.ContentType) with { Description = metadata.Description });
|
||||
Services.AddSingleton<ISecretStore>(store);
|
||||
Services.AddSingleton<ISecretCipher>(cipher);
|
||||
Services.AddSingleton<IAuditWriter>(new CapturingAuditWriter());
|
||||
var auth = this.AddAuthorization();
|
||||
auth.SetAuthorized("reviewer");
|
||||
auth.SetPolicies(SecretsAuthorization.ManagePolicy);
|
||||
return store;
|
||||
}
|
||||
|
||||
/// <summary>Minimal hand-written <see cref="ISecretStore"/> whose only real behavior is <see cref="ListAsync"/>.</summary>
|
||||
private sealed class FakeSecretStore(IReadOnlyList<SecretMetadata> rows) : ISecretStore
|
||||
{
|
||||
|
||||
Reference in New Issue
Block a user