fix(secrets): audit malformed ${secret:} tokens, cap SecretName at 450, resolve local UNC shares (scadaproj#52)
Claude-Session: https://claude.ai/code/session_01GT67AEHd2Acv1YPwGfXEoV
This commit is contained in:
+28
@@ -173,6 +173,34 @@ public sealed class ReferenceAuditorTests : IDisposable
|
||||
Assert.Equal(ReferenceStatus.Missing, findings.Single(f => f.SecretName == "api/key").Status);
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData("${secret:}")]
|
||||
[InlineData("${secret: }")]
|
||||
[InlineData("prefix ${secret:unterminated")]
|
||||
[InlineData("${secret:a${secret:b}")]
|
||||
public async Task Malformed_token_yields_Malformed_finding_matching_the_expander(string value)
|
||||
{
|
||||
SecretsSession session = await Open(EnvKey(), Config(("Bad:Ref", value), ("Good:Ref", "${secret:api/key}")));
|
||||
|
||||
IReadOnlyList<ReferenceFinding> findings =
|
||||
await new ReferenceAuditor().AuditAsync(session, CancellationToken.None);
|
||||
|
||||
ReferenceFinding bad = findings.Single(f => f.Status == ReferenceStatus.Malformed);
|
||||
Assert.Equal(["Bad:Ref"], bad.ConfigPaths);
|
||||
Assert.Equal(ReferenceStatus.Missing, findings.Single(f => f.SecretName == "api/key").Status);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Well_formed_tokens_produce_no_Malformed_finding()
|
||||
{
|
||||
SecretsSession session = await Open(EnvKey(), Config(("A", "x ${secret:a/b} y ${secret:c}")));
|
||||
|
||||
IReadOnlyList<ReferenceFinding> findings =
|
||||
await new ReferenceAuditor().AuditAsync(session, CancellationToken.None);
|
||||
|
||||
Assert.DoesNotContain(findings, f => f.Status == ReferenceStatus.Malformed);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Comment_keys_are_skipped_like_the_expander()
|
||||
{
|
||||
|
||||
Reference in New Issue
Block a user