diff --git a/ZB.MOM.WW.Overview/src/ZB.MOM.WW.Overview/Components/Widgets/InstanceCard.razor b/ZB.MOM.WW.Overview/src/ZB.MOM.WW.Overview/Components/Widgets/InstanceCard.razor index a1c90ad..6d7af1c 100644 --- a/ZB.MOM.WW.Overview/src/ZB.MOM.WW.Overview/Components/Widgets/InstanceCard.razor +++ b/ZB.MOM.WW.Overview/src/ZB.MOM.WW.Overview/Components/Widgets/InstanceCard.razor @@ -77,8 +77,9 @@ @foreach (var entry in Entries) {
- + @entry.Key + @CheckStatusLabel(entry.Value.Status) @entry.Value.Description
} @@ -391,6 +392,12 @@ /// private string? HistorianPoolClass => HistorianPools.Any(p => p.Failures > 0) ? "bad" : null; + private static string CheckStatusLabel(string? status) => status switch + { + "Healthy" or "Degraded" or "Unhealthy" => status, + _ => "Unknown", + }; + private static string DotClass(string? status) => status switch { "Healthy" => "ok", diff --git a/ZB.MOM.WW.Overview/tests/ZB.MOM.WW.Overview.Tests/InstanceCardTests.cs b/ZB.MOM.WW.Overview/tests/ZB.MOM.WW.Overview.Tests/InstanceCardTests.cs index 3d03425..e69b5ad 100644 --- a/ZB.MOM.WW.Overview/tests/ZB.MOM.WW.Overview.Tests/InstanceCardTests.cs +++ b/ZB.MOM.WW.Overview/tests/ZB.MOM.WW.Overview.Tests/InstanceCardTests.cs @@ -49,6 +49,35 @@ public class InstanceCardTests : BunitContext .Add(c => c.Now, Now) .Add(c => c.IsLeader, isLeader)); + [Theory] + [InlineData("Healthy", "Healthy", "ok")] + [InlineData("Degraded", "Degraded", "warn")] + [InlineData("Unhealthy", "Unhealthy", "bad")] + [InlineData(null, "Unknown", "idle")] + [InlineData("FutureState", "Unknown", "idle")] + [InlineData("", "Unknown", "idle")] + public void CheckRow_ExposesItsStatusWithoutInferringDescription( + string? status, string label, string stateClass) + { + var report = new ZbHealthReport + { + Status = "Degraded", + Entries = new Dictionary + { + ["database"] = new() { Status = status, Description = "remote " }, + }, + }; + var cut = Render(Card(report: report)); + var row = cut.Find(".check-row"); + var state = row.QuerySelector(".check-state"); + Assert.NotNull(state); + Assert.Equal(label, state.TextContent); + Assert.Contains($"s-{stateClass}", state.ClassList); + Assert.Equal("true", row.QuerySelector(".check-dot")!.GetAttribute("aria-hidden")); + Assert.Equal("remote ", row.QuerySelector(".check-desc")!.TextContent); + Assert.Empty(row.QuerySelectorAll("description")); + } + [Theory] [InlineData(InstanceStatus.Up, "up", "Up")] [InlineData(InstanceStatus.Degraded, "degraded", "Degraded")]