From b4c24713b92f84e5ad1c48d0be82f2a7b9446192 Mon Sep 17 00:00:00 2001 From: Joseph Doherty Date: Sat, 14 Nov 2026 01:19:05 -0500 Subject: [PATCH] Record final OT caller checkpoints and BT peer evidence --- .../ui-theme/validation/btdb-ui/peer-review.md | 17 +++++++++++++++++ .../EXECUTION.md | 11 +++++++++++ 2 files changed, 28 insertions(+) create mode 100644 components/ui-theme/validation/btdb-ui/peer-review.md diff --git a/components/ui-theme/validation/btdb-ui/peer-review.md b/components/ui-theme/validation/btdb-ui/peer-review.md new file mode 100644 index 0000000..7652bee --- /dev/null +++ b/components/ui-theme/validation/btdb-ui/peer-review.md @@ -0,0 +1,17 @@ +# BTDB BT00–01 independent peer review + +Read-only review of the pending BTDB codex/scada-ui-consistency source checkpoint, including App script order, Theme pin, DialogHost, EditableRows, shared native-event adapter, typed service and existing/new tests. Later BT02/03 form edits are outside this review. No BTDB source edit, test execution, production/DB interaction or deployment was performed by this reviewer. + +## Concrete findings and reviewed corrections + +1. **P2 delayed focus restoration could steal user/fatal recovery focus.** The original400ms disabled-trigger observer/timer could survive after the user focused another control, or after fatal UI deactivated overlays and explicitly focused Reload. Its later callback would focus the old Save or H1. The original browser assertion checked fatal focus immediately. The author now cancels pending restoration on native focus/pointer interaction, new activation and fatal recovery, and restore itself refuses to move focus while fatal recovery is visible. Source re-reviewed; the retained17-check browser result includes deliberate newer-focus persistence and Reload focus beyond550ms, plus prior stack/rollback/cleanup cases. This finding is resolved in the current pending source. + +2. **P2 existing custom DialogContext completion was not target-bound.** This pre-existing service gap was not introduced by the adapter diff: ShowAsync supplied bare global Resolve, so A-context/cancel-A/open-B/old-A.Close(true) completed B. Actual MachineForm/BatchEdit custom bool confirmation callers use these contexts. The author now captures the pending TCS and resolves only while that identity remains current, without changing public APIs or typed defaults. Actual new regression failed before (B became null/resolved) and passes after; DialogServiceTests6/6 green. Source guard re-reviewed. This finding is resolved in the current pending source. + +## Remaining source assessment + +No further concrete BT00–01 blocker found. Both local adapters capture rendered target/generation, serialize activation/deactivation, clean attempted late activation before releasing callback references, and ignore stale native Escape identities. Existing typed confirm/prompt/custom cancel outcomes remain owned by DialogService. EditableRows retains Clone rollback, cancelled-new-row removal, local Done classification and replacement/disposal restoration; no Done-to-database-save behavior was introduced. + +The shared DOM namespace attaches real element keydown handlers with synchronous preventDefault, top-only Escape/Tab/focus containment, refcounted inert restoration and previous body state. Fatal Reload/reconnect nodes are excluded from background inertness/containment; the new pending-restore cancellation preserves that recovery focus. App loads the module after fatal markup and before Blazor, with existing asset-version stamping. Theme is the sole initial graph delta0.4.1→1.0.1; BTDB's deliberate non-central package style and product/domain ownership are preserved. + +Evidence read, not rerun: BT01-manager.trx430/430; BT01-lifecycle.trx20/20; native browser result17passing functional checks with0page errors/0repository saves; custom-context red1failed then6focused green. These are checkpoint counts, not a claim that every later BT02/03 edit or final chapter matrix has been verified. Browser checks are a scenario's functional assertions, not17independent viewport scenes. Final current-source full-suite/viewport acceptance remains the author/parent chapter gate. diff --git a/docs/plans/2026-11-12-scada-ui-consistency/EXECUTION.md b/docs/plans/2026-11-12-scada-ui-consistency/EXECUTION.md index 0b22616..2479941 100644 --- a/docs/plans/2026-11-12-scada-ui-consistency/EXECUTION.md +++ b/docs/plans/2026-11-12-scada-ui-consistency/EXECUTION.md @@ -163,3 +163,14 @@ The user’s November14 instruction “Don’t do voiceover tests” removes Voi OT standalone UNS wrappers a0aa4f02/cleanup1d251d7e passed50tests,12native284checks,4invalid8states and6current-error scenes. Review reproduced and corrected queued script-identity mutation and retired CSV draft mutation before acceptance. Read-only Scripts source disclosure f953d230/cleanup8f0bf834 passed28tests/3native51checks, preserving its actual lazy read-only contract. Raw manual/browse ea5bb6a0 passed163tests/12native contexts plus final affected-six confirmation, current source/API and served-asset checks. All owned standalone fixtures are stopped. Parent callbacks and remaining operation/editor integration still keep OT13 open. Shared focus071148e9 has9native51checks plus10existing cases: busy/removed focus stays reachable, outside gaps are intercepted before background shortcuts, child-widget handling and generation-aware teardown remain. The bounded preactivation investigation78b95cab does not establish a composed user-timing defect; no additional shared-source change was inferred. G3 support827b282/9796aa6 found zero package-version mismatches. HG8f7efdb records only the previously classified two shutdown log lines; no product change. G3 is not yet closed. + + +## Final OT caller and driver-controls checkpoint + +Raw composed callers8929f5f3 passed157 focused cases and eight final native scenes, including late read ownership and retained ordinary expansion behavior. Global UNS callersaa919ceef passed44 focused and16 native cases: captured target/version callbacks, read epochs, last-good recovery and confirmed-write/read-failure separation. Earlier shared wrapper coverage does not substitute for these parent checks. + +Script editor7bd013a57/cleanup575f81abe passed153 focused and72 functional assertions across six native scenes. Phone/real200 retargeting exposes a bounded vendored Monaco word-highlighter cancellation (`Canceled`); source stack and functional state/focus/retirement proofs are retained in the slice evidence. No vendor patch, global error suppression or feature disable was introduced. This is a recorded runtime limitation, not zero-error acceptance for those two scenes. + +Hosts parentfc4053f0c passed45 focused and12 actual native contexts, with independent source review. It uses the shared ModalFrame around the panel’s inline restart group, rejects stale/busy callbacks and preserves eight existing read/lifecycle bodies byte-for-byte. Long identifiers moved to the complete wrapped body description after a genuine195CSSpx chrome-clipping failure; final direct-CDP720/195 native200% screenshots and geometry verify both header and footer remain inside the viewport. Owned18142 listener is stopped. Panel operations3ae92f4d/b3f6001f have71 focused checks, including restored pre-dispatch driver filtering. An observed stale-panel opacity contrast issue is explicitly reserved for OT14. + +Equipment and Alerts remain under active caller/field review. OT06/13/14 and G3 remain open;97of100 accepted. VoiceOver is excluded by user instruction.