fix(overview): report freshness separately from reachability

This commit is contained in:
Joseph Doherty
2026-11-13 16:32:15 -05:00
parent 89e383a196
commit b300784092
2 changed files with 78 additions and 16 deletions
@@ -76,7 +76,7 @@ else
<section class="app-section rise" id="@MainLayout.Slug(application.Name)" data-testid="application">
<div class="app-head">
<h2>@application.Name</h2>
<StatusPill State="RollupState(application)">@RollupLabel(application)</StatusPill>
<StatusPill State="RollupState(application, now)">@RollupLabel(application, now)</StatusPill>
<span class="spacer"></span>
<span class="app-meta">@AppMeta(application)</span>
</div>
@@ -216,9 +216,13 @@ else
private static string GroupMeta(IGrouping<string?, InstanceSnapshot> group, DateTimeOffset now)
{
var members = group.Count();
var missing = group.Count(i => i.Status is InstanceStatus.Unreachable || i.IsStale(now));
var unreachable = group.Count(i => i.Status is InstanceStatus.Unreachable);
var stale = group.Count(i => i.IsStale(now));
var pending = group.Count(i => i.Status is null);
var pendingText = pending == 0 ? string.Empty : $" · {pending} pending";
return $"{members} member{(members == 1 ? "" : "s")} · {missing} unreachable";
// These are explicitly named, overlapping observations, not a summed unique total.
return $"{members} member{(members == 1 ? "" : "s")} · {unreachable} unreachable · {stale} stale{pendingText}";
}
private static bool IsLeader(ApplicationSnapshot application, InstanceSnapshot instance) =>
@@ -226,22 +230,34 @@ else
application.GroupFor(group)?.LeaderInstance is { } leader &&
string.Equals(leader, instance.Instance, StringComparison.Ordinal);
private static StatusState RollupState(ApplicationSnapshot application) => application.Worst switch
private static StatusState RollupState(ApplicationSnapshot application, DateTimeOffset now)
{
InstanceStatus.Up => StatusState.Ok,
InstanceStatus.Degraded => StatusState.Warn,
InstanceStatus.Down or InstanceStatus.Unreachable => StatusState.Bad,
_ => StatusState.Idle,
};
if (application.Worst == InstanceStatus.Up && application.Instances.Any(i => i.IsStale(now)))
return StatusState.Warn;
private static string RollupLabel(ApplicationSnapshot application) => application.Worst switch
return application.Worst switch
{
InstanceStatus.Up => StatusState.Ok,
InstanceStatus.Degraded => StatusState.Warn,
InstanceStatus.Down or InstanceStatus.Unreachable => StatusState.Bad,
_ => StatusState.Idle,
};
}
private static string RollupLabel(ApplicationSnapshot application, DateTimeOffset now)
{
InstanceStatus.Up => "Up",
InstanceStatus.Degraded => "Degraded",
InstanceStatus.Down => "Down",
InstanceStatus.Unreachable => "Unreachable",
_ => "Pending",
};
var status = application.Worst switch
{
InstanceStatus.Up => "Up",
InstanceStatus.Degraded => "Degraded",
InstanceStatus.Down => "Down",
InstanceStatus.Unreachable => "Unreachable",
_ => "Pending",
};
return application.Instances.Any(i => i.IsStale(now))
? $"Last known {status} · includes stale observations"
: status;
}
/// <inheritdoc/>
public void Dispose()