feat(overview): add optional attention filter and explicit sweep zone

This commit is contained in:
Joseph Doherty
2026-11-13 17:03:56 -05:00
parent 510d15d546
commit 7aeb9c6545
3 changed files with 197 additions and 10 deletions
@@ -20,6 +20,7 @@ public class OverviewPageTests : BunitContext
{
Services.AddSingleton(_store);
Services.AddSingleton<TimeProvider>(_time);
JSInterop.SetupVoid("Blazor._internal.domWrapper.focus", _ => true);
}
private static InstanceSnapshot Node(
@@ -58,6 +59,118 @@ public class OverviewPageTests : BunitContext
private IRenderedComponent<Components.Pages.Overview> RenderPage() =>
Render<Components.Pages.Overview>();
[Fact]
public void NeedsAttentionFilter_KeepsStaleAndRestoresTheFullFleet()
{
_store.Publish(Snapshot(Node("fresh", InstanceStatus.Up),
Node("old", InstanceStatus.Up, lastPolled: Now.AddMinutes(-5)), Node("down", InstanceStatus.Down)));
var snapshot = _store.Current;
var cut = RenderPage();
Assert.False(cut.Find("input[data-testid=attention-filter]").HasAttribute("checked"));
cut.Find("input[data-testid=attention-filter]").Change(true);
Assert.Equal(new[] { "old", "down" }, cut.FindAll("[data-testid=instance-card]")
.Select(e => e.GetAttribute("data-instance")));
Assert.Equal("3", cut.Find(".agg-card .agg-value").ChildNodes[0].TextContent);
Assert.Same(snapshot, _store.Current);
cut.Find("input[data-testid=attention-filter]").Change(false);
Assert.Equal(3, cut.FindAll("[data-testid=instance-card]").Count);
Assert.Contains("UTC", cut.Find(".page-meta").TextContent, StringComparison.Ordinal);
}
[Fact]
public void PendingObservation_IsExplicitAndNotClassifiedAsAnObservedFailure()
{
_store.Publish(Snapshot(Node("waiting", null)));
var cut = RenderPage();
cut.Find("input[data-testid=attention-filter]").Change(true);
Assert.Empty(cut.FindAll("[data-testid=instance-card]"));
Assert.Contains("1 pending", cut.Find("[data-testid=attention-pending]").TextContent, StringComparison.Ordinal);
Assert.Contains("No matching instances", cut.Find("[data-testid=attention-empty]").TextContent, StringComparison.Ordinal);
cut.Find("[data-testid=attention-clear]").Click();
Assert.Equal("waiting", cut.Find("[data-testid=instance-card]").GetAttribute("data-instance"));
Assert.Contains("Pending", cut.Find("[data-testid=instance-card]").TextContent, StringComparison.Ordinal);
}
[Fact]
public void EmptyAttentionFilter_CanRestoreHealthyInstancesWithoutChangingFleetTotals()
{
_store.Publish(Snapshot(Node("healthy", InstanceStatus.Up)));
var cut = RenderPage();
cut.Find("input[data-testid=attention-filter]").Change(true);
Assert.Empty(cut.FindAll("[data-testid=instance-card]"));
Assert.Contains("No matching instances", cut.Find("[data-testid=attention-empty]").TextContent, StringComparison.Ordinal);
Assert.Equal("1", cut.Find("[data-testid=kpi-up]").TextContent);
cut.Find("[data-testid=attention-clear]").Click();
Assert.Single(cut.FindAll("[data-testid=instance-card]"));
Assert.False(cut.Find("input[data-testid=attention-filter]").HasAttribute("checked"));
}
[Fact]
public void AttentionFilter_DoesNotHideHealthyMembersOfASplitBrainGroup()
{
_store.Publish(Snapshot(Node("a", InstanceStatus.Up, "site-a", "akka.tcp://scadabridge@a:8082"),
Node("b", InstanceStatus.Up, "site-a", "akka.tcp://scadabridge@b:8082")));
var cut = RenderPage();
cut.Find("input[data-testid=attention-filter]").Change(true);
Assert.Equal(2, cut.FindAll("[data-testid=instance-card]").Count);
Assert.Contains("Split brain", cut.Markup, StringComparison.Ordinal);
}
[Fact]
public void SweepTime_UsesTheSnapshotUtcInstantRatherThanTheRenderClock()
{
var snapshot = Snapshot(Node("a", InstanceStatus.Up));
_store.Publish(snapshot with { GeneratedUtc = Now.AddMinutes(-10).ToOffset(TimeSpan.FromHours(5.5)) });
Assert.Contains("2026-07-24 11:50:00 UTC", RenderPage().Find(".page-meta").TextContent, StringComparison.Ordinal);
}
[Fact]
public void AttentionOutcome_DoesNotAnnounceBackgroundSnapshots()
{
_store.Publish(Snapshot(Node("a", InstanceStatus.Down)));
var cut = RenderPage();
cut.Find("input[data-testid=attention-filter]").Change(true);
var outcome = cut.Find("[data-testid=attention-outcome]").TextContent;
Assert.NotEmpty(outcome);
_store.Publish(Snapshot(Node("a", InstanceStatus.Down), Node("b", InstanceStatus.Degraded)));
Assert.Equal(2, cut.FindAll("[data-testid=instance-card]").Count);
Assert.Equal(outcome, cut.Find("[data-testid=attention-outcome]").TextContent);
}
[Fact]
public async Task QueuedSnapshot_DoesNotReplaceAViewPausedBeforeDispatcherAdoption()
{
_store.Publish(Snapshot(Node("original", InstanceStatus.Up)));
var cut = RenderPage();
await cut.InvokeAsync(() =>
{
// Queue a publisher callback while this synchronous dispatcher action owns the UI.
Task.Run(() => _store.Publish(Snapshot(Node("latest", InstanceStatus.Down)))).GetAwaiter().GetResult();
cut.Find("[data-testid=pause-toggle]").Click();
});
await cut.InvokeAsync(() => { }); // Dispatcher barrier: the queued adoption ran first.
cut.WaitForAssertion(() => Assert.Equal("original",
cut.Find("[data-testid=instance-card]").GetAttribute("data-instance")));
cut.Find("[data-testid=pause-toggle]").Click();
Assert.Equal("latest", cut.Find("[data-testid=instance-card]").GetAttribute("data-instance"));
}
[Fact]
public async Task QueuedSnapshot_AfterResumeCannotReplayAnOlderObservation()
{
_store.Publish(Snapshot(Node("original", InstanceStatus.Up)));
var cut = RenderPage();
await cut.InvokeAsync(() =>
{
Task.Run(() => _store.Publish(Snapshot(Node("intermediate", InstanceStatus.Down)))).GetAwaiter().GetResult();
cut.Find("[data-testid=pause-toggle]").Click();
_store.Publish(Snapshot(Node("latest", InstanceStatus.Up)));
cut.Find("[data-testid=pause-toggle]").Click();
});
await cut.InvokeAsync(() => { });
Assert.Equal("latest", cut.Find("[data-testid=instance-card]").GetAttribute("data-instance"));
}
[Theory]
[InlineData(InstanceStatus.Up, false, 0, 0)]
[InlineData(InstanceStatus.Up, true, 0, 1)]