From 6ef591ce1378a615e4c38089dc2a064c6bfed7d4 Mon Sep 17 00:00:00 2001 From: Joseph Doherty Date: Sat, 14 Nov 2026 02:21:22 -0500 Subject: [PATCH] Accept final OT grammar and inline-editor implementation --- .../2026-11-12-scada-ui-consistency/EXECUTION.md | 11 +++++++++++ .../2026-11-12-scada-ui-consistency/tasks.json | 14 +++++++++----- 2 files changed, 20 insertions(+), 5 deletions(-) diff --git a/docs/plans/2026-11-12-scada-ui-consistency/EXECUTION.md b/docs/plans/2026-11-12-scada-ui-consistency/EXECUTION.md index 586fe69..58f341c 100644 --- a/docs/plans/2026-11-12-scada-ui-consistency/EXECUTION.md +++ b/docs/plans/2026-11-12-scada-ui-consistency/EXECUTION.md @@ -192,3 +192,14 @@ Root contrastba8017ae9 fixes actual stale status readability:9of9beforepairs fai First combined Unit1493pass/1fail/0skip and first full2650pass/1fail/0skip are retained as failed checkpoints; they are not final acceptance. The full run exercised the owned private-SQL tests without skips. Root ef1609f52 replaces a render-triggered wait for JS-only modal activation with an actual invocation event, preserving all assertions;127focused pass. Existing tail-filter test receives dispatcher/render observation correction with all behavior assertions retained. No production lifecycle/tail patch follows from these test timing observations. The final actual admin/cluster matrix found RoleGrants missing field names/narrow overflow and Certificates unbroken empty-state PKI path overflow. These are the measured final correction batch, with business/query/auth bodies to remain unchanged. OT06/13/14 and G3 remain open;97of100 accepted. VoiceOver remains excluded. + + +## OT source and behavior accepted; final cleanup gate + +OT06 and OT13 are accepted. The final measured security/cluster corrections455c87487/03ace0f9e preserve business bodies. The84case confirmation’s82passes and two corrected ACL195cases remain separately recorded; the final Account/Secrets document-title coverage gap is closed by8targeted cases and two host PageTitle additions. Root final source/graph7013b6c verifies31authored Razor components/36templates, every host PageTitle and exact accepted official package/runtime bytes. DEBUG-only ContextMenu code-behind routing is a separate boundary. + +CollectionEditorcb26ed917 removes its nested overlay, retains cloned local row Save/Cancel and validator/serializer ownership, resolves original rows after reorder, rejects retired Save/Cancel and preserves busy ownership after awaited callbacks. Three actual pre-change regression failures are retained.24focused passes/0skips and4actual DriverConfigModal→OPC UA form scenes×14checks pass, including195CSSpx. The parent receives only the existing scrollable modifier after actual clipped chrome; its code body is unchanged. Owned18143 stopped. + +DriverTagPickerc8edd65f3 removes the other legacy overlay, captures current selection/callbacks and restores the exact originating Build control using seven bounded ref-only caller seams.861related tests/0skips,8actual Modbus composition scenes160assertions and4parent-chrome contexts pass, including195CSSpx. No live AB/FOCAS/SQL/TwinCAT/PLC browsing is implied. The one-class RawTag parent modifier preserves code semantics. All three owned picker listeners are stopped. Final authored overlay inventory contains onlyModalFrame. + +Current-source full OtOpcUa suite passes2674/2674 with0skips, including all1517Unit test identities, after the final two title metadata changes. Releasebuild has0warnings/errors;9actualservedCSS/font/JS checks match accepted bytes. The authored Impeccable detector has no findings; its bounded manual review retains the two accepted vendored Monaco cancellation records and finite-fixture limits. VoiceOver remains excluded.99of100tasksaccepted; only OT14 final evidence/credential scan/owned cleanup and coordinator G3 review remain. diff --git a/docs/plans/2026-11-12-scada-ui-consistency/tasks.json b/docs/plans/2026-11-12-scada-ui-consistency/tasks.json index 029dbea..b9e6cdf 100644 --- a/docs/plans/2026-11-12-scada-ui-consistency/tasks.json +++ b/docs/plans/2026-11-12-scada-ui-consistency/tasks.json @@ -718,11 +718,13 @@ "title": "Standardize page/table grammar across routes", "chapter": "OtOpcUa.md", "line": 173, - "status": "in_progress", + "status": "completed", "prerequisiteGates": [ "GB" ], - "dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task." + "dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task.", + "acceptedAt": "2026-11-14", + "evidence": "OtOpcUa03ace0f9e/455c87487; final84case grammar confirmation82passed plus2targeted ACL195 corrections;8targeted Account/Secrets title checks; root7013b6c final31component/36template source/graph inventory. Currentfull2674passed/0skipped." }, { "id": "OT-07", @@ -801,18 +803,20 @@ "title": "Roll field associations through every protocol family", "chapter": "OtOpcUa.md", "line": 331, - "status": "in_progress", + "status": "completed", "prerequisiteGates": [ "GB" ], - "dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task." + "dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task.", + "acceptedAt": "2026-11-14", + "evidence": "All protocol/common fields and composed callers accepted; final CollectionEditorcb26ed917 (24focused/4native\u00d714) and DriverTagPickerc8edd65f3 (861focused/8native\u00d720/4chrome) remove last nested shells. Finaloverlayinventory has onlyModalFrame. Currentfull2674passed/0skipped." }, { "id": "OT-14", "title": "Family consistency and release gate", "chapter": "OtOpcUa.md", "line": 347, - "status": "planned", + "status": "in_progress", "prerequisiteGates": [ "GB" ],