Accept interaction convergence and record split package rollout
This commit is contained in:
@@ -0,0 +1,34 @@
|
||||
# G2 common interaction acceptance and extraction decision
|
||||
|
||||
Status: interaction recipe verified across ScadaBridge managed overlays, ignitionoee registry native dialogs, and the MX/OEE router native pilots; retain validated app-local adapters for this release. Theme1.0.1 remains the common visual authority. No new package/API is introduced by this decision.
|
||||
|
||||
| Contract | MXAccess pilot | ignitionoee second pilot |
|
||||
|---|---|---|
|
||||
| Native modal lifecycle | `260d58af`, `docs/ui-validation/technical-light-dialogs.md` | `fb192405`, `docs/ui-validation/technical-light-family.md` |
|
||||
| Open/close, inert background, safe initial focus, native Tab/Escape | Actual four-viewport/browser proof; native browser chrome distinguished from document focus | Actual15/22/8 loaded-editor interaction cases |
|
||||
| Single active presentation, generation guards, pending cancel, disposal/import race | Deferred-import/lifecycle browser checks;343 dashboard tests | Same lifecycle contract adapted to17 modal instances/15 callers;1705 UI tests after follow-up |
|
||||
| Busy operation ownership | Caller owns operation and typed fields, JS owns DOM only | `ecf1380d`: disabled body fieldset plus detached submission snapshot before authorization await; three actual busy viewport cases |
|
||||
| Validation/recovery | Existing API-key validation remains visible outside long scroll body | Caller validation/footer remain outside disabled body; safe return focus |
|
||||
|
||||
Native Tab uses the browser's top layer. Browser chrome may receive focus; while the document has focus, focus must remain in the dialog. The MX/OEE router adapters do not add a custom Tab trap. This statement does not apply to the registry or ScadaBridge managed overlay. A rendered busy marker is reinforced by caller single-flight guards; no DOM helper invokes operations or receives secret values.
|
||||
|
||||
## Master-plan comparison: ScadaBridge and registry
|
||||
|
||||
| Responsibility | ScadaBridge managed overlay | ignitionoee registry native dialog |
|
||||
|---|---|---|
|
||||
| Presentation | App-owned `DialogHost.razor`/drawer with named modal roles; actual `dialog.js` activates the presentation | Actual `registry/src/Registry.Host/wwwroot/driverCatalog.js` calls native `showModal` |
|
||||
| Keyboard/background | Synchronous app Tab boundary handling and ancestor-sibling inert locks; typed Escape cancellation | Native top-layer modal **plus existing explicit Tab boundary wrap**; Escape routes to `DismissEditor` |
|
||||
| Initial/return focus | Caller initial selector; connected-trigger focus checked for actual success, then temporary-tabindex heading/main fallback | Caller initial focus; connected-trigger/fallback restoration, without the same verified disabled/unfocusable-target fallback contract |
|
||||
| Lifetime/body state | Per-overlay state, single-active guard, previous inert/body-lock restoration, detached-node observer | App-owned body-overflow restoration and native close lifecycle |
|
||||
| Domain state | Existing typed Confirm=false, Prompt=null/custom cancellation and DialogService resolution | Driver draft, revision guards and registry busy bridge remain local |
|
||||
| Actual acceptance | `87c882ec` plus final `d370dbd3`: native focus/cleanup regressions, full1597 tests, final actual-component integration/preferences | `RegistryWorkflowsTests.Driver_catalog_filters_and_modal_preserve_drafts_focus_and_revision_guards`: actual `:modal`, Name focus, Escape/return, stale revision/draft recovery, safe fixture save/390px bounds; registry11 tests and13 width/zoom cases |
|
||||
|
||||
The registry author independently reviewed this comparison against current source and recorded runtime evidence. Do not describe all four implementations as interchangeable native lifecycle adapters. Shared requirements are naming, safe initial focus, managed background interaction, cancellation, cleanup, honest busy/outcome behavior and preserved domain state; presentation and focus-restoration implementations currently differ.
|
||||
|
||||
## Decision
|
||||
|
||||
The common **behavior recipe** is stable; the tested **public component ownership** differs. MX takes caller-owned title/description IDs, sizing classes and complete child chrome. OEE generates a title ID, owns the initial-focus heading/body/disabled fieldset, and separates its footer. The second pilot exposed an important caller requirement: native modal busy state alone does not freeze editable data or protect post-await writes. Those submissions now use detached snapshots and real authorization checks in their own domain code. Secrets also requires target-specific reveal/mutation isolation rather than a generic editor contract.
|
||||
|
||||
Retain these tested local adapters and the existing Theme recipe. Extracting only the apparently similar markup now would either discard these tested contracts or add options before another caller has established their required combinations. Keep the shared package free of domain state/services. A later extraction must be a separate reviewed change/release with two-host lifecycle and busy-submission tests before caller migration; it is not silently bundled into this visual rollout. Existing local adapters remain covered by their project tests and browser fixtures.
|
||||
|
||||
This closes G2's two-consumer interaction and explicit extraction-decision requirement. It does not close G3, remaining project tasks, or deployment acceptance. Filter/table conventions are also exercised in the completed Overview and ScadaBridge batches; their data/DTO ownership remains local and is not replaced by speculative shared filtering state.
|
||||
Reference in New Issue
Block a user