dohertj2/scadaproj
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(secrets): route the unset-token harness through the real hub composition (review drift-risk)

Browse Source 
An internal validateEagerly seam on AddZbSecretsGrpcHub replaces the harness's
hand-copied registration fragment, so the deny-all second-layer tests exercise
the production wiring and cannot drift from it.

Claude-Session: https://claude.ai/code/session_014WNM4vjoVksyyBraTXSZE1
This commit is contained in:
Joseph Doherty
2026-08-07 06:52:26 -04:00
parent 3e3748b985
commit 5f81e65684
2 changed files with 36 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ZB.MOM.WW.Secrets/src/ZB.MOM.WW.Secrets.Replicator.Grpc/DependencyInjection/SecretsGrpcHubServerExtensions.cs
+21 -5
View File
@@ -43,7 +43,20 @@ public static class SecretsGrpcHubServerExtensions
public static IServiceCollection AddZbSecretsGrpcHub(
this IServiceCollection services,
IConfiguration configuration,
string sectionPath = "Secrets:GrpcHub")
string sectionPath = "Secrets:GrpcHub") =>
AddZbSecretsGrpcHubCore(services, configuration, sectionPath, validateEagerly: true);
/// <summary>
/// The whole composition, with the eager validation optionally skipped. Internal so the test
/// harness can exercise the interceptor's deny-all second layer over the wire through the REAL
/// registration path — a hand-copied fragment of this method in the harness would silently
/// drift when this method changes. Production callers always validate eagerly.
/// </summary>
internal static IServiceCollection AddZbSecretsGrpcHubCore(
IServiceCollection services,
IConfiguration configuration,
string sectionPath,
bool validateEagerly)
{
ArgumentNullException.ThrowIfNull(services);
ArgumentNullException.ThrowIfNull(configuration);
@@ -74,10 +87,13 @@ public static class SecretsGrpcHubServerExtensions
// startup failure and the runtime warning both name the key this host actually reads.
services.PostConfigure<SecretsGrpcHubServerOptions>(options => options.SectionPath = sectionPath);
var eager = new SecretsGrpcHubServerOptions { SectionPath = sectionPath };
section.Bind(eager);
eager.SectionPath = sectionPath;
eager.Validate();
if (validateEagerly)
{
var eager = new SecretsGrpcHubServerOptions { SectionPath = sectionPath };
section.Bind(eager);
eager.SectionPath = sectionPath;
eager.Validate();
}
// Singleton so the "unconfigured" warning is emitted once per process rather than once per
// interceptor instance; the gRPC interceptor activator prefers a registered instance.