Fix all baseline code-review findings across the six shared libraries
Resolves the 35 findings from the 2026-06-01 baseline (commit 26ba1c7),
test-first for every behavioral change. +51 tests (331 -> 382 passing, 0 failed).
- Telemetry-001 (HIGH): RedactionEnricher now honours property removal, so a
redactor that drops a key actually scrubs the secret from the event.
- Auth: LDAP validator ValidateOnStart; API-key verify no longer fails on a
best-effort MarkUsed write or a corrupt scopes column (fail-closed); LDAP cert
validation hook; KeyPrefix persistence aligned; README algorithm corrected.
- Health: Akka checks return Degraded (not throw) when the cluster isn't up yet;
GrpcDependencyHealthCheck catch-all; null 'description' rendered; composite
endpoint builder; XML docs shipped.
- Audit: CompositeAuditWriter no longer re-throws OperationCanceledException;
TruncatingAuditRedactor over-redact scrubs Target + safe negative max; options
record; XML docs shipped.
- Configuration: TryAddEnumerable idempotent registration; consistent port
quoting; strict invariant port parsing; XML docs + README packaged.
- Theme: mobile toggle is now CSS-only (no Bootstrap JS); token/CSS hygiene;
XML docs on the public parameter surface.
Shared-contract/spec docs updated where the code was the source of truth
(observability service.instance.id, MapZbMetrics, redactor reach). All changes
additive/back-compatible at v0.1.0. code-reviews bookkeeping follows separately.
This commit is contained in:
@@ -13,6 +13,28 @@ public class NavRailTests : TestContext
|
||||
Assert.Contains("Clusters", a.TextContent);
|
||||
}
|
||||
|
||||
// Theme-004: when Icon is supplied it is wrapped in a .rail-ico span (now styled).
|
||||
[Fact]
|
||||
public void NavRailItem_wraps_icon_in_rail_ico_span_when_supplied()
|
||||
{
|
||||
var cut = RenderComponent<NavRailItem>(p => p
|
||||
.Add(x => x.Href, "/clusters")
|
||||
.Add(x => x.Text, "Clusters")
|
||||
.Add(x => x.Icon, (RenderFragment)(b => b.AddMarkupContent(0, "<svg class='ico'/>"))));
|
||||
var ico = cut.Find("a.rail-link .rail-ico");
|
||||
Assert.NotNull(ico);
|
||||
Assert.NotNull(cut.Find("a.rail-link .rail-ico .ico"));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void NavRailItem_omits_rail_ico_span_when_no_icon()
|
||||
{
|
||||
var cut = RenderComponent<NavRailItem>(p => p
|
||||
.Add(x => x.Href, "/clusters")
|
||||
.Add(x => x.Text, "Clusters"));
|
||||
Assert.Empty(cut.FindAll(".rail-ico"));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void NavRailSection_renders_title_and_children_open_by_default()
|
||||
{
|
||||
|
||||
@@ -1,4 +1,6 @@
|
||||
using System.IO;
|
||||
using System.Linq;
|
||||
using System.Text.RegularExpressions;
|
||||
|
||||
namespace ZB.MOM.WW.Theme.Tests;
|
||||
|
||||
@@ -32,4 +34,36 @@ public class StaticAssetsTests
|
||||
[InlineData("ibm-plex-mono-500.woff2")]
|
||||
public void Fonts_are_vendored(string file) =>
|
||||
Assert.True(File.Exists(Path.Combine(Wwwroot, "fonts", file)));
|
||||
|
||||
// Theme-002: .chip-idle pairs the idle background with the matching --idle
|
||||
// foreground token (per DESIGN-TOKENS.md), not --ink-soft.
|
||||
[Fact]
|
||||
public void ChipIdle_pairs_idle_foreground_with_idle_background()
|
||||
{
|
||||
var css = File.ReadAllText(Path.Combine(Wwwroot, "css", "theme.css"));
|
||||
var rule = Regex.Match(css, @"\.chip-idle\s*\{[^}]*\}").Value;
|
||||
Assert.Contains("color: var(--idle)", rule);
|
||||
Assert.Contains("background: var(--idle-bg)", rule);
|
||||
Assert.DoesNotContain("--ink-soft", rule);
|
||||
}
|
||||
|
||||
// Theme-003: no hardcoded hex colours appear outside the :root token block in
|
||||
// either stylesheet — every shade is a named token.
|
||||
[Theory]
|
||||
[InlineData("theme.css")]
|
||||
[InlineData("layout.css")]
|
||||
public void No_hardcoded_hex_outside_root_token_block(string file)
|
||||
{
|
||||
var css = File.ReadAllText(Path.Combine(Wwwroot, "css", file));
|
||||
|
||||
// Strip the :root { ... } declaration block(s) — the one place hex literals live.
|
||||
var withoutRoot = Regex.Replace(css, @":root\s*\{[^}]*\}", string.Empty);
|
||||
|
||||
var hexLiterals = Regex.Matches(withoutRoot, @"#[0-9a-fA-F]{3,8}\b")
|
||||
.Select(m => m.Value)
|
||||
.ToList();
|
||||
|
||||
Assert.True(hexLiterals.Count == 0,
|
||||
$"{file} has hardcoded hex outside :root: {string.Join(", ", hexLiterals)}");
|
||||
}
|
||||
}
|
||||
|
||||
@@ -40,4 +40,26 @@ public class ThemeShellTests : TestContext
|
||||
.Add(x => x.RailFooter, (RenderFragment)(b => b.AddMarkupContent(0, "<span class='sess'>S</span>"))));
|
||||
Assert.NotNull(cut.Find(".rail-foot .sess"));
|
||||
}
|
||||
|
||||
// Theme-001: the mobile hamburger must work without Bootstrap collapse JS.
|
||||
// The shell is a native <details> disclosure whose <summary> is the toggle —
|
||||
// no data-bs-toggle / data-bs-target attributes, so no Bootstrap JS dependency.
|
||||
[Fact]
|
||||
public void Mobile_toggle_is_a_css_only_details_disclosure_not_bootstrap_collapse()
|
||||
{
|
||||
var cut = RenderComponent<ThemeShell>(p => p.Add(x => x.Product, "OtOpcUa"));
|
||||
|
||||
// Root is a <details> whose direct <summary> is the hamburger toggle.
|
||||
var shell = cut.Find("details.app-shell");
|
||||
var summary = cut.Find("details.app-shell > summary.rail-toggle");
|
||||
Assert.NotNull(summary);
|
||||
|
||||
// The rail is plain markup inside the <details> — no Bootstrap .collapse class.
|
||||
var rail = cut.Find("#theme-rail");
|
||||
Assert.DoesNotContain("collapse", rail.ClassList);
|
||||
|
||||
// No Bootstrap collapse JS hooks anywhere in the shell markup.
|
||||
Assert.DoesNotContain("data-bs-toggle", shell.OuterHtml);
|
||||
Assert.DoesNotContain("data-bs-target", shell.OuterHtml);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user