docs(code-reviews): review Secrets, LocalDb, GalaxyRepository, Overview; re-review changed libs (scadaproj#15)

First reviews of Secrets, LocalDb, GalaxyRepository and Overview, and
2026-11-09 re-reviews of Auth, Health, Theme, Telemetry, Audit and
Configuration, all at 91fb2b4. 49 new open findings, each with a P1/P2/P3
priority and a failure scenario: 1 P1, 13 P2, 35 P3. README regenerated;
REVIEW-PROCESS, template and regen script now cover all ten libraries and
the Priority field.

Claude-Session: https://claude.ai/code/session_01GT67AEHd2Acv1YPwGfXEoV
This commit is contained in:
Joseph Doherty
2026-11-09 14:33:14 -05:00
parent 91fb2b48dd
commit 477245f5db
14 changed files with 2602 additions and 52 deletions
+7 -1
View File
@@ -4,7 +4,8 @@
Template for a shared-library review. Copy the structure below into
code-reviews/<Library>/findings.md and fill it in.
<Library> is the ZB.MOM.WW.* library with the prefix stripped (Auth, Theme,
Health, Telemetry, Configuration, Audit). See ../REVIEW-PROCESS.md for the
Health, Telemetry, Configuration, Audit, Secrets, LocalDb, GalaxyRepository,
Overview). See ../REVIEW-PROCESS.md for the
full process and the library → component-spec mapping.
-->
@@ -52,6 +53,7 @@ Confirm every category was examined. Record "No issues found" where applicable.
| | |
|--|--|
| Severity | Critical \| High \| Medium \| Low |
| Priority | P1 \| P2 \| P3 |
| Category | <one of the 10 checklist categories> |
| Status | Open \| In Progress \| Resolved \| Won't Fix \| Deferred |
| Location | `ZB.MOM.WW.<Library>/src/<Package>/<File>.cs:<line>` |
@@ -60,6 +62,10 @@ Confirm every category was examined. Record "No issues found" where applicable.
What is wrong and why it matters.
**Failure scenario**
Concrete inputs/sequence and the wrong outcome.
**Recommendation**
Concrete suggested fix.