feat(secrets-ui): add metadata filtering and private reveal outcomes
This commit is contained in:
@@ -0,0 +1,225 @@
|
||||
"""Bounded synthetic Secrets UI checks, including native Chromium 200% zoom.
|
||||
|
||||
Only the two disposable fixture origins are accepted. No production store or credentials.
|
||||
"""
|
||||
import argparse
|
||||
import json
|
||||
import re
|
||||
import sys
|
||||
from pathlib import Path
|
||||
from urllib.parse import urlsplit
|
||||
from playwright.sync_api import sync_playwright, expect
|
||||
|
||||
ROOT = Path(__file__).resolve().parents[4]
|
||||
sys.path.insert(0, str(ROOT / "components/ui-theme/validation/theme-1.0.0/canary"))
|
||||
from browser_zoom import zoom_browser, set_browser_zoom
|
||||
|
||||
parser = argparse.ArgumentParser()
|
||||
parser.add_argument("--perpage", required=True)
|
||||
parser.add_argument("--bootstrap", required=True)
|
||||
parser.add_argument("--expected-theme", required=True)
|
||||
parser.add_argument("--out", required=True, type=Path)
|
||||
args = parser.parse_args()
|
||||
args.out.mkdir(parents=True, exist_ok=True)
|
||||
results = {"cases": [], "checks": [], "pageErrors": [], "theme": args.expected_theme}
|
||||
LONG_NAME = "app/" + "x" * 400
|
||||
LONG_VALUE = "s" * 800
|
||||
|
||||
|
||||
def check(name, value, detail=None):
|
||||
item = {"name": name, "pass": bool(value)}
|
||||
if detail is not None:
|
||||
item["detail"] = detail
|
||||
results["checks"].append(item)
|
||||
return bool(value)
|
||||
|
||||
|
||||
def counts(page, origin):
|
||||
return page.request.get(origin + "/fixture/counts").json()
|
||||
|
||||
|
||||
def faults(page, origin, **data):
|
||||
response = page.request.post(origin + "/fixture/faults", data=data)
|
||||
assert response.status == 204, response.status
|
||||
|
||||
|
||||
def ready(page, origin):
|
||||
page.goto(origin + "/admin/secrets")
|
||||
expect(page.locator("[data-fixture-ready=true]")).to_be_visible()
|
||||
page.evaluate("document.fonts.ready")
|
||||
|
||||
|
||||
def focused(page, selector):
|
||||
page.wait_for_function("s => document.activeElement === document.querySelector(s)", arg=selector)
|
||||
|
||||
|
||||
def state(page):
|
||||
return page.evaluate("""() => {
|
||||
const table=document.querySelector('.table-wrap');
|
||||
const row=document.querySelector('th[scope=row]');
|
||||
const r=row&&getComputedStyle(row);
|
||||
const technical=document.querySelector('details[open] .zb-secret-tech-scroll');
|
||||
const region=document.querySelector('[data-testid=revealed-value]')?.parentElement;
|
||||
const active=document.activeElement;
|
||||
const pair=selector=>{const e=document.querySelector(selector);if(!e)return null;
|
||||
let n=e,bg;while(n){const c=getComputedStyle(n).backgroundColor;if(c!=='rgba(0, 0, 0, 0)'&&c!=='transparent'){bg=c;break;}n=n.parentElement;}
|
||||
return {color:getComputedStyle(e).color,background:bg||'rgb(255, 255, 255)'};};
|
||||
return {url:location.href,innerWidth,innerHeight,scrollY,DPR:devicePixelRatio,scrollWidth:document.documentElement.scrollWidth,
|
||||
font:getComputedStyle(document.body).fontFamily,fontLoaded:document.fonts.check('14px "IBM Plex Sans"')&&[...document.fonts].some(f=>f.family.includes('IBM Plex Sans')&&f.status==='loaded'),
|
||||
table:{client:table.clientWidth,scroll:table.scrollWidth},
|
||||
rowHeader:row?{text:row.textContent.trim(),transform:r.textTransform,position:r.position,color:r.color,fontSize:r.fontSize}:null,
|
||||
technical:technical?{client:technical.clientWidth,scroll:technical.scrollWidth,height:technical.clientHeight,scrollHeight:technical.scrollHeight}:null,
|
||||
value:region?{client:region.clientWidth,scroll:region.scrollWidth,height:region.clientHeight,scrollHeight:region.scrollHeight}:null,
|
||||
colors:{filter:pair('[data-testid=secret-filter]'),label:pair('label[for]'),count:pair('[data-testid=filter-count]'),summary:pair('summary'),status:pair('[data-testid=reveal-status]'),error:pair('[data-testid=reveal-error]'),value:pair('[data-testid=revealed-value]')},
|
||||
focus:{id:active.id,outline:getComputedStyle(active).outline,visible:active.matches(':focus-visible')},
|
||||
reduced:matchMedia('(prefers-reduced-motion:reduce)').matches};
|
||||
}""")
|
||||
|
||||
|
||||
def contrast(pair):
|
||||
if not pair:
|
||||
return None
|
||||
def luminance(value):
|
||||
channels = [int(x) / 255 for x in re.findall(r"\d+", value)[:3]]
|
||||
channels = [c / 12.92 if c <= .04045 else ((c + .055) / 1.055) ** 2.4 for c in channels]
|
||||
return sum(c * w for c, w in zip(channels, [.2126, .7152, .0722]))
|
||||
a, b = sorted([luminance(pair["color"]), luminance(pair["background"])])
|
||||
return round((b + .05) / (a + .05), 3)
|
||||
|
||||
|
||||
with sync_playwright() as playwright:
|
||||
with zoom_browser(playwright) as (context, worker):
|
||||
page = context.pages[0]
|
||||
session = context.new_cdp_session(page)
|
||||
results["browser"] = session.send("Browser.getVersion")["product"]
|
||||
session.detach()
|
||||
page.set_default_timeout(7000)
|
||||
page.on("pageerror", lambda error: results["pageErrors"].append(str(error)))
|
||||
page.emulate_media(reduced_motion="reduce")
|
||||
for mode, origin in [("perpage", args.perpage), ("bootstrap", args.bootstrap)]:
|
||||
parsed = urlsplit(origin)
|
||||
assert parsed.hostname in {"127.0.0.1", "localhost", "::1"} and not parsed.path.strip("/"), origin
|
||||
provenance = page.request.get(origin + "/fixture/provenance").json()
|
||||
assert provenance["purpose"].startswith("Loopback synthetic Secrets UI"), provenance
|
||||
assert provenance["theme"] == args.expected_theme, provenance
|
||||
results.setdefault("hosts", []).append({"mode": mode, "origin": origin, "provenance": provenance})
|
||||
try:
|
||||
faults(page, origin)
|
||||
page.set_viewport_size({"width": 1440, "height": 1000})
|
||||
ready(page, origin)
|
||||
set_browser_zoom(worker, page, 1)
|
||||
initial = counts(page, origin)
|
||||
search = page.get_by_test_id("secret-filter")
|
||||
search.fill(" APP/ALPHA ")
|
||||
expect(page.locator("tr[data-secret-row]")).to_have_count(1)
|
||||
check(mode + " name-only case-insensitive filter", page.locator("tr[data-secret-row]").get_attribute("data-secret-row") == "app/alpha")
|
||||
search.fill("Illustrative local metadata")
|
||||
expect(page.get_by_test_id("filter-empty")).to_be_visible()
|
||||
check(mode + " no-match distinct from empty", "No names match" in page.get_by_test_id("filter-empty").inner_text())
|
||||
page.get_by_test_id("clear-secret-filter").click()
|
||||
expect(page.locator("tr[data-secret-row]")).to_have_count(3)
|
||||
focused(page, "[data-testid=secret-filter]")
|
||||
filtered = counts(page, origin)
|
||||
check(mode + " filter/clear does not read values or reload", initial["gets"] == filtered["gets"] and initial["lists"] == filtered["lists"])
|
||||
row = page.locator(f"tr[data-secret-row='{LONG_NAME}']")
|
||||
check(mode + " contextual row actions", all(row.get_by_role("button", name=f"{action} {LONG_NAME}", exact=True).count() == 1 for action in ["Reveal", "Rotate", "Delete"]))
|
||||
|
||||
# A real slow request must not steal focus claimed by another control.
|
||||
faults(page, origin, readDelayMs=700)
|
||||
reveal = row.get_by_test_id("reveal-button")
|
||||
identity = reveal.get_attribute("id")
|
||||
reveal.focus(); page.keyboard.press("Enter")
|
||||
expect(reveal).to_have_attribute("aria-busy", "true")
|
||||
check(mode + " slow reveal is disabled and explained", reveal.is_disabled() and "Revealing" in reveal.inner_text())
|
||||
search.focus()
|
||||
expect(row.get_by_test_id("revealed-value")).to_have_text(LONG_VALUE)
|
||||
focused(page, "[data-testid=secret-filter]")
|
||||
check(mode + " completion preserves focus claimed elsewhere", True)
|
||||
check(mode + " stable Reveal/Hide control", row.get_by_test_id("hide-button").get_attribute("id") == identity)
|
||||
check(mode + " plaintext absent from live status/labels/URL/audit", all(LONG_VALUE not in text for text in page.locator('[aria-live],[role=status]').all_text_contents()) and LONG_VALUE not in json.dumps(counts(page, origin)["audits"]) and LONG_VALUE not in page.url and LONG_VALUE not in row.get_by_test_id("hide-button").get_attribute("aria-label"))
|
||||
row.get_by_test_id("reveal-panel").screenshot(path=str(args.out / f"{mode}-revealed-payload.png"))
|
||||
row.get_by_test_id("hide-button").focus(); page.keyboard.press("Enter")
|
||||
expect(page.get_by_test_id("revealed-value")).to_have_count(0)
|
||||
focused(page, "#" + identity)
|
||||
check(mode + " keyboard Hide clears plaintext", LONG_VALUE not in page.content())
|
||||
|
||||
# Audit failure remains fail-closed and gives a non-sensitive outcome.
|
||||
faults(page, origin, audit=True)
|
||||
row.get_by_test_id("reveal-button").click()
|
||||
expect(row.get_by_test_id("reveal-error")).to_be_visible()
|
||||
check(mode + " failed audit withholds value", page.get_by_test_id("revealed-value").count() == 0 and LONG_VALUE not in page.content())
|
||||
check(mode + " failed reveal remains discoverable", "Reveal failed" in row.get_by_test_id("reveal-status").inner_text())
|
||||
focused(page, "#" + identity)
|
||||
error_state = state(page)
|
||||
check(mode + " error contrast", contrast(error_state["colors"]["error"]) >= 4.5, error_state["colors"]["error"])
|
||||
row.get_by_test_id("hide-button").click()
|
||||
|
||||
# Removing a pending row cancels that read; another row cannot inherit its value.
|
||||
faults(page, origin, readDelayMs=700)
|
||||
before = counts(page, origin)
|
||||
row.get_by_test_id("reveal-button").click()
|
||||
expect(row.get_by_test_id("reveal-button")).to_have_attribute("aria-busy", "true")
|
||||
search.fill("app/bravo")
|
||||
expect(page.locator("tr[data-secret-row]")).to_have_count(1)
|
||||
check(mode + " filtered-out pending row does not disclose", page.get_by_test_id("revealed-value").count() == 0)
|
||||
page.get_by_test_id("reveal-button").click()
|
||||
expect(page.get_by_test_id("revealed-value")).to_have_text("synthetic-fixture-value")
|
||||
after = counts(page, origin)
|
||||
check(mode + " only current row has success audit", len(after["audits"]) == len(before["audits"]) + 1 and after["audits"][-1]["target"] == "app/bravo")
|
||||
page.get_by_test_id("hide-button").click()
|
||||
page.get_by_test_id("clear-secret-filter").click()
|
||||
faults(page, origin)
|
||||
|
||||
# One bounded desktop/mobile/real-zoom inspection round.
|
||||
for label, width, height, zoom in [("desktop", 1440, 1000, 1), ("mobile", 390, 844, 1), ("zoom200", 1440, 900, 2)]:
|
||||
page.set_viewport_size({"width": width, "height": height})
|
||||
ready(page, origin)
|
||||
assert set_browser_zoom(worker, page, zoom) == zoom
|
||||
row = page.locator(f"tr[data-secret-row='{LONG_NAME}']")
|
||||
if label != "desktop":
|
||||
row.locator("summary").focus(); page.keyboard.press("Enter")
|
||||
expect(row.locator("details")).to_have_attribute("open", "")
|
||||
if label == "zoom200":
|
||||
row.get_by_test_id("reveal-button").click()
|
||||
expect(row.get_by_test_id("revealed-value")).to_have_text(LONG_VALUE)
|
||||
if zoom == 2:
|
||||
page.evaluate("window.scrollTo(0,0)") # Native zoom viewport capture; avoid scrolled-viewport raster cropping.
|
||||
data = state(page)
|
||||
check(mode + " " + label + " bounded document", data["scrollWidth"] <= data["innerWidth"], data)
|
||||
check(mode + " " + label + " row headers retain data presentation", data["rowHeader"]["transform"] == "none" and data["rowHeader"]["position"] == "static", data["rowHeader"])
|
||||
check(mode + " " + label + " self-hosted font and reduced-motion preference", data["fontLoaded"] and data["reduced"])
|
||||
if data["technical"]:
|
||||
check(mode + " " + label + " long technical values locally contained", data["technical"]["scroll"] <= data["technical"]["client"] + 1 and data["technical"]["height"] <= 256, data["technical"])
|
||||
if data["value"]:
|
||||
check(mode + " " + label + " long plaintext locally contained", data["value"]["scroll"] <= data["value"]["client"] + 1 and data["value"]["height"] <= 256, data["value"])
|
||||
if zoom == 2:
|
||||
check(mode + " native200% layout/DPR", data["innerWidth"] == 720 and data["DPR"] == 2, data)
|
||||
for name, pair in data["colors"].items():
|
||||
if pair:
|
||||
data["colors"][name]["contrast"] = contrast(pair)
|
||||
check(mode + " " + label + " " + name + " readable", contrast(pair) >= 4.5, pair)
|
||||
page.screenshot(path=str(args.out / f"{mode}-{label}.png"), full_page=False)
|
||||
results["cases"].append({"mode": mode, "case": label, **data})
|
||||
if label == "mobile":
|
||||
region = page.get_by_role("region", name="Secret metadata", exact=True)
|
||||
region.evaluate("n=>n.scrollLeft=0")
|
||||
region.focus(); page.keyboard.press("ArrowRight")
|
||||
page.wait_for_function("()=>document.querySelector('.table-wrap').scrollLeft>0")
|
||||
check(mode + " keyboard table scrolling", region.evaluate("n=>n.scrollLeft") > 0)
|
||||
if zoom == 2:
|
||||
row.get_by_test_id("hide-button").click()
|
||||
set_browser_zoom(worker, page, 1)
|
||||
page.set_viewport_size({"width": 1440, "height": 900})
|
||||
page.goto(origin + "/admin/secrets?role=manage")
|
||||
expect(page.locator("[data-fixture-ready=true]")).to_be_visible()
|
||||
check(mode + " manage does not imply reveal", page.get_by_test_id("reveal-button").count() == 0)
|
||||
check(mode + " denied route", page.request.get(origin + "/admin/secrets?role=denied").status == 403)
|
||||
except Exception as error:
|
||||
check(mode + " matrix completed", False, str(error))
|
||||
finally:
|
||||
faults(page, origin)
|
||||
check("No page errors", not results["pageErrors"], results["pageErrors"])
|
||||
(args.out / "results.json").write_text(json.dumps(results, indent=2) + "\n")
|
||||
summary = {"checks": len(results["checks"]), "failed": [x["name"] for x in results["checks"] if not x["pass"]], "screenshots": len(results["cases"]), "browser": results.get("browser")}
|
||||
print(json.dumps(summary))
|
||||
raise SystemExit(1 if summary["failed"] else 0)
|
||||
Reference in New Issue
Block a user