Record OEE convergence and dialog identity acceptance

This commit is contained in:
Joseph Doherty
2026-11-13 21:26:35 -05:00
parent 117398cfd9
commit 33993296b3
4 changed files with 43 additions and 12 deletions
@@ -109,3 +109,11 @@ ScadaBridge final d370dbd3 passes1597 tests, exact delivered shared package/runt
HistorianGateway92c9ae02 completes HG01–07:1467main+191client+206ownedclient passed,76unchanged external skips,0fail;35functional+36visual+13native-invalid cases. Native numeric/date drafts retain raw text and reject invalid/partial input before captured intent/dispatch. Existing Core/backends retained, exact shared UI1.0.1/Abs0.6.6/Theme1.0.1 delivered bytes verified.
MXAccess26a90883 completes MX01–08:1460passed/6existingplatform skips, actual MainLayout17cases+12active-title destinations, official3DLL/7asset parity, min semantic text contrast5.555. Independent review corrected focus-await tree identity/lifetime (2framework regressions) and native fault-detail DOM state transfer (actual compact/table red→green under prepend/reorder). No backend/protocol/policy changes. Owned MX canary stopped; no deployment. Root now assists disjoint OT13 protocol fields after OT01 pattern freeze; agent continues other OT tasks, another owns BTDB, OEE native final acceptance is under review. G3 remains open.
## OEE convergence and identity followup
OEE chapter is complete through c155798e, including exact official Secrets UI1.0.1/Abs0.6.6 adoption with Core0.6.2 preserved,1705UI/211Host/105security passes and actual packaged Secrets1440/390/real200% checks. Native diagnostic target followup28ff7c91 is separately bounded to six actual cases,25targeted tests and31schemas; it does not claim a fresh full5999offline rerun. Native final proof/limits in OEE-chapter-exit.md remain authoritative. Only a newly created Designer Launcher card remains for manual cleanup on the locked Mac; owned runtime resources are stopped.
ScadaBridge6489c9fc closes an independently reproduced identity gap: old custom contexts and late activation rejections cannot complete a replacement presentation. Three actual regression failures retained before the fix;3focused/full1600passed after. No public API/domain change.
OT01–03 accepted169149f1 with bounded pilot proof; Monaco naming8cc053ce follows. OT04–06 and OT13 continue. All35default protocol field surfaces now render with names/unique IDs/resolved descriptions;12driver numeric parser checks preserve emitted config. Conditional-field and full root acceptance still pending. G3 remains open.
@@ -270,3 +270,9 @@ Keep `_model.ToFilter` semantics for other callers; the bar renders linked error
**G2 consumer candidate:** all focused/full tests pass, package pin/digest recorded, all page families sampled after label scan, two schemes verified, overlay pilot documented for BTDB. No deployment is part of this plan-writing request. A later authorized deployment stages Theme package availability first, a disposable fixture, then one consumer instance/environment with normal deployment policy; never redeploy the SCADA fleet merely to inspect CSS.
**Rollback:** retain prior Theme pin and last known application artifact; revert local presentation/behavior commits together with dependent package pin if compatibility fails. Preserve data/schema, existing auth and audit semantics; this chapter introduces no migration. Dirty browser sessions must finish/cancel safely before app restart. If a new preference key was migrated, keep reading the old key during rollback rather than deleting user settings. Reproduce failure on fixture and record the gate before retrying rollout.
## Execution clarification: custom dialog completion identity
Cross-family typed-dialog review found the existing ShowAsync body context captured an unscoped global resolver. A canceled context could later complete a newer dialog. Add a narrow DialogService.cs captured-TCS identity guard and service-level regression in Shared/DialogContextIdentityTests.cs, preserving existing public APIs, typed outcomes and single-active behavior. No backend operation/data contract changes. This completes SB01's correct-presentation lifecycle rather than certifying stale custom callbacks through DOM-only generation guards.
The corresponding DialogHost presentation guard must also bind rendered handlers and late activation rejection to the captured DialogState. Reproduce a delayed rejected activation for dialog A after prompt B opens; B must remain active with its draft intact. Include Shared/DialogHostPresentationIdentityTests.cs and retain disposal cancellation of the current presentation.
@@ -578,3 +578,16 @@ No runtime timestamps or status values in a mockup are deployment evidence. Keep
5. Compare final deployed/source commit IDs and rerun the documented read-only smoke paths after any authorized rollout/rollback. Keep live limitations visible in the release record.
**Done:** all ten findings have evidence-backed implementation/validation paths; shared visual tokens remain canonical while the router, independent registry and operator runtime retain their proper behavior and platform boundaries.
### OEE-04 execution clarification: native typography delivery
The isolated8.3.7renderer proved the gap: canonical font URLs returned404 and actual KPI glyphs used SF NS despite CSS fontFamily mentioning Plex. Add `deploy/scripts/build-perspective-theme-assets.py`, its integrity tests, generated `deploy/perspective/technical-light/1.0.1` font/theme resources, and additive project `com.inductiveautomation.perspective/session-props/{props.json,resource.json}`. Generate exact three exported woff2bytes after canonical manifest/payload verification; extend native light through a separate `oee-technical-light` theme, with only the existing native font/interaction variables mapped to canonical tokens. No Blazor stylesheet, named style-class format, process-state palette, event/binding, auth or operational configuration is copied/changed.
Use the [official8.3 native theme/font mechanism](https://docs.inductiveautomation.com/docs/8.3/ignition-modules/perspective/styles/creating-and-using-custom-perspective-themes), corroborated by exact installed8.3.7 FontConfig, ThemeConfig and SessionPropsConfig metadata/serializer inspection. The session default selects only this additive native light theme. First validate deterministic bytes, missing/tampered assets and source boundary; then verify actual HTTP font bytes and CDP platform glyph usage on the isolated gateway. Preserve original resources on collision; no existing gateway rollout is authorized. Native runtime rendering/compiled-resource acceptance substitutes for Designer UI control after the documented Java-process CUA binding failure; the tool limitation remains explicit. Parent accepted this bounded clarification during execution.
### OEE-10 execution clarification: two read-only diagnostic disclosure targets
Final chapter-exit inventory found two additional controls covered by the original recommendation's diagnostic-density wording: `projects/OEE_Site/com.inductiveautomation.perspective/views/ProcessPanels/HeidenhainCnc/view.json` and `.../MTConnectCnc/view.json`, component `ToggleDiagnostics`. Extend this batch to change only its `props.style.minHeight` from36px to44px in each file. Preserve every other source byte, especially events, params, bindings, domain palette and local diagnosticsExpanded behavior. Add no touch parameters, process writes or PLC/provider action. Before edits capture source hashes; verify exact byte replacement/normalized structural equality, run existing relevant diagnostics/schema tests, then use a fresh owned isolated native8.3.7 fixture to measure44px and exercise tap/keyboard Show/Hide diagnostics. Keep this fixture/evidence distinct from the already accepted and cleaned native fixture. No production deployment is authorized. Cleanup only the new fixture resources/private files after proof.
The two views share `deploy/scripts/gen_mtconnect_panel.py:147`'s ToggleDiagnostics style builder (Heidenhain imports it). Keep its single minHeight literal in sync as part of this clarification; otherwise the existing generated-file-current test fails and regeneration reverts the fix. Do not invoke broad write_resources: it writes unrelated views/UDTs. Guard the one generator literal and exactly two view literals as byte-only changes; no other generated resource is in scope.
@@ -481,7 +481,7 @@
"GB"
],
"dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task.",
"evidence": "ScadaBridge commit87c882ec; docs/ui-consistency/ScadaBridge-verification.md"
"evidence": "ScadaBridge commit87c882ec; docs/ui-consistency/ScadaBridge-verification.md;6489c9fc stale custom-context and late activation identity regressions red\u2192green, full1600/1600; docs/ui-validation/dialog-identity/README.md."
},
{
"id": "SB-02",
@@ -656,40 +656,43 @@
"title": "Adopt shared API and label the first driver/filter surfaces",
"chapter": "OtOpcUa.md",
"line": 39,
"status": "in_progress",
"status": "completed",
"prerequisiteGates": [
"GB"
],
"dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task."
"dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task.",
"evidence": "OtOpcUa169149f1; docs/ui-consistency/ot01-modal-field-pilot (bounded original pilot); Monaco followup8cc053ce; root protocol fields remain OT13."
},
{
"id": "OT-02",
"title": "Pilot accessible modal lifecycle on confirmations",
"chapter": "OtOpcUa.md",
"line": 67,
"status": "in_progress",
"status": "completed",
"prerequisiteGates": [
"GB"
],
"dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task."
"dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task.",
"evidence": "OtOpcUa169149f1; docs/ui-consistency/ot01-modal-field-pilot (bounded original pilot); Monaco followup8cc053ce; root protocol fields remain OT13."
},
{
"id": "OT-03",
"title": "Name tree controls without sacrificing virtualization",
"chapter": "OtOpcUa.md",
"line": 101,
"status": "in_progress",
"status": "completed",
"prerequisiteGates": [
"GB"
],
"dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task."
"dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task.",
"evidence": "OtOpcUa169149f1; docs/ui-consistency/ot01-modal-field-pilot (bounded original pilot); Monaco followup8cc053ce; root protocol fields remain OT13."
},
{
"id": "OT-04",
"title": "Replace placeholder home with role-appropriate task orientation",
"chapter": "OtOpcUa.md",
"line": 133,
"status": "planned",
"status": "in_progress",
"prerequisiteGates": [
"GB"
],
@@ -700,7 +703,7 @@
"title": "Group navigation and retire ordinary Namespace links",
"chapter": "OtOpcUa.md",
"line": 145,
"status": "planned",
"status": "in_progress",
"prerequisiteGates": [
"GB"
],
@@ -711,7 +714,7 @@
"title": "Standardize page/table grammar across routes",
"chapter": "OtOpcUa.md",
"line": 173,
"status": "planned",
"status": "in_progress",
"prerequisiteGates": [
"GB"
],
@@ -1218,11 +1221,12 @@
"title": "Keep eligibility and verification semantics distinct from health",
"chapter": "ignitionoee.md",
"line": 433,
"status": "in_progress",
"status": "completed",
"prerequisiteGates": [
"GB"
],
"dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task."
"dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task.",
"evidence": "ignitionoee39afba8f chapter exit, c155798e official Secrets UI1.0.1/Abs0.6.6 adoption; docs/ui-validation/OEE-chapter-exit.md and secrets-ui-adoption.md."
},
{
"id": "OEE-10",