feat(secrets-ui): add/rotate/delete modal + audited gated reveal

This commit is contained in:
Joseph Doherty
2026-07-15 17:20:01 -04:00
parent d7f8ca455b
commit 21556cc1a7
15 changed files with 950 additions and 14 deletions
@@ -0,0 +1,24 @@
using System.Collections.Concurrent;
using ZB.MOM.WW.Audit;
namespace ZB.MOM.WW.Secrets.Ui.Tests.Fakes;
/// <summary>
/// An <see cref="IAuditWriter"/> test double that collects every <see cref="AuditEvent"/> written,
/// so a test can assert on the audit trail (action, outcome, target, actor) and — critically — that
/// no plaintext ever appears in any audit field.
/// </summary>
public sealed class CapturingAuditWriter : IAuditWriter
{
private readonly ConcurrentQueue<AuditEvent> _events = new();
/// <summary>The events captured so far, in write order.</summary>
public IReadOnlyList<AuditEvent> Events => _events.ToArray();
/// <inheritdoc />
public Task WriteAsync(AuditEvent evt, CancellationToken ct = default)
{
_events.Enqueue(evt);
return Task.CompletedTask;
}
}
@@ -0,0 +1,45 @@
using System.Text;
using ZB.MOM.WW.Secrets.Abstractions;
namespace ZB.MOM.WW.Secrets.Ui.Tests.Fakes;
/// <summary>
/// A trivial, reversible <see cref="ISecretCipher"/> stand-in for UI tests. It does not perform real
/// cryptography — it simply carries the UTF-8 plaintext in <see cref="StoredSecret.Ciphertext"/> so a
/// test can prove the editor's encrypt→upsert round-trips back to the entered value. Never used in
/// production. A <see cref="FailDecrypt"/> flag lets a test drive the decrypt-failure reveal path.
/// </summary>
public sealed class FakeCipher : ISecretCipher
{
/// <summary>When <c>true</c>, <see cref="Decrypt"/> throws to exercise the failure path.</summary>
public bool FailDecrypt { get; set; }
/// <inheritdoc />
public StoredSecret Encrypt(SecretName name, string plaintext, SecretContentType contentType)
=> new()
{
Name = name,
ContentType = contentType,
Ciphertext = Encoding.UTF8.GetBytes(plaintext),
Nonce = [1, 2, 3],
Tag = [4, 5, 6],
WrappedDek = [7, 8, 9],
WrapNonce = [10, 11, 12],
WrapTag = [13, 14, 15],
KekId = "fake-kek",
Revision = 0,
CreatedUtc = default,
UpdatedUtc = default,
};
/// <inheritdoc />
public string Decrypt(StoredSecret secret)
{
if (FailDecrypt)
{
throw new SecretDecryptionException("Fake decrypt failure.");
}
return Encoding.UTF8.GetString(secret.Ciphertext);
}
}
@@ -0,0 +1,75 @@
using System.Collections.Concurrent;
using ZB.MOM.WW.Secrets.Abstractions;
namespace ZB.MOM.WW.Secrets.Ui.Tests.Fakes;
/// <summary>
/// A hand-written <see cref="ISecretStore"/> test double (the family does not use Moq) that keeps
/// an in-memory table of rows and records every <see cref="UpsertAsync"/> and
/// <see cref="DeleteAsync"/> call so a test can assert on the mutation trail.
/// </summary>
public sealed class RecordingSecretStore : ISecretStore
{
private readonly ConcurrentDictionary<string, StoredSecret> _rows = new();
private readonly ConcurrentQueue<StoredSecret> _upserts = new();
private readonly ConcurrentQueue<(SecretName Name, string? Actor)> _deletes = new();
/// <summary>Rows upserted, in call order.</summary>
public IReadOnlyList<StoredSecret> Upserts => _upserts.ToArray();
/// <summary>Delete calls (name + recorded actor), in call order.</summary>
public IReadOnlyList<(SecretName Name, string? Actor)> Deletes => _deletes.ToArray();
/// <summary>Seeds a row so <see cref="GetAsync"/> and <see cref="ListAsync"/> can return it.</summary>
/// <param name="row">The row to seed.</param>
public void Seed(StoredSecret row) => _rows[row.Name.Value] = row;
/// <inheritdoc />
public Task<StoredSecret?> GetAsync(SecretName name, CancellationToken ct)
=> Task.FromResult(_rows.TryGetValue(name.Value, out StoredSecret? row) ? row : null);
/// <inheritdoc />
public Task UpsertAsync(StoredSecret row, CancellationToken ct)
{
_rows[row.Name.Value] = row;
_upserts.Enqueue(row);
return Task.CompletedTask;
}
/// <inheritdoc />
public Task<bool> DeleteAsync(SecretName name, string? actor, CancellationToken ct)
{
_deletes.Enqueue((name, actor));
return Task.FromResult(_rows.TryRemove(name.Value, out _));
}
/// <inheritdoc />
public Task<IReadOnlyList<SecretMetadata>> ListAsync(bool includeDeleted, CancellationToken ct)
{
IReadOnlyList<SecretMetadata> projection = _rows.Values
.Where(r => includeDeleted || !r.IsDeleted)
.Select(r => new SecretMetadata
{
Name = r.Name,
Description = r.Description,
ContentType = r.ContentType,
KekId = r.KekId,
Revision = r.Revision,
IsDeleted = r.IsDeleted,
CreatedUtc = r.CreatedUtc,
UpdatedUtc = r.UpdatedUtc,
CreatedBy = r.CreatedBy,
UpdatedBy = r.UpdatedBy,
})
.ToArray();
return Task.FromResult(projection);
}
/// <inheritdoc />
public Task<IReadOnlyList<SecretManifestEntry>> GetManifestAsync(CancellationToken ct)
=> throw new NotSupportedException();
/// <inheritdoc />
public Task ApplyReplicatedAsync(StoredSecret row, CancellationToken ct)
=> throw new NotSupportedException();
}