plan: Task 2.5 (ScadaBridge audit full re-arch C1-C7) DONE+reviewed -> PHASE 2 COMPLETE (audit adopted across all 3 repos, deep/canonical, local-only). Next = Phase 3 Actor->principal wiring

This commit is contained in:
Joseph Doherty
2026-06-02 15:10:54 -04:00
parent a591a9fb47
commit 1ec057a32a
3 changed files with 13 additions and 6 deletions
@@ -190,8 +190,12 @@ gutting the partitioned store, the state machine, the filter, or the reporting
canonical `AuditEvent` directly via `IAuditWriter` with structured `Target` + (dashboard) `CorrelationId`. 587 pass,
3 pre-existing FakeWorker reds, +10 tests. `api_key_audit` left unused (documented). Minor backlog: dup `WrapDetail`,
per-op `EnsureTable`, a test temp-dir leak, unfiltered `ListRecent` category.
- ** ScadaBridge 2.5 — NOT STARTED.** Branch `feat/adopt-zb-audit` created (stacked on auth) but untouched. Awaiting
the variant decision below (full re-arch vs bounded "deep-at-the-seam").
- ** ScadaBridge 2.5 — DONE (FULL re-arch, user-chosen).** Decomposed into C1C7 (design in
`2026-06-02-scadabridge-audit-rearch.md`), all spec+code reviewed, MSSQL-verified, local-only on `feat/adopt-zb-audit`.
Canonical record everywhere; site SQLite two-table (canonical + forwarding sidecar); central `dbo.AuditLog` collapsed to
10 canonical cols + persisted computed cols (`CollapseAuditLogToCanonical` migration); redactor/outcome/UI/export/CLI all
canonical. Forwarding state machine preserved (sidecar) + queryability preserved (persisted computed columns) — the design's
key insight that central is append-only made pure-9-col central feasible without gutting forwarding.
## Open items to confirm at review
1. **ScadaBridge:** full audit re-architecture (pure 9-col storage) vs the **bounded "deep-at-the-seam"** variant