103 lines
3.4 KiB
C#
103 lines
3.4 KiB
C#
using ScadaLink.Commons.Messages.Management;
|
|
using ScadaLink.ManagementService;
|
|
|
|
namespace ScadaLink.ManagementService.Tests;
|
|
|
|
/// <summary>
|
|
/// Tests for <see cref="ManagementEndpoints"/> request-body parsing
|
|
/// (findings ManagementService-006 / -013).
|
|
/// </summary>
|
|
public class ManagementEndpointsTests
|
|
{
|
|
[Fact]
|
|
public void ParseCommand_WithExplicitPayload_DeserializesIntoCommandType()
|
|
{
|
|
var json = """{ "command": "CreateSite", "payload": { "name": "Site1", "siteIdentifier": "SITE1", "description": "Desc" } }""";
|
|
|
|
var result = ManagementEndpoints.ParseCommand(json);
|
|
|
|
Assert.True(result.Success);
|
|
var command = Assert.IsType<CreateSiteCommand>(result.Command);
|
|
Assert.Equal("Site1", command.Name);
|
|
Assert.Equal("SITE1", command.SiteIdentifier);
|
|
Assert.Equal("Desc", command.Description);
|
|
}
|
|
|
|
[Fact]
|
|
public void ParseCommand_WithMissingPayload_DeserializesParameterlessCommand()
|
|
{
|
|
// No "payload" field at all -- the fallback must not allocate a throwaway
|
|
// JsonDocument and must still produce a valid parameterless command.
|
|
var json = """{ "command": "ListTemplates" }""";
|
|
|
|
var result = ManagementEndpoints.ParseCommand(json);
|
|
|
|
Assert.True(result.Success);
|
|
Assert.IsType<ListTemplatesCommand>(result.Command);
|
|
}
|
|
|
|
[Fact]
|
|
public void ParseCommand_WithInvalidJson_ReturnsFailure()
|
|
{
|
|
var result = ManagementEndpoints.ParseCommand("{ not json");
|
|
|
|
Assert.False(result.Success);
|
|
Assert.Equal("BAD_REQUEST", result.ErrorCode);
|
|
}
|
|
|
|
[Fact]
|
|
public void ParseCommand_WithMissingCommandField_ReturnsFailure()
|
|
{
|
|
var result = ManagementEndpoints.ParseCommand("""{ "payload": {} }""");
|
|
|
|
Assert.False(result.Success);
|
|
Assert.Equal("BAD_REQUEST", result.ErrorCode);
|
|
}
|
|
|
|
[Fact]
|
|
public void ParseCommand_WithUnknownCommand_ReturnsFailure()
|
|
{
|
|
var result = ManagementEndpoints.ParseCommand("""{ "command": "NoSuchCommand" }""");
|
|
|
|
Assert.False(result.Success);
|
|
Assert.Equal("BAD_REQUEST", result.ErrorCode);
|
|
}
|
|
|
|
// ========================================================================
|
|
// Command-timeout configuration (finding ManagementService-010)
|
|
//
|
|
// ManagementServiceOptions.CommandTimeout must actually drive the Ask
|
|
// timeout instead of a hard-coded 30s constant.
|
|
// ========================================================================
|
|
|
|
[Fact]
|
|
public void ResolveAskTimeout_UsesConfiguredCommandTimeout()
|
|
{
|
|
var options = new ManagementServiceOptions { CommandTimeout = TimeSpan.FromSeconds(75) };
|
|
|
|
var timeout = ManagementEndpoints.ResolveAskTimeout(options);
|
|
|
|
Assert.Equal(TimeSpan.FromSeconds(75), timeout);
|
|
}
|
|
|
|
[Fact]
|
|
public void ResolveAskTimeout_WithNullOptions_FallsBackToDefault()
|
|
{
|
|
var timeout = ManagementEndpoints.ResolveAskTimeout(null);
|
|
|
|
Assert.Equal(TimeSpan.FromSeconds(30), timeout);
|
|
}
|
|
|
|
[Fact]
|
|
public void ResolveAskTimeout_WithNonPositiveTimeout_FallsBackToDefault()
|
|
{
|
|
// A misconfigured zero/negative timeout would make every Ask fail
|
|
// immediately; fall back to the safe default instead.
|
|
var options = new ManagementServiceOptions { CommandTimeout = TimeSpan.Zero };
|
|
|
|
var timeout = ManagementEndpoints.ResolveAskTimeout(options);
|
|
|
|
Assert.Equal(TimeSpan.FromSeconds(30), timeout);
|
|
}
|
|
}
|