Joseph Doherty
4fa6f0e774
fix(deployment-manager): resolve DeploymentManager-015..017 — reconciliation applies post-success side effects, updates RevisionHash, corrected XML doc
2026-05-17 03:18:24 -04:00
Joseph Doherty
14ba5495d1
fix(data-connection-layer): resolve DataConnectionLayer-014..017 — real logger for OPC UA client, initial-connect failover, accurate subscribe response, per-tag write-batch results
2026-05-17 03:18:24 -04:00
Joseph Doherty
3d3f43229f
fix(configuration-database): resolve ConfigurationDatabase-013,014 — fail-fast on missing key ring, single converter local; ConfigurationDatabase-012 left open (cross-module design decision)
2026-05-17 03:18:24 -04:00
Joseph Doherty
a768135237
fix(communication): resolve Communication-012..015 — endpoint-aware gRPC client cache, address-change recreation, correlation-id validation, node-flip tests
2026-05-17 03:18:17 -04:00
Joseph Doherty
a78c3bcb6f
fix(commons): resolve Commons-013,014 — integral JSON index handling, distinguish Malformed vs Legacy OPC UA config
2026-05-17 03:18:17 -04:00
Joseph Doherty
21856a4be7
fix(cluster-infrastructure): resolve ClusterInfrastructure-009,010 — DownIfAlone consumption (via Host-012), validator enforces DownIfAlone=true
2026-05-17 03:18:17 -04:00
Joseph Doherty
d7d74ebe5e
fix(central-ui): resolve CentralUI-020..025 — auth-ping idle logout, DebugView race, push-handler disposal guard, JS-interop catch narrowing, claim-constant helper, SessionExpiry tests
2026-05-17 03:18:16 -04:00
Joseph Doherty
f82bcbed7c
fix(cli): resolve CLI-014..016 — re-triage update-command contract, doc-surface drift, table-column union
2026-05-17 03:18:16 -04:00
Joseph Doherty
0ba4e49e11
docs(code-reviews): re-review batch 4 at 39d737e — SiteEventLogging, SiteRuntime, StoreAndForward, TemplateEngine
...
11 new findings: SiteEventLogging-012..014, SiteRuntime-017..019, StoreAndForward-015..017, TemplateEngine-015..016.
2026-05-17 00:51:58 -04:00
Joseph Doherty
3b3760f026
docs(code-reviews): re-review batch 3 at 39d737e — Host, InboundAPI, ManagementService, NotificationService, Security
...
21 new findings: Host-012..015, InboundAPI-014..017, ManagementService-014..017, NotificationService-014..018, Security-012..015.
2026-05-17 00:48:25 -04:00
Joseph Doherty
89636e2bbf
docs(code-reviews): re-review batch 2 at 39d737e — ConfigurationDatabase, DataConnectionLayer, DeploymentManager, ExternalSystemGateway, HealthMonitoring
...
17 new findings: ConfigurationDatabase-012..014, DataConnectionLayer-014..017, DeploymentManager-015..017, ExternalSystemGateway-015..017, HealthMonitoring-013..016.
2026-05-17 00:45:10 -04:00
Joseph Doherty
e49846603e
docs(code-reviews): re-review batch 1 at 39d737e — CentralUI, CLI, ClusterInfrastructure, Commons, Communication
...
17 new findings: CentralUI-020..025, CLI-014..016, ClusterInfrastructure-009..010, Commons-013..014, Communication-012..015.
2026-05-17 00:41:21 -04:00
Joseph Doherty
39d737ebd6
docs(code-reviews): regenerate index — all low/medium findings resolved
2026-05-17 00:04:56 -04:00
Joseph Doherty
8dd74121c3
fix(inbound-api): resolve InboundAPI-012 — move ParameterDefinition POCO to ScadaLink.Commons (Types/InboundApi)
2026-05-17 00:04:56 -04:00
Joseph Doherty
34588ae10c
fix(central-ui): resolve CentralUI-006 — push-based deployment status via IDeploymentStatusNotifier, remove 10s polling timer
2026-05-17 00:02:45 -04:00
Joseph Doherty
a55502254e
fix(external-system-gateway): resolve ExternalSystemGateway-011 — name-keyed repository lookups replace fetch-all-then-filter on the call hot path
2026-05-17 00:02:45 -04:00
Joseph Doherty
1e2e7d2e7c
fix(central-ui): resolve CentralUI-005 — sliding cookie session expiry (Security AddCookie + AuthEndpoints + SessionExpiry)
2026-05-16 23:54:31 -04:00
Joseph Doherty
b1f4251d75
fix(commons): resolve Commons-008 — replace ValueTuple in SetConnectionBindingsCommand with named ConnectionBinding record (CLI, ManagementService, TemplateEngine, CentralUI)
2026-05-16 23:54:31 -04:00
Joseph Doherty
c583598888
fix(deployment-manager): resolve DeploymentManager-013 — document SMTP-credential artifact handling as a conscious accepted design decision
2026-05-16 23:49:25 -04:00
Joseph Doherty
a2f6c1b9b2
fix(inbound-api): resolve InboundAPI-007 — remove unimplemented Database.Connection() script API from design doc (conflicts with script trust model)
2026-05-16 23:49:25 -04:00
Joseph Doherty
3d0c1c6963
fix(host): resolve Host-002 — REQ-HOST-6 doc corrected to drop unused Akka.Persistence requirement
2026-05-16 23:49:25 -04:00
Joseph Doherty
13a33a6c78
docs(code-reviews): regenerate index after batch 4 low/medium fixes
2026-05-16 22:32:31 -04:00
Joseph Doherty
adb5e75ec3
fix(template-engine): resolve TemplateEngine-011,013,014 — remove dead converter, duplicate-id-safe cycle detection, unified deletion logic; TemplateEngine-012 deferred
2026-05-16 22:32:30 -04:00
Joseph Doherty
9e2416b34c
fix(store-and-forward): resolve StoreAndForward-006,007,008,009 — transactional parked reads, PipeTo, fault-isolated activity events; 002/011/012 deferred
2026-05-16 22:32:30 -04:00
Joseph Doherty
dd7626da63
fix(site-runtime): resolve SiteRuntime-012,013,015,016 — doc accuracy, shared LoggerFactory, execution-actor coverage; SiteRuntime-014 deferred
2026-05-16 22:32:30 -04:00
Joseph Doherty
b1ea78a9fd
fix(site-event-logging): resolve SiteEventLogging-006,009,011 — severity index, accurate XML doc, dead-placeholder removal
2026-05-16 22:32:30 -04:00
Joseph Doherty
a3d359fff7
docs(code-reviews): regenerate index after batch 3 low/medium fixes
2026-05-16 22:24:03 -04:00
Joseph Doherty
84a696b0e4
fix(security): resolve Security-009,010,011 — LDAP connection timeout, design-doc correction, security-path test coverage; Security-008 deferred
2026-05-16 22:24:03 -04:00
Joseph Doherty
a9bd017c88
fix(notification-service): resolve NotificationService-010,011,012 — disconnect SMTP on failure, relocate exception type, OAuth2/token-cache test coverage
2026-05-16 22:24:03 -04:00
Joseph Doherty
dab0056d1b
fix(management-service): resolve ManagementService-005,008,010,011 — supervision strategy, configured command timeout, remove stale ResolveRoles path; ManagementService-012 deferred
2026-05-16 22:24:03 -04:00
Joseph Doherty
858fe24add
fix(inbound-api): resolve InboundAPI-009,010,011,013 — cache failed compiles, reject unknown body fields, close enumeration oracle, drop misnamed factory; InboundAPI-007,012 flagged
2026-05-16 22:24:03 -04:00
Joseph Doherty
8664cdf940
fix(host): resolve Host-005..011 — async startup, HOCON escaping, port-conflict check, dead-config cleanup, migration retry, log-level wiring; Host-002 flagged
2026-05-16 22:24:03 -04:00
Joseph Doherty
3f19371017
docs(code-reviews): regenerate index after batch 2 low/medium fixes
2026-05-16 22:14:46 -04:00
Joseph Doherty
2d7ac5b57f
fix(health-monitoring): resolve HealthMonitoring-004,006,010,011,012 — heartbeat-doc accuracy, testable sequence seeding, logged failures, dead-code removal
2026-05-16 22:14:23 -04:00
Joseph Doherty
e57ccd78b7
fix(external-system-gateway): resolve ExternalSystemGateway-012,013,014 — failure logging, connection-limit wiring, test coverage; ExternalSystemGateway-011 flagged
2026-05-16 22:14:23 -04:00
Joseph Doherty
e9ee4e3ea5
fix(deployment-manager): resolve DeploymentManager-009,010,012,014 — shared deployment ID, lifecycle-timeout enforcement, doc/test cleanup; DeploymentManager-013 flagged
2026-05-16 22:14:23 -04:00
Joseph Doherty
ff4a4bdeb7
fix(data-connection-layer): resolve DataConnectionLayer-008,013 — O(1) unsubscribe via reverse index, atomic disconnect guard
2026-05-16 22:14:23 -04:00
Joseph Doherty
7d1cc5cbb4
fix(configuration-database): resolve ConfigurationDatabase-005,006,008,009,010,011 — bounded gRPC columns, split queries, CSV-parse logging, null guards, coverage
2026-05-16 22:14:23 -04:00
Joseph Doherty
25a05af05d
docs(code-reviews): regenerate index after batch 1 low/medium fixes
2026-05-16 22:04:44 -04:00
Joseph Doherty
0b4c1563aa
fix(communication): resolve Communication-009,010,011 — atomic site-cache refresh, XML doc correction, test coverage
2026-05-16 22:04:21 -04:00
Joseph Doherty
c07f524ca4
fix(commons): resolve Commons-005..007,009..012 — OPC UA parse status, TryConvert correctness, Result null guard, invariant formatting, doc refresh
2026-05-16 22:04:21 -04:00
Joseph Doherty
746ab90444
fix(cluster-infrastructure): resolve ClusterInfrastructure-005,007,008 — confirm config-section constant, XML docs, phase-status cleanup
2026-05-16 22:04:21 -04:00
Joseph Doherty
d7b275fc9b
fix(central-ui): resolve CentralUI-015..019 — pager windowing, logout CSRF, narrowed catch blocks, coverage; CentralUI-015 re-triaged Won't Fix
2026-05-16 22:04:21 -04:00
Joseph Doherty
404216b4ee
fix(cli): resolve CLI-008..013 — format validation, exit-code semantics, debug-stream cancellation/disposal, test coverage
2026-05-16 22:04:21 -04:00
Joseph Doherty
bc88a36435
docs(code-reviews): regenerate index after batch 4 medium fixes
2026-05-16 21:44:11 -04:00
Joseph Doherty
804697f873
fix(template-engine): resolve TemplateEngine-006..010 — code-region-aware API/brace scanning, composed-alarm override validation, N+1 fix, doc correction
2026-05-16 21:44:11 -04:00
Joseph Doherty
5672502d83
fix(store-and-forward): resolve StoreAndForward-004,005,010,013 — accurate handler-contract doc, conditional sweep writes, reset LastAttemptAt on parked retry, test coverage
2026-05-16 21:44:10 -04:00
Joseph Doherty
a88bec9376
fix(site-runtime): resolve SiteRuntime-004..011 — deploy-after-persist, remove reflection, deterministic IDs, non-blocking startup, dedicated script scheduler, config-change detection, semantic trust-model check
2026-05-16 21:44:10 -04:00
Joseph Doherty
24a4a2d165
fix(site-event-logging): resolve SiteEventLogging-005,007,008,010 — background async writer, drop concrete downcast, surface write failures, test coverage
2026-05-16 21:44:10 -04:00
Joseph Doherty
632d44f38c
fix(host,deployment-manager,communication): repair cross-module DI regressions from batch 1-2
...
- DeploymentManager-008: revert IConfiguration overload (violated OptionsTests
component-convention); Host now binds the ScadaLink:DeploymentManager section
- SiteStreamGrpcServer: make test-only int ctor internal so DI sees one public
ctor (resolves ambiguous-constructor failure in SiteCompositionRootTests)
- Host site composition-root test config: supply Cluster:SeedNodes for the new
ClusterOptionsValidator
2026-05-16 21:28:50 -04:00