fix(cli): correct audit query channel/kind/status enum names + drop dead --instance flag (#23 M8)

tests/ScadaLink.CLI.Tests/Commands/AuditQueryCommandTests.cs

@@ -58,11 +58,10 @@ public class AuditQueryCommandTests
         {
             Since = "1h",
             Until = "2026-05-20T12:00:00Z",
-            Channel = "OutboundApi",
-            Kind = "CachedCall",
+            Channel = "ApiOutbound",
+            Kind = "ApiCallCached",
             Status = "Delivered",
             Site = "site-1",
-            Instance = "pump-7",
             Target = "weather-api",
             Actor = "multi-role",
             CorrelationId = "abc-123",
@@ -73,11 +72,12 @@ public class AuditQueryCommandTests
         var qs = AuditQueryHelpers.BuildQueryString(args, now, afterOccurredAtUtc: null, afterEventId: null);
         var parsed = HttpUtility.ParseQueryString(qs.TrimStart('?'));
 
-        Assert.Equal("OutboundApi", parsed["channel"]);
-        Assert.Equal("CachedCall", parsed["kind"]);
+        Assert.Equal("ApiOutbound", parsed["channel"]);
+        Assert.Equal("ApiCallCached", parsed["kind"]);
         Assert.Equal("Delivered", parsed["status"]);
         Assert.Equal("site-1", parsed["sourceSiteId"]);
-        Assert.Equal("pump-7", parsed["instance"]);
+        // --instance was dropped: AuditLogQueryFilter has no instance column.
+        Assert.Null(parsed["instance"]);
         Assert.Equal("weather-api", parsed["target"]);
         Assert.Equal("multi-role", parsed["actor"]);
         Assert.Equal("abc-123", parsed["correlationId"]);
@@ -243,4 +243,43 @@ public class AuditQueryCommandTests
         var parse = root.Parse(new[] { "audit", "query", "--format", "table" });
         Assert.Empty(parse.Errors);
     }
+
+    // ---- Enum-name validation (fast-fail) ----------------------------------
+
+    [Fact]
+    public void Query_ChannelWithRealEnumName_IsAccepted()
+    {
+        var root = AuditCommandTestHarness.BuildRoot();
+        var parse = root.Parse(new[] { "audit", "query", "--channel", "ApiOutbound" });
+        Assert.Empty(parse.Errors);
+    }
+
+    [Fact]
+    public void Query_ChannelWithInvalidName_FailsFast_NonZeroExit()
+    {
+        // "OutboundApi" is the old (non-existent) name; the real enum is "ApiOutbound".
+        var root = AuditCommandTestHarness.BuildRoot();
+        var (exit, _, err) = AuditCommandTestHarness.Invoke(root, "audit", "query", "--channel", "OutboundApi");
+        Assert.NotEqual(0, exit);
+        Assert.NotEqual("", err);
+        Assert.Contains("OutboundApi", err);
+    }
+
+    [Fact]
+    public void Query_KindWithInvalidName_FailsFast_NonZeroExit()
+    {
+        var root = AuditCommandTestHarness.BuildRoot();
+        var (exit, _, err) = AuditCommandTestHarness.Invoke(root, "audit", "query", "--kind", "CachedCall");
+        Assert.NotEqual(0, exit);
+        Assert.NotEqual("", err);
+    }
+
+    [Fact]
+    public void Query_StatusWithInvalidName_FailsFast_NonZeroExit()
+    {
+        var root = AuditCommandTestHarness.BuildRoot();
+        var (exit, _, err) = AuditCommandTestHarness.Invoke(root, "audit", "query", "--status", "Bogus");
+        Assert.NotEqual(0, exit);
+        Assert.NotEqual("", err);
+    }
 }