Phase 2 WP-1–13+23: Template Engine CRUD, composition, overrides, locking, collision detection, acyclicity

- WP-23: ITemplateEngineRepository full EF Core implementation - WP-1: Template CRUD with deletion constraints (instances, children, compositions) - WP-2–4: Attribute, alarm, script definitions with lock flags and override granularity - WP-5: Shared script CRUD with syntax validation - WP-6–7: Composition with recursive nesting and canonical naming - WP-8–11: Override granularity, locking rules, inheritance/composition scope - WP-12: Naming collision detection on canonical names (recursive) - WP-13: Graph acyclicity (inheritance + composition cycles) Core services: TemplateService, SharedScriptService, TemplateResolver, LockEnforcer, CollisionDetector, CycleDetector. 358 tests pass.
2026-03-16 20:10:34 -04:00
parent 84ad6bb77d
commit faef2d0de6
47 changed files with 7741 additions and 11 deletions
--- a/tests/ScadaLink.TemplateEngine.Tests/Validation/ValidationServiceTests.cs
+++ b/tests/ScadaLink.TemplateEngine.Tests/Validation/ValidationServiceTests.cs
@@ -0,0 +1,193 @@
+using ScadaLink.Commons.Types.Flattening;
+using ScadaLink.TemplateEngine.Validation;
+
+namespace ScadaLink.TemplateEngine.Tests.Validation;
+
+public class ValidationServiceTests
+{
+    private readonly ValidationService _sut = new();
+
+    [Fact]
+    public void Validate_ValidConfig_ReturnsSuccess()
+    {
+        var config = new FlattenedConfiguration
+        {
+            InstanceUniqueName = "Instance1",
+            Attributes = [new ResolvedAttribute { CanonicalName = "Temp", Value = "25", DataType = "Double" }],
+            Scripts = [new ResolvedScript { CanonicalName = "Monitor", Code = "var x = 1;" }]
+        };
+
+        var result = _sut.Validate(config);
+        Assert.True(result.IsValid);
+    }
+
+    [Fact]
+    public void Validate_EmptyInstanceName_ReturnsError()
+    {
+        var config = new FlattenedConfiguration
+        {
+            InstanceUniqueName = "",
+            Attributes = [new ResolvedAttribute { CanonicalName = "Temp", DataType = "Double" }]
+        };
+
+        var result = _sut.Validate(config);
+        Assert.False(result.IsValid);
+        Assert.Contains(result.Errors, e => e.Category == ValidationCategory.FlatteningFailure);
+    }
+
+    [Fact]
+    public void Validate_NamingCollision_ReturnsError()
+    {
+        var config = new FlattenedConfiguration
+        {
+            InstanceUniqueName = "Instance1",
+            Attributes =
+            [
+                new ResolvedAttribute { CanonicalName = "Temp", DataType = "Double" },
+                new ResolvedAttribute { CanonicalName = "Temp", DataType = "Int32" } // Duplicate!
+            ]
+        };
+
+        var result = _sut.Validate(config);
+        Assert.False(result.IsValid);
+        Assert.Contains(result.Errors, e => e.Category == ValidationCategory.NamingCollision);
+    }
+
+    [Fact]
+    public void Validate_ForbiddenApi_ReturnsCompilationError()
+    {
+        var config = new FlattenedConfiguration
+        {
+            InstanceUniqueName = "Instance1",
+            Scripts =
+            [
+                new ResolvedScript
+                {
+                    CanonicalName = "BadScript",
+                    Code = "System.IO.File.ReadAllText(\"secret.txt\");"
+                }
+            ]
+        };
+
+        var result = _sut.Validate(config);
+        Assert.False(result.IsValid);
+        Assert.Contains(result.Errors, e => e.Category == ValidationCategory.ScriptCompilation);
+    }
+
+    [Fact]
+    public void Validate_MismatchedBraces_ReturnsCompilationError()
+    {
+        var config = new FlattenedConfiguration
+        {
+            InstanceUniqueName = "Instance1",
+            Scripts =
+            [
+                new ResolvedScript { CanonicalName = "Bad", Code = "if (true) {" }
+            ]
+        };
+
+        var result = _sut.Validate(config);
+        Assert.False(result.IsValid);
+        Assert.Contains(result.Errors, e => e.Category == ValidationCategory.ScriptCompilation);
+    }
+
+    [Fact]
+    public void Validate_AlarmReferencesMissingAttribute_ReturnsError()
+    {
+        var config = new FlattenedConfiguration
+        {
+            InstanceUniqueName = "Instance1",
+            Attributes = [new ResolvedAttribute { CanonicalName = "Temp", DataType = "Double" }],
+            Alarms =
+            [
+                new ResolvedAlarm
+                {
+                    CanonicalName = "HighPressure",
+                    TriggerType = "RangeViolation",
+                    TriggerConfiguration = "{\"attributeName\":\"Pressure\"}" // Pressure doesn't exist
+                }
+            ]
+        };
+
+        var result = _sut.Validate(config);
+        Assert.False(result.IsValid);
+        Assert.Contains(result.Errors, e => e.Category == ValidationCategory.AlarmTriggerReference);
+    }
+
+    [Fact]
+    public void Validate_AlarmReferencesExistingAttribute_NoError()
+    {
+        var config = new FlattenedConfiguration
+        {
+            InstanceUniqueName = "Instance1",
+            Attributes = [new ResolvedAttribute { CanonicalName = "Temp", DataType = "Double" }],
+            Alarms =
+            [
+                new ResolvedAlarm
+                {
+                    CanonicalName = "HighTemp",
+                    TriggerType = "RangeViolation",
+                    TriggerConfiguration = "{\"attributeName\":\"Temp\"}"
+                }
+            ]
+        };
+
+        var result = _sut.Validate(config);
+        // Should not have alarm trigger reference errors
+        Assert.DoesNotContain(result.Errors, e => e.Category == ValidationCategory.AlarmTriggerReference);
+    }
+
+    [Fact]
+    public void Validate_ScriptTriggerReferencesMissingAttribute_ReturnsError()
+    {
+        var config = new FlattenedConfiguration
+        {
+            InstanceUniqueName = "Instance1",
+            Attributes = [new ResolvedAttribute { CanonicalName = "Temp", DataType = "Double" }],
+            Scripts =
+            [
+                new ResolvedScript
+                {
+                    CanonicalName = "OnChange",
+                    Code = "var x = 1;",
+                    TriggerConfiguration = "{\"attributeName\":\"Missing\"}"
+                }
+            ]
+        };
+
+        var result = _sut.Validate(config);
+        Assert.False(result.IsValid);
+        Assert.Contains(result.Errors, e => e.Category == ValidationCategory.ScriptTriggerReference);
+    }
+
+    [Fact]
+    public void Validate_UnboundDataSourceAttribute_ReturnsWarning()
+    {
+        var config = new FlattenedConfiguration
+        {
+            InstanceUniqueName = "Instance1",
+            Attributes =
+            [
+                new ResolvedAttribute
+                {
+                    CanonicalName = "Temp",
+                    DataType = "Double",
+                    DataSourceReference = "ns=2;s=Temp",
+                    BoundDataConnectionId = null // No binding!
+                }
+            ]
+        };
+
+        var result = _sut.Validate(config);
+        Assert.Contains(result.Warnings, w => w.Category == ValidationCategory.ConnectionBinding);
+    }
+
+    [Fact]
+    public void Validate_EmptyConfig_ReturnsWarning()
+    {
+        var config = new FlattenedConfiguration { InstanceUniqueName = "Instance1" };
+
+        var result = _sut.Validate(config);
+        Assert.Contains(result.Warnings, w => w.Category == ValidationCategory.FlatteningFailure);
+    }
+}