Phase 2 WP-1–13+23: Template Engine CRUD, composition, overrides, locking, collision detection, acyclicity

- WP-23: ITemplateEngineRepository full EF Core implementation - WP-1: Template CRUD with deletion constraints (instances, children, compositions) - WP-2–4: Attribute, alarm, script definitions with lock flags and override granularity - WP-5: Shared script CRUD with syntax validation - WP-6–7: Composition with recursive nesting and canonical naming - WP-8–11: Override granularity, locking rules, inheritance/composition scope - WP-12: Naming collision detection on canonical names (recursive) - WP-13: Graph acyclicity (inheritance + composition cycles) Core services: TemplateService, SharedScriptService, TemplateResolver, LockEnforcer, CollisionDetector, CycleDetector. 358 tests pass.
2026-03-16 20:10:34 -04:00
parent 84ad6bb77d
commit faef2d0de6
47 changed files with 7741 additions and 11 deletions
--- a/tests/ScadaLink.TemplateEngine.Tests/LockEnforcerTests.cs
+++ b/tests/ScadaLink.TemplateEngine.Tests/LockEnforcerTests.cs
@@ -0,0 +1,214 @@
+using ScadaLink.Commons.Entities.Templates;
+using ScadaLink.Commons.Types.Enums;
+
+namespace ScadaLink.TemplateEngine.Tests;
+
+public class LockEnforcerTests
+{
+    // ========================================================================
+    // WP-8: Override Granularity
+    // ========================================================================
+
+    [Fact]
+    public void ValidateAttributeOverride_LockedAttribute_ReturnsError()
+    {
+        var original = new TemplateAttribute("Speed")
+        {
+            DataType = DataType.Float, IsLocked = true, Value = "0"
+        };
+        var proposed = new TemplateAttribute("Speed")
+        {
+            DataType = DataType.Float, IsLocked = true, Value = "100"
+        };
+
+        var result = LockEnforcer.ValidateAttributeOverride(original, proposed);
+
+        Assert.NotNull(result);
+        Assert.Contains("locked", result);
+    }
+
+    [Fact]
+    public void ValidateAttributeOverride_DataTypeChanged_ReturnsError()
+    {
+        var original = new TemplateAttribute("Speed")
+        {
+            DataType = DataType.Float, IsLocked = false
+        };
+        var proposed = new TemplateAttribute("Speed")
+        {
+            DataType = DataType.String, IsLocked = false // DataType changed!
+        };
+
+        var result = LockEnforcer.ValidateAttributeOverride(original, proposed);
+
+        Assert.NotNull(result);
+        Assert.Contains("DataType", result);
+    }
+
+    [Fact]
+    public void ValidateAttributeOverride_DataSourceReferenceChanged_ReturnsError()
+    {
+        var original = new TemplateAttribute("Speed")
+        {
+            DataType = DataType.Float, IsLocked = false, DataSourceReference = "tag1"
+        };
+        var proposed = new TemplateAttribute("Speed")
+        {
+            DataType = DataType.Float, IsLocked = false, DataSourceReference = "tag2" // Changed!
+        };
+
+        var result = LockEnforcer.ValidateAttributeOverride(original, proposed);
+
+        Assert.NotNull(result);
+        Assert.Contains("DataSourceReference", result);
+    }
+
+    [Fact]
+    public void ValidateAttributeOverride_ValueAndDescriptionChanged_ReturnsNull()
+    {
+        var original = new TemplateAttribute("Speed")
+        {
+            DataType = DataType.Float, IsLocked = false, Value = "0", Description = "old"
+        };
+        var proposed = new TemplateAttribute("Speed")
+        {
+            DataType = DataType.Float, IsLocked = false, Value = "100", Description = "new"
+        };
+
+        var result = LockEnforcer.ValidateAttributeOverride(original, proposed);
+
+        Assert.Null(result);
+    }
+
+    [Fact]
+    public void ValidateAlarmOverride_LockedAlarm_ReturnsError()
+    {
+        var original = new TemplateAlarm("HighTemp")
+        {
+            TriggerType = AlarmTriggerType.ValueMatch, IsLocked = true, PriorityLevel = 500
+        };
+        var proposed = new TemplateAlarm("HighTemp")
+        {
+            TriggerType = AlarmTriggerType.ValueMatch, IsLocked = true, PriorityLevel = 600
+        };
+
+        var result = LockEnforcer.ValidateAlarmOverride(original, proposed);
+
+        Assert.NotNull(result);
+        Assert.Contains("locked", result);
+    }
+
+    [Fact]
+    public void ValidateAlarmOverride_TriggerTypeChanged_ReturnsError()
+    {
+        var original = new TemplateAlarm("HighTemp")
+        {
+            TriggerType = AlarmTriggerType.ValueMatch, IsLocked = false
+        };
+        var proposed = new TemplateAlarm("HighTemp")
+        {
+            TriggerType = AlarmTriggerType.RangeViolation, IsLocked = false // Changed!
+        };
+
+        var result = LockEnforcer.ValidateAlarmOverride(original, proposed);
+
+        Assert.NotNull(result);
+        Assert.Contains("TriggerType", result);
+    }
+
+    [Fact]
+    public void ValidateAlarmOverride_OverridableFieldsChanged_ReturnsNull()
+    {
+        var original = new TemplateAlarm("HighTemp")
+        {
+            TriggerType = AlarmTriggerType.ValueMatch, IsLocked = false,
+            PriorityLevel = 500, Description = "old"
+        };
+        var proposed = new TemplateAlarm("HighTemp")
+        {
+            TriggerType = AlarmTriggerType.ValueMatch, IsLocked = false,
+            PriorityLevel = 700, Description = "new", TriggerConfiguration = """{"value": 100}"""
+        };
+
+        var result = LockEnforcer.ValidateAlarmOverride(original, proposed);
+
+        Assert.Null(result);
+    }
+
+    [Fact]
+    public void ValidateScriptOverride_LockedScript_ReturnsError()
+    {
+        var original = new TemplateScript("OnStart", "code") { IsLocked = true };
+        var proposed = new TemplateScript("OnStart", "new code") { IsLocked = true };
+
+        var result = LockEnforcer.ValidateScriptOverride(original, proposed);
+
+        Assert.NotNull(result);
+        Assert.Contains("locked", result);
+    }
+
+    [Fact]
+    public void ValidateScriptOverride_NameChanged_ReturnsError()
+    {
+        var original = new TemplateScript("OnStart", "code") { IsLocked = false };
+        var proposed = new TemplateScript("OnStop", "code") { IsLocked = false }; // Name changed!
+
+        var result = LockEnforcer.ValidateScriptOverride(original, proposed);
+
+        Assert.NotNull(result);
+        Assert.Contains("Name", result);
+    }
+
+    [Fact]
+    public void ValidateScriptOverride_OverridableFieldsChanged_ReturnsNull()
+    {
+        var original = new TemplateScript("OnStart", "old code") { IsLocked = false };
+        var proposed = new TemplateScript("OnStart", "new code")
+        {
+            IsLocked = false,
+            TriggerType = "Timer",
+            MinTimeBetweenRuns = TimeSpan.FromSeconds(30)
+        };
+
+        var result = LockEnforcer.ValidateScriptOverride(original, proposed);
+
+        Assert.Null(result);
+    }
+
+    // ========================================================================
+    // WP-9: Locking Rules
+    // ========================================================================
+
+    [Fact]
+    public void ValidateLockChange_UnlockLocked_ReturnsError()
+    {
+        var result = LockEnforcer.ValidateLockChange(true, false, "Speed");
+
+        Assert.NotNull(result);
+        Assert.Contains("cannot be unlocked", result);
+    }
+
+    [Fact]
+    public void ValidateLockChange_LockUnlocked_ReturnsNull()
+    {
+        var result = LockEnforcer.ValidateLockChange(false, true, "Speed");
+
+        Assert.Null(result);
+    }
+
+    [Fact]
+    public void ValidateLockChange_KeepLocked_ReturnsNull()
+    {
+        var result = LockEnforcer.ValidateLockChange(true, true, "Speed");
+
+        Assert.Null(result);
+    }
+
+    [Fact]
+    public void ValidateLockChange_KeepUnlocked_ReturnsNull()
+    {
+        var result = LockEnforcer.ValidateLockChange(false, false, "Speed");
+
+        Assert.Null(result);
+    }
+}