Phase 2 WP-1–13+23: Template Engine CRUD, composition, overrides, locking, collision detection, acyclicity

- WP-23: ITemplateEngineRepository full EF Core implementation - WP-1: Template CRUD with deletion constraints (instances, children, compositions) - WP-2–4: Attribute, alarm, script definitions with lock flags and override granularity - WP-5: Shared script CRUD with syntax validation - WP-6–7: Composition with recursive nesting and canonical naming - WP-8–11: Override granularity, locking rules, inheritance/composition scope - WP-12: Naming collision detection on canonical names (recursive) - WP-13: Graph acyclicity (inheritance + composition cycles) Core services: TemplateService, SharedScriptService, TemplateResolver, LockEnforcer, CollisionDetector, CycleDetector. 358 tests pass.
2026-03-16 20:10:34 -04:00
parent 84ad6bb77d
commit faef2d0de6
47 changed files with 7741 additions and 11 deletions
--- a/tests/ScadaLink.TemplateEngine.Tests/Flattening/RevisionHashServiceTests.cs
+++ b/tests/ScadaLink.TemplateEngine.Tests/Flattening/RevisionHashServiceTests.cs
@@ -0,0 +1,115 @@
+using ScadaLink.Commons.Types.Flattening;
+using ScadaLink.TemplateEngine.Flattening;
+
+namespace ScadaLink.TemplateEngine.Tests.Flattening;
+
+public class RevisionHashServiceTests
+{
+    private readonly RevisionHashService _sut = new();
+
+    [Fact]
+    public void ComputeHash_SameContent_SameHash()
+    {
+        var config1 = CreateConfig("Instance1", "25.0");
+        var config2 = CreateConfig("Instance1", "25.0");
+
+        var hash1 = _sut.ComputeHash(config1);
+        var hash2 = _sut.ComputeHash(config2);
+
+        Assert.Equal(hash1, hash2);
+    }
+
+    [Fact]
+    public void ComputeHash_DifferentContent_DifferentHash()
+    {
+        var config1 = CreateConfig("Instance1", "25.0");
+        var config2 = CreateConfig("Instance1", "50.0");
+
+        var hash1 = _sut.ComputeHash(config1);
+        var hash2 = _sut.ComputeHash(config2);
+
+        Assert.NotEqual(hash1, hash2);
+    }
+
+    [Fact]
+    public void ComputeHash_StartsWithSha256Prefix()
+    {
+        var config = CreateConfig("Instance1", "25.0");
+        var hash = _sut.ComputeHash(config);
+
+        Assert.StartsWith("sha256:", hash);
+    }
+
+    [Fact]
+    public void ComputeHash_DeterministicAcrossRuns()
+    {
+        // Different GeneratedAtUtc should NOT affect the hash (volatile field excluded)
+        var config1 = new FlattenedConfiguration
+        {
+            InstanceUniqueName = "Instance1",
+            TemplateId = 1,
+            SiteId = 1,
+            Attributes = [new ResolvedAttribute { CanonicalName = "A", Value = "1", DataType = "Int32" }],
+            GeneratedAtUtc = new DateTimeOffset(2026, 1, 1, 0, 0, 0, TimeSpan.Zero)
+        };
+        var config2 = new FlattenedConfiguration
+        {
+            InstanceUniqueName = "Instance1",
+            TemplateId = 1,
+            SiteId = 1,
+            Attributes = [new ResolvedAttribute { CanonicalName = "A", Value = "1", DataType = "Int32" }],
+            GeneratedAtUtc = new DateTimeOffset(2026, 6, 15, 12, 0, 0, TimeSpan.Zero)
+        };
+
+        Assert.Equal(_sut.ComputeHash(config1), _sut.ComputeHash(config2));
+    }
+
+    [Fact]
+    public void ComputeHash_NullConfig_ThrowsArgumentNull()
+    {
+        Assert.Throws<ArgumentNullException>(() => _sut.ComputeHash(null!));
+    }
+
+    [Fact]
+    public void ComputeHash_AttributeOrder_DoesNotAffectHash()
+    {
+        var config1 = new FlattenedConfiguration
+        {
+            InstanceUniqueName = "Instance1",
+            TemplateId = 1,
+            SiteId = 1,
+            Attributes =
+            [
+                new ResolvedAttribute { CanonicalName = "A", Value = "1", DataType = "Int32" },
+                new ResolvedAttribute { CanonicalName = "B", Value = "2", DataType = "Int32" }
+            ]
+        };
+        var config2 = new FlattenedConfiguration
+        {
+            InstanceUniqueName = "Instance1",
+            TemplateId = 1,
+            SiteId = 1,
+            Attributes =
+            [
+                new ResolvedAttribute { CanonicalName = "B", Value = "2", DataType = "Int32" },
+                new ResolvedAttribute { CanonicalName = "A", Value = "1", DataType = "Int32" }
+            ]
+        };
+
+        Assert.Equal(_sut.ComputeHash(config1), _sut.ComputeHash(config2));
+    }
+
+    private static FlattenedConfiguration CreateConfig(string instanceName, string tempValue)
+    {
+        return new FlattenedConfiguration
+        {
+            InstanceUniqueName = instanceName,
+            TemplateId = 1,
+            SiteId = 1,
+            Attributes =
+            [
+                new ResolvedAttribute { CanonicalName = "Temperature", Value = tempValue, DataType = "Double" }
+            ]
+        };
+    }
+}