From d4a7344f89ed1cb8e0885b6a42e2e2c555c58a54 Mon Sep 17 00:00:00 2001 From: Joseph Doherty Date: Fri, 22 May 2026 02:03:36 -0400 Subject: [PATCH] docs(centralui): refresh stale test summaries + drop redundant modal-lg --- ...6-05-22-execution-tree-node-modal.md.tasks.json | 12 ++++++------ .../Components/Audit/ExecutionDetailModal.razor | 2 +- .../Audit/AuditLogPageTests.cs | 3 +++ .../Components/Audit/AuditDrilldownDrawerTests.cs | 14 +++++++------- .../Components/Audit/ExecutionTreeTests.cs | 6 ++++-- 5 files changed, 21 insertions(+), 16 deletions(-) diff --git a/docs/plans/2026-05-22-execution-tree-node-modal.md.tasks.json b/docs/plans/2026-05-22-execution-tree-node-modal.md.tasks.json index 2b95ff3..24f0ed3 100644 --- a/docs/plans/2026-05-22-execution-tree-node-modal.md.tasks.json +++ b/docs/plans/2026-05-22-execution-tree-node-modal.md.tasks.json @@ -1,12 +1,12 @@ { "planPath": "docs/plans/2026-05-22-execution-tree-node-modal.md", "tasks": [ - {"id": 0, "subject": "Task 0: Prep — verify branch + baseline", "status": "pending"}, - {"id": 1, "subject": "Task 1: Extract AuditEventDetail from AuditDrilldownDrawer", "status": "pending", "blockedBy": [0]}, - {"id": 2, "subject": "Task 2: ExecutionTree node double-click raises OnNodeActivated", "status": "pending", "blockedBy": [0]}, - {"id": 3, "subject": "Task 3: ExecutionDetailModal component", "status": "pending", "blockedBy": [1]}, - {"id": 4, "subject": "Task 4: Wire ExecutionDetailModal into ExecutionTreePage", "status": "pending", "blockedBy": [2, 3]}, - {"id": 5, "subject": "Task 5: E2E Playwright test + docs", "status": "pending", "blockedBy": [4]} + {"id": 0, "subject": "Task 0: Prep — verify branch + baseline", "status": "completed"}, + {"id": 1, "subject": "Task 1: Extract AuditEventDetail from AuditDrilldownDrawer", "status": "completed", "blockedBy": [0]}, + {"id": 2, "subject": "Task 2: ExecutionTree node double-click raises OnNodeActivated", "status": "completed", "blockedBy": [0]}, + {"id": 3, "subject": "Task 3: ExecutionDetailModal component", "status": "completed", "blockedBy": [1]}, + {"id": 4, "subject": "Task 4: Wire ExecutionDetailModal into ExecutionTreePage", "status": "completed", "blockedBy": [2, 3]}, + {"id": 5, "subject": "Task 5: E2E Playwright test + docs", "status": "completed", "blockedBy": [4]} ], "lastUpdated": "2026-05-22" } diff --git a/src/ScadaLink.CentralUI/Components/Audit/ExecutionDetailModal.razor b/src/ScadaLink.CentralUI/Components/Audit/ExecutionDetailModal.razor index 75909e0..f2005b1 100644 --- a/src/ScadaLink.CentralUI/Components/Audit/ExecutionDetailModal.razor +++ b/src/ScadaLink.CentralUI/Components/Audit/ExecutionDetailModal.razor @@ -16,7 +16,7 @@ data-test="execution-detail-modal" role="dialog" aria-modal="true" aria-labelledby="execution-detail-modal-title" @onkeydown="HandleKeyDown"> -
+
diff --git a/tests/ScadaLink.CentralUI.PlaywrightTests/Audit/AuditLogPageTests.cs b/tests/ScadaLink.CentralUI.PlaywrightTests/Audit/AuditLogPageTests.cs index 7391fbf..2f511bd 100644 --- a/tests/ScadaLink.CentralUI.PlaywrightTests/Audit/AuditLogPageTests.cs +++ b/tests/ScadaLink.CentralUI.PlaywrightTests/Audit/AuditLogPageTests.cs @@ -31,6 +31,9 @@ namespace ScadaLink.CentralUI.PlaywrightTests.Audit; /// drawer's "View parent execution" action on a spawned (child) row drills in /// to ?executionId={ParentExecutionId}, auto-loading the spawner's /// rows. +/// DoubleClickTreeNode_OpensExecutionRowModal — double-clicking a +/// node on the execution-tree page opens ExecutionDetailModal, walking +/// list → row → detail before closing. /// NotificationsPage_HasViewAuditHistoryLink_WhenNotificationsExist — /// the report page wires drill-in links when notifications are present. /// ExportCsv_LinkIsVisibleAndDownloads — Export CSV button gated on diff --git a/tests/ScadaLink.CentralUI.Tests/Components/Audit/AuditDrilldownDrawerTests.cs b/tests/ScadaLink.CentralUI.Tests/Components/Audit/AuditDrilldownDrawerTests.cs index 78608cd..b741d90 100644 --- a/tests/ScadaLink.CentralUI.Tests/Components/Audit/AuditDrilldownDrawerTests.cs +++ b/tests/ScadaLink.CentralUI.Tests/Components/Audit/AuditDrilldownDrawerTests.cs @@ -12,15 +12,15 @@ namespace ScadaLink.CentralUI.Tests.Components.Audit; /// bUnit tests for (#23 M7 Bundle C / M7-T4..T8). /// /// The drawer is a child component opened from the Audit Log page when a grid row -/// is clicked. It renders the full read-only, with -/// channel-aware bodies (JSON pretty-print, SQL block for DbOutbound), -/// redaction badges on Request/Response, and conditional action buttons: -/// "Copy as cURL" (API channels only) + "Show all events for this operation" -/// (when CorrelationId is set). +/// is clicked. It renders the offcanvas chrome (header, open/close) and delegates +/// the body to the shared +/// component, which since the recent refactor owns the channel-aware bodies +/// (JSON pretty-print, SQL block for DbOutbound), redaction badges on +/// Request/Response, and conditional action buttons. /// /// Tests pin the behaviours we cannot lose without breaking the spec: -/// field rendering, JSON pretty-printing, SQL render block, conditional button -/// visibility, navigation drill-back, redaction badges, and clipboard interop. +/// offcanvas open/close, header rendering, and that the event body is handed +/// off to . /// public class AuditDrilldownDrawerTests : BunitContext { diff --git a/tests/ScadaLink.CentralUI.Tests/Components/Audit/ExecutionTreeTests.cs b/tests/ScadaLink.CentralUI.Tests/Components/Audit/ExecutionTreeTests.cs index 88d31a8..cbd1167 100644 --- a/tests/ScadaLink.CentralUI.Tests/Components/Audit/ExecutionTreeTests.cs +++ b/tests/ScadaLink.CentralUI.Tests/Components/Audit/ExecutionTreeTests.cs @@ -11,8 +11,10 @@ namespace ScadaLink.CentralUI.Tests.Components.Audit; /// into a tree by joining to a /// parent node's , and renders it /// recursively. Tests pin: single-node tree, multi-level assembly, stub-node -/// presentation, the arrived-from highlight, node-click navigation, and -/// cycle-safety (a corrupt flat list must not infinite-loop). +/// presentation, the arrived-from highlight, node-click navigation, node +/// double-click raising/bubbling via +/// OnNodeActivated, and cycle-safety (a corrupt flat list must not +/// infinite-loop). /// public class ExecutionTreeTests : BunitContext {