feat(ui): SMTP config form TlsMode field

Add a TlsMode read-only row and a None/StartTLS/SSL select to the SMTP Configuration page edit form. New configs default to None; edits load and persist the chosen mode through the repository.
2026-05-21 02:13:02 -04:00
parent 399b4aac92
commit c66ef71017
2 changed files with 128 additions and 1 deletions
--- a/tests/ScadaLink.CentralUI.Tests/Pages/SmtpConfigurationPageTests.cs
+++ b/tests/ScadaLink.CentralUI.Tests/Pages/SmtpConfigurationPageTests.cs
@@ -0,0 +1,112 @@
+using System.Security.Claims;
+using Bunit;
+using Microsoft.AspNetCore.Components.Authorization;
+using Microsoft.Extensions.DependencyInjection;
+using NSubstitute;
+using ScadaLink.Commons.Entities.Notifications;
+using ScadaLink.Commons.Interfaces.Repositories;
+using SmtpConfigurationPage = ScadaLink.CentralUI.Components.Pages.Notifications.SmtpConfiguration;
+
+namespace ScadaLink.CentralUI.Tests.Pages;
+
+/// <summary>
+/// bUnit rendering tests for the SMTP Configuration page — specifically the TlsMode
+/// field added so the UI exposes all five user-relevant SmtpConfiguration fields.
+/// </summary>
+public class SmtpConfigurationPageTests : BunitContext
+{
+    private void WireAuth()
+    {
+        var claims = new[]
+        {
+            new Claim("Username", "tester"),
+            new Claim(ClaimTypes.Role, "Admin"),
+        };
+        var user = new ClaimsPrincipal(new ClaimsIdentity(claims, "TestAuth"));
+        Services.AddSingleton<AuthenticationStateProvider>(new TestAuthStateProvider(user));
+        Services.AddAuthorizationCore();
+    }
+
+    private static SmtpConfiguration Sample() =>
+        new("smtp.example.com", "Basic", "noreply@example.com")
+        {
+            Id = 1,
+            Port = 587,
+            TlsMode = "StartTLS",
+            Credentials = "user:pass",
+        };
+
+    [Fact]
+    public void EditForm_RendersTlsModeSelectWithAllThreeModes()
+    {
+        var repo = Substitute.For<INotificationRepository>();
+        repo.GetAllSmtpConfigurationsAsync()
+            .Returns(Task.FromResult<IReadOnlyList<SmtpConfiguration>>(
+                new List<SmtpConfiguration> { Sample() }));
+        Services.AddSingleton(repo);
+        WireAuth();
+
+        var cut = Render<SmtpConfigurationPage>();
+        cut.WaitForState(() => cut.Markup.Contains("smtp.example.com"));
+
+        cut.FindAll("button").First(b => b.TextContent.Contains("Edit")).Click();
+
+        cut.WaitForAssertion(() =>
+        {
+            var selects = cut.FindAll("select");
+            var tlsSelect = selects.Single(s => s.QuerySelectorAll("option")
+                .Any(o => o.TextContent == "StartTLS"));
+            var modes = tlsSelect.QuerySelectorAll("option").Select(o => o.TextContent).ToList();
+            Assert.Equal(new[] { "None", "StartTLS", "SSL" }, modes);
+        });
+    }
+
+    [Fact]
+    public void ReadOnlyView_ShowsTlsMode()
+    {
+        var repo = Substitute.For<INotificationRepository>();
+        repo.GetAllSmtpConfigurationsAsync()
+            .Returns(Task.FromResult<IReadOnlyList<SmtpConfiguration>>(
+                new List<SmtpConfiguration> { Sample() }));
+        Services.AddSingleton(repo);
+        WireAuth();
+
+        var cut = Render<SmtpConfigurationPage>();
+
+        cut.WaitForAssertion(() =>
+        {
+            Assert.Contains("TLS Mode", cut.Markup);
+            Assert.Contains("StartTLS", cut.Markup);
+        });
+    }
+
+    [Fact]
+    public void SavingEdit_PersistsChosenTlsMode()
+    {
+        var config = Sample();
+        var repo = Substitute.For<INotificationRepository>();
+        repo.GetAllSmtpConfigurationsAsync()
+            .Returns(Task.FromResult<IReadOnlyList<SmtpConfiguration>>(
+                new List<SmtpConfiguration> { config }));
+        Services.AddSingleton(repo);
+        WireAuth();
+
+        var cut = Render<SmtpConfigurationPage>();
+        cut.WaitForState(() => cut.Markup.Contains("smtp.example.com"));
+
+        cut.FindAll("button").First(b => b.TextContent.Contains("Edit")).Click();
+
+        var tlsSelect = cut.FindAll("select")
+            .Single(s => s.QuerySelectorAll("option").Any(o => o.TextContent == "StartTLS"));
+        tlsSelect.Change("SSL");
+
+        cut.FindAll("button").First(b => b.TextContent.Contains("Save")).Click();
+
+        cut.WaitForAssertion(() =>
+        {
+            repo.Received().UpdateSmtpConfigurationAsync(
+                Arg.Is<SmtpConfiguration>(c => c.TlsMode == "SSL"));
+            repo.Received().SaveChangesAsync();
+        });
+    }
+}