From a5653b4296749d81cc4138566dc171a9c61f8f41 Mon Sep 17 00:00:00 2001 From: Joseph Doherty Date: Tue, 19 May 2026 03:49:54 -0400 Subject: [PATCH] refactor(notification-outbox): drop unused state from sandbox Notify fakes --- .../ScriptAnalysis/SandboxHostHelpers.cs | 16 ++-------------- .../ScriptAnalysis/SandboxScriptHost.cs | 2 +- .../ScriptAnalysis/ScriptAnalysisService.cs | 2 +- 3 files changed, 4 insertions(+), 16 deletions(-) diff --git a/src/ScadaLink.CentralUI/ScriptAnalysis/SandboxHostHelpers.cs b/src/ScadaLink.CentralUI/ScriptAnalysis/SandboxHostHelpers.cs index 0ba317e..7e9231a 100644 --- a/src/ScadaLink.CentralUI/ScriptAnalysis/SandboxHostHelpers.cs +++ b/src/ScadaLink.CentralUI/ScriptAnalysis/SandboxHostHelpers.cs @@ -96,16 +96,9 @@ public class SandboxDatabaseHelper /// public class SandboxNotifyHelper { - private readonly string _instanceName; - - public SandboxNotifyHelper(string instanceName) - { - _instanceName = instanceName; - } - /// Selects the notification list to send to. public SandboxNotifyTarget To(string listName) => - new(listName, _instanceName); + new(); /// /// Queries the delivery status of a previously-sent notification. The @@ -123,13 +116,8 @@ public class SandboxNotifyHelper /// public class SandboxNotifyTarget { - private readonly string _listName; - private readonly string _instanceName; - - internal SandboxNotifyTarget(string listName, string instanceName) + internal SandboxNotifyTarget() { - _listName = listName; - _instanceName = instanceName; } /// diff --git a/src/ScadaLink.CentralUI/ScriptAnalysis/SandboxScriptHost.cs b/src/ScadaLink.CentralUI/ScriptAnalysis/SandboxScriptHost.cs index d4027c4..a4a7710 100644 --- a/src/ScadaLink.CentralUI/ScriptAnalysis/SandboxScriptHost.cs +++ b/src/ScadaLink.CentralUI/ScriptAnalysis/SandboxScriptHost.cs @@ -80,7 +80,7 @@ public class SandboxInstanceContext _gateway = gateway; ExternalSystem = external ?? new SandboxExternalHelper(null, ""); Database = database ?? new SandboxDatabaseHelper(null, ""); - Notify = notify ?? new SandboxNotifyHelper(""); + Notify = notify ?? new SandboxNotifyHelper(); Scripts = scripts ?? new SandboxScriptCallHelper(null); } diff --git a/src/ScadaLink.CentralUI/ScriptAnalysis/ScriptAnalysisService.cs b/src/ScadaLink.CentralUI/ScriptAnalysis/ScriptAnalysisService.cs index a046ec6..cd7dd74 100644 --- a/src/ScadaLink.CentralUI/ScriptAnalysis/ScriptAnalysisService.cs +++ b/src/ScadaLink.CentralUI/ScriptAnalysis/ScriptAnalysisService.cs @@ -276,7 +276,7 @@ public class ScriptAnalysisService // mirrors production signatures so scripts compile identically, but it // does not deliver (production now enqueues into the site S&F engine, // which has no central-side equivalent here). - var notify = new SandboxNotifyHelper(instanceLabel); + var notify = new SandboxNotifyHelper(); var compileCache = new Dictionary>(StringComparer.Ordinal); var compileCacheLock = new object();