From 9916aeaa4704fac710539bb9a90cef54996bcd99 Mon Sep 17 00:00:00 2001
From: Joseph Doherty <dohejw01@gmail.com>
Date: Tue, 12 May 2026 01:11:49 -0400
Subject: [PATCH] refactor(ui/admin): DataConnectionForm uses
 OpcUaEndpointEditor and typed model

---
 .../Pages/Admin/DataConnectionForm.razor      | 117 ++++++++++--------
 1 file changed, 66 insertions(+), 51 deletions(-)

diff --git a/src/ScadaLink.CentralUI/Components/Pages/Admin/DataConnectionForm.razor b/src/ScadaLink.CentralUI/Components/Pages/Admin/DataConnectionForm.razor
index 41b873d..20a20d7 100644
--- a/src/ScadaLink.CentralUI/Components/Pages/Admin/DataConnectionForm.razor
+++ b/src/ScadaLink.CentralUI/Components/Pages/Admin/DataConnectionForm.razor
@@ -5,6 +5,11 @@
 @using ScadaLink.Security
 @using ScadaLink.Commons.Entities.Sites
 @using ScadaLink.Commons.Interfaces.Repositories
+@using ScadaLink.Commons.Types.DataConnections
+@using ScadaLink.Commons.Types.Flattening
+@using ScadaLink.Commons.Serialization
+@using ScadaLink.Commons.Validators
+@using ScadaLink.CentralUI.Components.Forms
 @attribute [Authorize(Policy = AuthorizationPolicies.RequireAdmin)]
 @inject ISiteRepository SiteRepository
 @inject NavigationManager NavigationManager
@@ -27,7 +32,9 @@
                     <label class="form-label small">Site</label>
                     @if (_siteLocked)
                     {
-                        <input type="text" class="form-control form-control-sm" value="@_siteName" disabled />
+                        <select class="form-select form-select-sm" disabled>
+                            <option>@_siteName</option>
+                        </select>
                     }
                     else
                     {
@@ -40,56 +47,41 @@
                         </select>
                     }
                 </div>
-                <div class="mb-2">
+                <div class="mb-3">
                     <label class="form-label small">Name</label>
                     <input type="text" class="form-control form-control-sm" @bind="_formName" />
                 </div>
-                <div class="mb-3">
-                    <label class="form-label small">Protocol</label>
-                    <select class="form-select form-select-sm" @bind="_formProtocol">
-                        <option value="">Select...</option>
-                        <option value="OpcUa">OPC UA</option>
-                        <option value="Custom">Custom</option>
-                    </select>
-                </div>
 
-                <h6 class="text-muted border-bottom pb-1">Primary Endpoint</h6>
-                <div class="mb-3">
-                    <label class="form-label small">Configuration</label>
-                    <input type="text" class="form-control form-control-sm" @bind="_formConfiguration"
-                           placeholder='e.g. {"endpoint":"opc.tcp://..."}' />
-                </div>
+                <OpcUaEndpointEditor Title="Primary Endpoint"
+                                     IdPrefix="primary"
+                                     Config="_primaryConfig"
+                                     IsLegacy="_primaryIsLegacy"
+                                     Errors="_primaryErrors" />
 
-                <h6 class="text-muted border-bottom pb-1">Backup Endpoint</h6>
+                <h6 class="text-muted border-bottom pb-1 mt-3">Backup Endpoint</h6>
                 @if (!_showBackup)
                 {
                     <div class="mb-3">
                         <button type="button" class="btn btn-outline-secondary btn-sm"
-                                @onclick="() => _showBackup = true">
-                            Add Backup Endpoint
-                        </button>
+                                @onclick="EnableBackup">Add Backup Endpoint</button>
                     </div>
                 }
                 else
                 {
-                    <div class="mb-2">
-                        <label class="form-label small">Configuration</label>
-                        <textarea class="form-control form-control-sm" rows="4"
-                                  @bind="_formBackupConfiguration"
-                                  placeholder='{"Host": "backup-host", "Port": 50101}' />
-                    </div>
+                    <OpcUaEndpointEditor Title="Backup Endpoint"
+                                         IdPrefix="backup"
+                                         Config="_backupConfig"
+                                         IsLegacy="_backupIsLegacy"
+                                         Errors="_backupErrors" />
                     <div class="mb-2">
                         <label class="form-label small">Failover Retry Count</label>
                         <input type="number" class="form-control form-control-sm" style="max-width: 120px;"
-                               min="1" max="20"
-                               @bind="_formFailoverRetryCount" />
+                               min="1" max="20" @bind="_formFailoverRetryCount" />
                         <div class="form-text">Retries on active endpoint before switching to backup (default: 3)</div>
                     </div>
                     <div class="mb-3">
                         <button type="button" class="btn btn-outline-danger btn-sm"
-                                @onclick="RemoveBackup">
-                            Remove Backup
-                        </button>
+                                @onclick="RemoveBackup">Remove Backup</button>
                     </div>
                 }
 
@@ -117,11 +109,14 @@
     private string _siteName = string.Empty;
     private bool _siteLocked;
     private string _formName = string.Empty;
-    private string _formProtocol = string.Empty;
-    private string? _formConfiguration;
+    private OpcUaEndpointConfig _primaryConfig = new();
+    private OpcUaEndpointConfig _backupConfig = new();
+    private bool _primaryIsLegacy;
+    private bool _backupIsLegacy;
     private bool _showBackup;
-    private string? _formBackupConfiguration;
     private int _formFailoverRetryCount = 3;
+    private ValidationResult? _primaryErrors;
+    private ValidationResult? _backupErrors;
     private string? _formError;
 
     protected override async Task OnInitializedAsync()
@@ -139,11 +134,17 @@
                     _siteName = _sites.FirstOrDefault(s => s.Id == _formSiteId)?.Name ?? $"Site {_formSiteId}";
                     _siteLocked = true;
                     _formName = _editingConnection.Name;
-                    _formProtocol = _editingConnection.Protocol;
-                    _formConfiguration = _editingConnection.PrimaryConfiguration;
-                    _formBackupConfiguration = _editingConnection.BackupConfiguration;
-                    _formFailoverRetryCount = _editingConnection.FailoverRetryCount;
-                    _showBackup = _editingConnection.BackupConfiguration != null;
+
+                    (_primaryConfig, _primaryIsLegacy) =
+                        OpcUaEndpointConfigSerializer.Deserialize(_editingConnection.PrimaryConfiguration);
+
+                    if (!string.IsNullOrWhiteSpace(_editingConnection.BackupConfiguration))
+                    {
+                        (_backupConfig, _backupIsLegacy) =
+                            OpcUaEndpointConfigSerializer.Deserialize(_editingConnection.BackupConfiguration);
+                        _showBackup = true;
+                        _formFailoverRetryCount = _editingConnection.FailoverRetryCount;
+                    }
                 }
             }
             catch (Exception ex)
@@ -161,6 +162,7 @@
                 _siteLocked = true;
             }
         }
+
         _loading = false;
     }
 
@@ -169,25 +171,38 @@
         _formError = null;
         if (_formSiteId == 0) { _formError = "Site is required."; return; }
         if (string.IsNullOrWhiteSpace(_formName)) { _formError = "Name is required."; return; }
-        if (string.IsNullOrWhiteSpace(_formProtocol)) { _formError = "Protocol is required."; return; }
+
+        _primaryErrors = OpcUaEndpointConfigValidator.Validate(_primaryConfig, "Primary.");
+        _backupErrors = _showBackup
+            ? OpcUaEndpointConfigValidator.Validate(_backupConfig, "Backup.")
+            : null;
+
+        if (!_primaryErrors.IsValid || (_backupErrors is { IsValid: false }))
+        {
+            _formError = "Fix the errors below before saving.";
+            return;
+        }
+
+        var primaryJson = OpcUaEndpointConfigSerializer.Serialize(_primaryConfig);
+        var backupJson = _showBackup ? OpcUaEndpointConfigSerializer.Serialize(_backupConfig) : null;
 
         try
         {
             if (_editingConnection != null)
             {
                 _editingConnection.Name = _formName.Trim();
-                _editingConnection.Protocol = _formProtocol;
-                _editingConnection.PrimaryConfiguration = _formConfiguration?.Trim();
-                _editingConnection.BackupConfiguration = _showBackup ? _formBackupConfiguration?.Trim() : null;
+                _editingConnection.Protocol = "OpcUa";
+                _editingConnection.PrimaryConfiguration = primaryJson;
+                _editingConnection.BackupConfiguration = backupJson;
                 _editingConnection.FailoverRetryCount = _showBackup ? _formFailoverRetryCount : 3;
                 await SiteRepository.UpdateDataConnectionAsync(_editingConnection);
             }
             else
             {
-                var conn = new DataConnection(_formName.Trim(), _formProtocol, _formSiteId)
+                var conn = new DataConnection(_formName.Trim(), "OpcUa", _formSiteId)
                 {
-                    PrimaryConfiguration = _formConfiguration?.Trim(),
-                    BackupConfiguration = _showBackup ? _formBackupConfiguration?.Trim() : null,
+                    PrimaryConfiguration = primaryJson,
+                    BackupConfiguration = backupJson,
                     FailoverRetryCount = _showBackup ? _formFailoverRetryCount : 3
                 };
                 await SiteRepository.AddDataConnectionAsync(conn);
@@ -201,15 +216,15 @@
         }
     }
 
+    private void EnableBackup() => _showBackup = true;
+
     private void RemoveBackup()
     {
         _showBackup = false;
-        _formBackupConfiguration = null;
+        _backupConfig = new OpcUaEndpointConfig();
+        _backupIsLegacy = false;
         _formFailoverRetryCount = 3;
     }
 
-    private void GoBack()
-    {
-        NavigationManager.NavigateTo("/admin/connections");
-    }
+    private void GoBack() => NavigationManager.NavigateTo("/admin/connections");
 }