dohertj2/scadalink-design
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

test(auditlog): cover ExecutionId in AuditEvent round-trip test; clarify staging-table comment

Browse Source
This commit is contained in:
Joseph Doherty
2026-05-21 14:48:39 -04:00
parent fd12021984
commit 990731d12f
2 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/ScadaLink.ConfigurationDatabase/Repositories/AuditLogRepository.cs
View File

@@ -268,6 +268,9 @@ VALUES
PayloadTruncated bit NOT NULL, PayloadTruncated bit NOT NULL,
Extra nvarchar(max) NULL, Extra nvarchar(max) NULL,
ForwardState varchar(32) NULL, ForwardState varchar(32) NULL,
-- ExecutionId is last because it was added to the live AuditLog table by a later
-- ALTER TABLE ADD migration; the staging table must match the live table column
-- shape ordinal-for-ordinal or ALTER TABLE ... SWITCH PARTITION fails.
ExecutionId uniqueidentifier NULL, ExecutionId uniqueidentifier NULL,
CONSTRAINT PK_{stagingTableName} PRIMARY KEY CLUSTERED (EventId, OccurredAtUtc) CONSTRAINT PK_{stagingTableName} PRIMARY KEY CLUSTERED (EventId, OccurredAtUtc)
) ON [PRIMARY]; ) ON [PRIMARY];

5
tests/ScadaLink.Commons.Tests/Entities/Audit/AuditEventTests.cs
View File

@@ -17,6 +17,7 @@ public class AuditEventTests
var occurredAt = new DateTime(2026, 5, 20, 12, 0, 0, DateTimeKind.Utc); var occurredAt = new DateTime(2026, 5, 20, 12, 0, 0, DateTimeKind.Utc);
var ingestedAt = new DateTime(2026, 5, 20, 12, 0, 1, DateTimeKind.Utc); var ingestedAt = new DateTime(2026, 5, 20, 12, 0, 1, DateTimeKind.Utc);
var corrId = Guid.NewGuid(); var corrId = Guid.NewGuid();
var execId = Guid.NewGuid();
var evt = new AuditEvent var evt = new AuditEvent
{ {
@@ -26,6 +27,7 @@ public class AuditEventTests
Channel = AuditChannel.ApiOutbound, Channel = AuditChannel.ApiOutbound,
Kind = AuditKind.ApiCall, Kind = AuditKind.ApiCall,
CorrelationId = corrId, CorrelationId = corrId,
ExecutionId = execId,
SourceSiteId = "site-01", SourceSiteId = "site-01",
SourceInstanceId = "inst-7", SourceInstanceId = "inst-7",
SourceScript = "OnAlarm", SourceScript = "OnAlarm",
@@ -49,6 +51,7 @@ public class AuditEventTests
Assert.Equal(AuditChannel.ApiOutbound, evt.Channel); Assert.Equal(AuditChannel.ApiOutbound, evt.Channel);
Assert.Equal(AuditKind.ApiCall, evt.Kind); Assert.Equal(AuditKind.ApiCall, evt.Kind);
Assert.Equal(corrId, evt.CorrelationId); Assert.Equal(corrId, evt.CorrelationId);
Assert.Equal(execId, evt.ExecutionId);
Assert.Equal("site-01", evt.SourceSiteId); Assert.Equal("site-01", evt.SourceSiteId);
Assert.Equal("inst-7", evt.SourceInstanceId); Assert.Equal("inst-7", evt.SourceInstanceId);
Assert.Equal("OnAlarm", evt.SourceScript); Assert.Equal("OnAlarm", evt.SourceScript);
@@ -77,6 +80,7 @@ public class AuditEventTests
Channel = AuditChannel.Notification, Channel = AuditChannel.Notification,
Kind = AuditKind.NotifySend, Kind = AuditKind.NotifySend,
CorrelationId = null, CorrelationId = null,
ExecutionId = null,
SourceSiteId = null, SourceSiteId = null,
SourceInstanceId = null, SourceInstanceId = null,
SourceScript = null, SourceScript = null,
@@ -96,6 +100,7 @@ public class AuditEventTests
Assert.Null(evt.IngestedAtUtc); Assert.Null(evt.IngestedAtUtc);
Assert.Null(evt.CorrelationId); Assert.Null(evt.CorrelationId);
Assert.Null(evt.ExecutionId);
Assert.Null(evt.SourceSiteId); Assert.Null(evt.SourceSiteId);
Assert.Null(evt.SourceInstanceId); Assert.Null(evt.SourceInstanceId);
Assert.Null(evt.SourceScript); Assert.Null(evt.SourceScript);