dohertj2/scadalink-design
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

feat(notification-outbox): add Type field to NotificationList

Browse Source
This commit is contained in:
Joseph Doherty
2026-05-19 00:52:23 -04:00
parent ed7fddb0b5
commit 87ac9b8a4d
3 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/ScadaLink.Commons/Entities/Notifications/NotificationList.cs
View File

@@ -1,9 +1,12 @@
using ScadaLink.Commons.Types.Enums;
namespace ScadaLink.Commons.Entities.Notifications; namespace ScadaLink.Commons.Entities.Notifications;
public class NotificationList public class NotificationList
{ {
public int Id { get; set; } public int Id { get; set; }
public string Name { get; set; } public string Name { get; set; }
public NotificationType Type { get; set; } = NotificationType.Email;
public ICollection<NotificationRecipient> Recipients { get; set; } = new List<NotificationRecipient>(); public ICollection<NotificationRecipient> Recipients { get; set; } = new List<NotificationRecipient>();
public NotificationList(string name) public NotificationList(string name)

5
src/ScadaLink.ConfigurationDatabase/Configurations/NotificationConfiguration.cs
View File

@@ -14,6 +14,11 @@ public class NotificationListConfiguration : IEntityTypeConfiguration<Notificati
.IsRequired() .IsRequired()
.HasMaxLength(200); .HasMaxLength(200);
builder.Property(n => n.Type)
.HasConversion<string>()
.HasMaxLength(32)
.IsRequired();
builder.HasMany(n => n.Recipients) builder.HasMany(n => n.Recipients)
.WithOne() .WithOne()
.HasForeignKey(r => r.NotificationListId) .HasForeignKey(r => r.NotificationListId)

12
tests/ScadaLink.ConfigurationDatabase.Tests/RepositoryCoverageTests.cs
View File

@@ -5,6 +5,7 @@ using ScadaLink.Commons.Entities.Instances;
using ScadaLink.Commons.Entities.Notifications; using ScadaLink.Commons.Entities.Notifications;
using ScadaLink.Commons.Entities.Sites; using ScadaLink.Commons.Entities.Sites;
using ScadaLink.Commons.Entities.Templates; using ScadaLink.Commons.Entities.Templates;
using ScadaLink.Commons.Types.Enums;
using ScadaLink.ConfigurationDatabase; using ScadaLink.ConfigurationDatabase;
using ScadaLink.ConfigurationDatabase.Repositories; using ScadaLink.ConfigurationDatabase.Repositories;
using ScadaLink.ConfigurationDatabase.Services; using ScadaLink.ConfigurationDatabase.Services;
@@ -224,6 +225,17 @@ public class NotificationRepositoryTests : IDisposable
Assert.Null(await _repository.GetNotificationListByIdAsync(list.Id)); Assert.Null(await _repository.GetNotificationListByIdAsync(list.Id));
} }
[Fact]
public async Task NotificationList_PersistsType()
{
var list = new NotificationList("ops") { Type = NotificationType.Email };
await _repository.AddNotificationListAsync(list);
await _repository.SaveChangesAsync();
_context.ChangeTracker.Clear();
var loaded = await _repository.GetListByNameAsync("ops");
Assert.Equal(NotificationType.Email, loaded!.Type);
}
[Fact] [Fact]
public void Constructor_NullContext_Throws() public void Constructor_NullContext_Throws()
{ {