dohertj2/scadalink-design
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

refactor(auditlog): remove dead-code ternary in CachedCallLifecycleBridge (#23 M3 final-review fix)

Browse Source
This commit is contained in:
Joseph Doherty
2026-05-20 15:39:10 -04:00
parent c3d4e6b1e0
commit 73a19c6f02
1 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/ScadaLink.AuditLog/Site/Telemetry/CachedCallLifecycleBridge.cs
View File

@@ -75,16 +75,13 @@ public sealed class CachedCallLifecycleBridge : ICachedCallLifecycleObserver
private async Task EmitAttemptedAsync(CachedCallAttemptContext context, CancellationToken ct) private async Task EmitAttemptedAsync(CachedCallAttemptContext context, CancellationToken ct)
{ {
// Per-attempt row: kind discriminates channel, status carries the // Per-attempt row: kind discriminates channel; status is always
// per-attempt result. // Attempted regardless of outcome (success vs. failure is captured
// by the companion HttpStatus / ErrorMessage fields, NOT by flipping
// the status — CachedResolve carries the terminal Status). Per the
// M3 brief and alog.md §4.
var kind = ChannelToAttemptKind(context.Channel); var kind = ChannelToAttemptKind(context.Channel);
var status = context.Outcome == CachedCallAttemptOutcome.Delivered var status = AuditStatus.Attempted;
? AuditStatus.Attempted
: AuditStatus.Attempted;
// (Note: per the M3 brief and alog.md §4 the per-attempt row always
// carries Status=Attempted; success vs. failure is captured by the
// companion HttpStatus / ErrorMessage fields, NOT by flipping the
// status. CachedResolve carries the terminal Status.)
var packet = BuildPacket( var packet = BuildPacket(
context, context,