fix(central-ui): resolve CentralUI-007..014 — nav authz, UTC date filters, disposal guards, N+1 fix, async script analysis

tests/ScadaLink.CentralUI.Tests/Admin/SitesPageTests.cs

@@ -0,0 +1,105 @@
+using System.Security.Claims;
+using Bunit;
+using Microsoft.AspNetCore.Components.Authorization;
+using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.Logging.Abstractions;
+using Microsoft.Extensions.Options;
+using NSubstitute;
+using ScadaLink.CentralUI.Components.Shared;
+using ScadaLink.Commons.Entities.Sites;
+using ScadaLink.Commons.Interfaces.Repositories;
+using ScadaLink.Commons.Interfaces.Services;
+using ScadaLink.Communication;
+using ScadaLink.DeploymentManager;
+using SitesPage = ScadaLink.CentralUI.Components.Pages.Admin.Sites;
+
+namespace ScadaLink.CentralUI.Tests.Admin;
+
+/// <summary>
+/// Regression tests for CentralUI-012. The Sites page loaded all sites and then
+/// issued <c>GetDataConnectionsBySiteIdAsync</c> once per site (N+1 database
+/// round-trips on every load and post-delete refresh). The fix fetches all
+/// data connections in a single <c>GetAllDataConnectionsAsync</c> call and
+/// groups them client-side.
+/// </summary>
+public class SitesPageTests : BunitContext
+{
+    private readonly ISiteRepository _siteRepo = Substitute.For<ISiteRepository>();
+
+    private void RegisterServices()
+    {
+        Services.AddSingleton(_siteRepo);
+
+        var comms = new CommunicationService(
+            Options.Create(new CommunicationOptions()),
+            NullLogger<CommunicationService>.Instance);
+        Services.AddSingleton(comms);
+
+        var artifactSvc = new ArtifactDeploymentService(
+            _siteRepo,
+            Substitute.For<IDeploymentManagerRepository>(),
+            Substitute.For<ITemplateEngineRepository>(),
+            Substitute.For<IExternalSystemRepository>(),
+            Substitute.For<INotificationRepository>(),
+            comms,
+            Substitute.For<IAuditService>(),
+            Options.Create(new DeploymentManagerOptions()),
+            NullLogger<ArtifactDeploymentService>.Instance);
+        Services.AddSingleton(artifactSvc);
+
+        Services.AddSingleton<IDialogService>(Substitute.For<IDialogService>());
+
+        var identity = new ClaimsIdentity(
+            new[] { new Claim(ClaimTypes.Name, "admin") }, "TestCookie");
+        var authState = new AuthenticationState(new ClaimsPrincipal(identity));
+        Services.AddSingleton<AuthenticationStateProvider>(
+            new StubAuthStateProvider(authState));
+    }
+
+    private sealed class StubAuthStateProvider : AuthenticationStateProvider
+    {
+        private readonly AuthenticationState _state;
+        public StubAuthStateProvider(AuthenticationState state) => _state = state;
+        public override Task<AuthenticationState> GetAuthenticationStateAsync()
+            => Task.FromResult(_state);
+    }
+
+    private static List<Site> Sites(params int[] ids)
+        => ids.Select(id => new Site($"Site{id}", $"SITE-{id}") { Id = id }).ToList();
+
+    private static DataConnection Conn(int siteId, string name)
+        => new(name, "OpcUa", siteId);
+
+    [Fact]
+    public void LoadData_FetchesAllConnectionsInOneQuery_NoPerSiteQueries()
+    {
+        RegisterServices();
+        _siteRepo.GetAllSitesAsync().Returns(Sites(1, 2, 3));
+        _siteRepo.GetAllDataConnectionsAsync().Returns(new List<DataConnection>
+        {
+            Conn(1, "c1"), Conn(2, "c2"), Conn(3, "c3"),
+        });
+
+        Render<SitesPage>();
+
+        // Regression: exactly one bulk query, and zero per-site queries.
+        _siteRepo.Received(1).GetAllDataConnectionsAsync();
+        _siteRepo.DidNotReceive().GetDataConnectionsBySiteIdAsync(Arg.Any<int>());
+    }
+
+    [Fact]
+    public void LoadData_GroupsConnectionsBySite_AndRendersThem()
+    {
+        RegisterServices();
+        _siteRepo.GetAllSitesAsync().Returns(Sites(1, 2));
+        _siteRepo.GetAllDataConnectionsAsync().Returns(new List<DataConnection>
+        {
+            Conn(1, "alpha-conn"), Conn(2, "beta-conn"),
+        });
+
+        var cut = Render<SitesPage>();
+
+        Assert.Contains("alpha-conn", cut.Markup);
+        Assert.Contains("beta-conn", cut.Markup);
+    }
+}