feat(auditlog): thread ExecutionId through S&F for retry-loop cached rows

The store-and-forward retry loop emits the per-attempt and terminal cached
audit rows (ApiCallCached/DbWriteCached Attempted, CachedResolve) via
CachedCallLifecycleBridge from a CachedCallAttemptContext, not from the
script context. ExecutionId (and SourceScript) were not threaded through the
S&F buffer, so those rows had ExecutionId = null and SourceScript = null.

Thread both, additively, from the cached-call enqueue path:

- StoreAndForwardMessage gains ExecutionId (Guid?) / SourceScript (string?).
- StoreAndForwardStorage adds nullable execution_id / source_script columns
  via an idempotent PRAGMA-probed ALTER TABLE migration; rows persisted by
  an older build read back null (back-compat).
- StoreAndForwardService.EnqueueAsync gains optional executionId /
  sourceScript params, stamped onto the buffered message and surfaced on the
  CachedCallAttemptContext built in the retry loop.
- CachedCallAttemptContext gains ExecutionId / SourceScript.
- CachedCallLifecycleBridge.BuildPacket sets AuditEvent.ExecutionId and
  AuditEvent.SourceScript from the context (replacing the hard-coded
  SourceScript = null and its now-stale comment).
- IExternalSystemClient.CachedCallAsync / IDatabaseGateway.CachedWriteAsync
  gain optional executionId / sourceScript params; ScriptRuntimeContext's
  CachedCall / CachedWrite helpers pass _executionId / _sourceScript.

Script-side cached rows (CachedSubmit, immediate Attempted+Resolve) are
unchanged. All threading is additive — old buffered S&F rows still
deserialize and process with the new fields null.
This commit is contained in:
Joseph Doherty
2026-05-21 15:18:35 -04:00
parent 0149ce6180
commit 6f5a35f222
15 changed files with 505 additions and 40 deletions

View File

@@ -133,9 +133,17 @@ public sealed class CachedCallLifecycleBridge : ICachedCallLifecycleObserver
Channel = channel, Channel = channel,
Kind = kind, Kind = kind,
CorrelationId = context.TrackedOperationId.Value, CorrelationId = context.TrackedOperationId.Value,
// Audit Log #23 (ExecutionId Task 4): the originating script
// execution's per-run correlation id, threaded through the S&F
// buffer; null on rows buffered before Task 4 (back-compat).
ExecutionId = context.ExecutionId,
SourceSiteId = string.IsNullOrEmpty(context.SourceSite) ? null : context.SourceSite, SourceSiteId = string.IsNullOrEmpty(context.SourceSite) ? null : context.SourceSite,
SourceInstanceId = context.SourceInstanceId, SourceInstanceId = context.SourceInstanceId,
SourceScript = null, // Not threaded through S&F; left null on retry-loop rows. // Audit Log #23 (ExecutionId Task 4): SourceScript is now
// threaded through the S&F buffer alongside ExecutionId — the
// retry-loop cached rows carry the same provenance the
// script-side cached rows do. Null on pre-Task-4 buffered rows.
SourceScript = context.SourceScript,
Target = context.Target, Target = context.Target,
Status = status, Status = status,
HttpStatus = httpStatus, HttpStatus = httpStatus,

View File

@@ -57,6 +57,20 @@ public interface ICachedCallLifecycleObserver
/// <param name="OccurredAtUtc">When this attempt completed.</param> /// <param name="OccurredAtUtc">When this attempt completed.</param>
/// <param name="DurationMs">Duration of the attempt in milliseconds (null when not measured).</param> /// <param name="DurationMs">Duration of the attempt in milliseconds (null when not measured).</param>
/// <param name="SourceInstanceId">Originating instance, when known.</param> /// <param name="SourceInstanceId">Originating instance, when known.</param>
/// <param name="ExecutionId">
/// Audit Log #23 (ExecutionId Task 4): the originating script execution's
/// per-run correlation id, threaded through the store-and-forward buffer from
/// the cached-call enqueue path. The audit bridge stamps it onto the
/// retry-loop <c>ApiCallCached</c>/<c>DbWriteCached</c> Attempted and
/// <c>CachedResolve</c> rows so they correlate with the rest of the run.
/// <c>null</c> for rows buffered before Task 4 (back-compat).
/// </param>
/// <param name="SourceScript">
/// Audit Log #23 (ExecutionId Task 4): the originating script identifier,
/// threaded alongside <paramref name="ExecutionId"/> so the retry-loop audit
/// rows carry the same <c>SourceScript</c> provenance the script-side cached
/// rows already do. <c>null</c> when not known.
/// </param>
public sealed record CachedCallAttemptContext( public sealed record CachedCallAttemptContext(
TrackedOperationId TrackedOperationId, TrackedOperationId TrackedOperationId,
string Channel, string Channel,
@@ -69,7 +83,9 @@ public sealed record CachedCallAttemptContext(
DateTime CreatedAtUtc, DateTime CreatedAtUtc,
DateTime OccurredAtUtc, DateTime OccurredAtUtc,
int? DurationMs, int? DurationMs,
string? SourceInstanceId); string? SourceInstanceId,
Guid? ExecutionId = null,
string? SourceScript = null);
/// <summary> /// <summary>
/// Coarse outcome of one cached-call delivery attempt, observed from inside /// Coarse outcome of one cached-call delivery attempt, observed from inside

View File

@@ -29,11 +29,24 @@ public interface IDatabaseGateway
/// <c>null</c> — when omitted the S&amp;F engine mints a fresh GUID and no /// <c>null</c> — when omitted the S&amp;F engine mints a fresh GUID and no
/// M3 telemetry is correlated (pre-M3 caller behaviour). /// M3 telemetry is correlated (pre-M3 caller behaviour).
/// </param> /// </param>
/// <param name="executionId">
/// Audit Log #23 (ExecutionId Task 4): the originating script execution's
/// per-run correlation id. When the write is buffered on a transient
/// failure this is threaded onto the S&amp;F message so the retry-loop
/// cached-write audit rows carry it. <c>null</c> when not threaded.
/// </param>
/// <param name="sourceScript">
/// Audit Log #23 (ExecutionId Task 4): the originating script identifier,
/// threaded onto the buffered S&amp;F message alongside
/// <paramref name="executionId"/>. <c>null</c> when not known.
/// </param>
Task CachedWriteAsync( Task CachedWriteAsync(
string connectionName, string connectionName,
string sql, string sql,
IReadOnlyDictionary<string, object?>? parameters = null, IReadOnlyDictionary<string, object?>? parameters = null,
string? originInstanceName = null, string? originInstanceName = null,
CancellationToken cancellationToken = default, CancellationToken cancellationToken = default,
TrackedOperationId? trackedOperationId = null); TrackedOperationId? trackedOperationId = null,
Guid? executionId = null,
string? sourceScript = null);
} }

View File

@@ -30,13 +30,26 @@ public interface IExternalSystemClient
/// M3 telemetry is correlated (the legacy behaviour pre-M3 callers rely /// M3 telemetry is correlated (the legacy behaviour pre-M3 callers rely
/// on). /// on).
/// </param> /// </param>
/// <param name="executionId">
/// Audit Log #23 (ExecutionId Task 4): the originating script execution's
/// per-run correlation id. When the call is buffered on a transient
/// failure this is threaded onto the S&amp;F message so the retry-loop
/// cached-call audit rows carry it. <c>null</c> when not threaded.
/// </param>
/// <param name="sourceScript">
/// Audit Log #23 (ExecutionId Task 4): the originating script identifier,
/// threaded onto the buffered S&amp;F message alongside
/// <paramref name="executionId"/>. <c>null</c> when not known.
/// </param>
Task<ExternalCallResult> CachedCallAsync( Task<ExternalCallResult> CachedCallAsync(
string systemName, string systemName,
string methodName, string methodName,
IReadOnlyDictionary<string, object?>? parameters = null, IReadOnlyDictionary<string, object?>? parameters = null,
string? originInstanceName = null, string? originInstanceName = null,
CancellationToken cancellationToken = default, CancellationToken cancellationToken = default,
TrackedOperationId? trackedOperationId = null); TrackedOperationId? trackedOperationId = null,
Guid? executionId = null,
string? sourceScript = null);
} }
/// <summary> /// <summary>

View File

@@ -84,7 +84,9 @@ public class DatabaseGateway : IDatabaseGateway
IReadOnlyDictionary<string, object?>? parameters = null, IReadOnlyDictionary<string, object?>? parameters = null,
string? originInstanceName = null, string? originInstanceName = null,
CancellationToken cancellationToken = default, CancellationToken cancellationToken = default,
TrackedOperationId? trackedOperationId = null) TrackedOperationId? trackedOperationId = null,
Guid? executionId = null,
string? sourceScript = null)
{ {
var definition = await ResolveConnectionAsync(connectionName, cancellationToken); var definition = await ResolveConnectionAsync(connectionName, cancellationToken);
if (definition == null) if (definition == null)
@@ -124,7 +126,13 @@ public class DatabaseGateway : IDatabaseGateway
// read it back via StoreAndForwardMessage.Id and emit per-attempt + // read it back via StoreAndForwardMessage.Id and emit per-attempt +
// terminal cached-write telemetry. Null -> S&F mints its own GUID // terminal cached-write telemetry. Null -> S&F mints its own GUID
// (legacy pre-M3 behaviour). // (legacy pre-M3 behaviour).
messageId: trackedOperationId?.ToString()); messageId: trackedOperationId?.ToString(),
// Audit Log #23 (ExecutionId Task 4): thread the originating script
// execution's ExecutionId + SourceScript onto the buffered row so
// the retry-loop cached-write audit rows carry the same provenance
// the script-side cached rows do.
executionId: executionId,
sourceScript: sourceScript);
} }
/// <summary> /// <summary>

View File

@@ -86,7 +86,9 @@ public class ExternalSystemClient : IExternalSystemClient
IReadOnlyDictionary<string, object?>? parameters = null, IReadOnlyDictionary<string, object?>? parameters = null,
string? originInstanceName = null, string? originInstanceName = null,
CancellationToken cancellationToken = default, CancellationToken cancellationToken = default,
TrackedOperationId? trackedOperationId = null) TrackedOperationId? trackedOperationId = null,
Guid? executionId = null,
string? sourceScript = null)
{ {
var (system, method) = await ResolveSystemAndMethodAsync(systemName, methodName, cancellationToken); var (system, method) = await ResolveSystemAndMethodAsync(systemName, methodName, cancellationToken);
if (system == null || method == null) if (system == null || method == null)
@@ -144,7 +146,13 @@ public class ExternalSystemClient : IExternalSystemClient
// StoreAndForwardMessage.Id and emit per-attempt + terminal // StoreAndForwardMessage.Id and emit per-attempt + terminal
// cached-call telemetry (Bundle E Tasks E4/E5). Null -> S&F // cached-call telemetry (Bundle E Tasks E4/E5). Null -> S&F
// mints its own GUID (legacy pre-M3 behaviour). // mints its own GUID (legacy pre-M3 behaviour).
messageId: trackedOperationId?.ToString()); messageId: trackedOperationId?.ToString(),
// Audit Log #23 (ExecutionId Task 4): thread the originating
// script execution's ExecutionId + SourceScript onto the
// buffered row so the retry-loop cached-call audit rows carry
// the same provenance the script-side cached rows do.
executionId: executionId,
sourceScript: sourceScript);
return new ExternalCallResult(true, null, null, WasBuffered: true); return new ExternalCallResult(true, null, null, WasBuffered: true);
} }

View File

@@ -513,7 +513,12 @@ public class ScriptRuntimeContext
parameters, parameters,
_instanceName, _instanceName,
cancellationToken, cancellationToken,
trackedId).ConfigureAwait(false); trackedId,
// Audit Log #23 (ExecutionId Task 4): thread the script
// execution's ExecutionId + SourceScript so a buffered
// cached call's retry-loop audit rows carry them.
executionId: _executionId,
sourceScript: _sourceScript).ConfigureAwait(false);
} }
catch (Exception ex) catch (Exception ex)
{ {
@@ -1096,7 +1101,12 @@ public class ScriptRuntimeContext
try try
{ {
await _gateway.CachedWriteAsync( await _gateway.CachedWriteAsync(
name, sql, parameters, _instanceName, cancellationToken, trackedId) name, sql, parameters, _instanceName, cancellationToken, trackedId,
// Audit Log #23 (ExecutionId Task 4): thread the script
// execution's ExecutionId + SourceScript so a buffered
// cached write's retry-loop audit rows carry them.
executionId: _executionId,
sourceScript: _sourceScript)
.ConfigureAwait(false); .ConfigureAwait(false);
} }
catch (Exception ex) catch (Exception ex)

View File

@@ -55,4 +55,25 @@ public class StoreAndForwardMessage
/// WP-13: Messages are NOT cleared when instance is deleted. /// WP-13: Messages are NOT cleared when instance is deleted.
/// </summary> /// </summary>
public string? OriginInstanceName { get; set; } public string? OriginInstanceName { get; set; }
/// <summary>
/// Audit Log #23 (ExecutionId Task 4): the originating script execution's
/// per-run correlation id, threaded from <c>ScriptRuntimeContext</c> through
/// the cached-call enqueue path. Carried so the store-and-forward retry loop
/// can stamp it onto the per-attempt / terminal cached-call audit rows
/// (<c>ApiCallCached</c>/<c>DbWriteCached</c> Attempted, <c>CachedResolve</c>).
/// <c>null</c> for non-cached-call categories (notifications) and for rows
/// buffered before this field existed — back-compat with old persisted rows
/// (the column is added by an additive migration and read as null when absent).
/// </summary>
public Guid? ExecutionId { get; set; }
/// <summary>
/// Audit Log #23 (ExecutionId Task 4): the originating script identifier,
/// threaded alongside <see cref="ExecutionId"/> from the cached-call enqueue
/// path so the retry-loop audit rows carry the same <c>SourceScript</c>
/// provenance the script-side cached rows already carry. <c>null</c> when not
/// known (non-cached categories, pre-migration rows).
/// </summary>
public string? SourceScript { get; set; }
} }

View File

@@ -175,6 +175,18 @@ public class StoreAndForwardService
/// it is the buffered row's <see cref="StoreAndForwardMessage.Id"/>, it is carried /// it is the buffered row's <see cref="StoreAndForwardMessage.Id"/>, it is carried
/// inside the payload, and it is the id the forwarder submits to central. /// inside the payload, and it is the id the forwarder submits to central.
/// </param> /// </param>
/// <param name="executionId">
/// Audit Log #23 (ExecutionId Task 4): the originating script execution's
/// per-run correlation id. Threaded onto the buffered row so the retry-loop
/// cached-call audit rows carry it. <c>null</c> for callers (notifications,
/// pre-Task-4 callers) that do not supply one.
/// </param>
/// <param name="sourceScript">
/// Audit Log #23 (ExecutionId Task 4): the originating script identifier,
/// threaded onto the buffered row alongside <paramref name="executionId"/>
/// so the retry-loop audit rows carry the same provenance the script-side
/// cached rows do. <c>null</c> when not known.
/// </param>
public async Task<StoreAndForwardResult> EnqueueAsync( public async Task<StoreAndForwardResult> EnqueueAsync(
StoreAndForwardCategory category, StoreAndForwardCategory category,
string target, string target,
@@ -183,7 +195,9 @@ public class StoreAndForwardService
int? maxRetries = null, int? maxRetries = null,
TimeSpan? retryInterval = null, TimeSpan? retryInterval = null,
bool attemptImmediateDelivery = true, bool attemptImmediateDelivery = true,
string? messageId = null) string? messageId = null,
Guid? executionId = null,
string? sourceScript = null)
{ {
var message = new StoreAndForwardMessage var message = new StoreAndForwardMessage
{ {
@@ -196,7 +210,9 @@ public class StoreAndForwardService
RetryIntervalMs = (long)(retryInterval ?? _options.DefaultRetryInterval).TotalMilliseconds, RetryIntervalMs = (long)(retryInterval ?? _options.DefaultRetryInterval).TotalMilliseconds,
CreatedAt = DateTimeOffset.UtcNow, CreatedAt = DateTimeOffset.UtcNow,
Status = StoreAndForwardMessageStatus.Pending, Status = StoreAndForwardMessageStatus.Pending,
OriginInstanceName = originInstanceName OriginInstanceName = originInstanceName,
ExecutionId = executionId,
SourceScript = sourceScript
}; };
// Attempt immediate delivery — unless the caller has already made a // Attempt immediate delivery — unless the caller has already made a
@@ -492,7 +508,14 @@ public class StoreAndForwardService
CreatedAtUtc: message.CreatedAt.UtcDateTime, CreatedAtUtc: message.CreatedAt.UtcDateTime,
OccurredAtUtc: DateTime.SpecifyKind(occurredAtUtc, DateTimeKind.Utc), OccurredAtUtc: DateTime.SpecifyKind(occurredAtUtc, DateTimeKind.Utc),
DurationMs: durationMs, DurationMs: durationMs,
SourceInstanceId: message.OriginInstanceName); SourceInstanceId: message.OriginInstanceName,
// Audit Log #23 (ExecutionId Task 4): the buffered message
// carries the originating script execution's ExecutionId +
// SourceScript; surface them on the context so the bridge can
// stamp the retry-loop cached audit rows. Null on rows buffered
// before Task 4 (back-compat).
ExecutionId: message.ExecutionId,
SourceScript: message.SourceScript);
} }
catch (Exception buildEx) catch (Exception buildEx)
{ {

View File

@@ -65,9 +65,45 @@ public class StoreAndForwardStorage
"; ";
await command.ExecuteNonQueryAsync(); await command.ExecuteNonQueryAsync();
// Audit Log #23 (ExecutionId Task 4): additively add the execution_id /
// source_script columns. CREATE TABLE IF NOT EXISTS above does NOT add
// columns to a table that already exists from before these fields, so a
// databases created by an older build needs the columns ALTER-ed in.
// SQLite has no "ADD COLUMN IF NOT EXISTS"; the column presence is
// probed first and the ALTER skipped when already there. Both columns
// are nullable with no default, so any row buffered before this
// migration reads back ExecutionId/SourceScript = null (back-compat).
await AddColumnIfMissingAsync(connection, "execution_id", "TEXT");
await AddColumnIfMissingAsync(connection, "source_script", "TEXT");
_logger.LogInformation("Store-and-forward SQLite storage initialized"); _logger.LogInformation("Store-and-forward SQLite storage initialized");
} }
/// <summary>
/// Audit Log #23 (ExecutionId Task 4): adds a column to <c>sf_messages</c>
/// only when it is not already present. SQLite lacks <c>ADD COLUMN IF NOT
/// EXISTS</c>, so the schema is probed via <c>PRAGMA table_info</c> first.
/// Idempotent — safe to run on every <see cref="InitializeAsync"/>.
/// </summary>
private static async Task AddColumnIfMissingAsync(
SqliteConnection connection, string columnName, string columnType)
{
await using var probe = connection.CreateCommand();
probe.CommandText = "SELECT COUNT(*) FROM pragma_table_info('sf_messages') WHERE name = @name";
probe.Parameters.AddWithValue("@name", columnName);
var exists = Convert.ToInt32(await probe.ExecuteScalarAsync()) > 0;
if (exists)
{
return;
}
await using var alter = connection.CreateCommand();
// Column name + type are caller-controlled constants, never user input —
// safe to interpolate (parameters are not permitted in DDL).
alter.CommandText = $"ALTER TABLE sf_messages ADD COLUMN {columnName} {columnType}";
await alter.ExecuteNonQueryAsync();
}
/// <summary> /// <summary>
/// Ensures the directory for a file-backed SQLite database exists. SQLite creates /// Ensures the directory for a file-backed SQLite database exists. SQLite creates
/// the database file on demand but not its parent directory, so a configured path /// the database file on demand but not its parent directory, so a configured path
@@ -105,9 +141,11 @@ public class StoreAndForwardStorage
await using var cmd = connection.CreateCommand(); await using var cmd = connection.CreateCommand();
cmd.CommandText = @" cmd.CommandText = @"
INSERT INTO sf_messages (id, category, target, payload_json, retry_count, max_retries, INSERT INTO sf_messages (id, category, target, payload_json, retry_count, max_retries,
retry_interval_ms, created_at, last_attempt_at, status, last_error, origin_instance) retry_interval_ms, created_at, last_attempt_at, status, last_error,
origin_instance, execution_id, source_script)
VALUES (@id, @category, @target, @payload, @retryCount, @maxRetries, VALUES (@id, @category, @target, @payload, @retryCount, @maxRetries,
@retryIntervalMs, @createdAt, @lastAttempt, @status, @lastError, @origin)"; @retryIntervalMs, @createdAt, @lastAttempt, @status, @lastError,
@origin, @executionId, @sourceScript)";
cmd.Parameters.AddWithValue("@id", message.Id); cmd.Parameters.AddWithValue("@id", message.Id);
cmd.Parameters.AddWithValue("@category", (int)message.Category); cmd.Parameters.AddWithValue("@category", (int)message.Category);
@@ -122,6 +160,12 @@ public class StoreAndForwardStorage
cmd.Parameters.AddWithValue("@status", (int)message.Status); cmd.Parameters.AddWithValue("@status", (int)message.Status);
cmd.Parameters.AddWithValue("@lastError", (object?)message.LastError ?? DBNull.Value); cmd.Parameters.AddWithValue("@lastError", (object?)message.LastError ?? DBNull.Value);
cmd.Parameters.AddWithValue("@origin", (object?)message.OriginInstanceName ?? DBNull.Value); cmd.Parameters.AddWithValue("@origin", (object?)message.OriginInstanceName ?? DBNull.Value);
// Audit Log #23 (ExecutionId Task 4): the execution id is stored as its
// canonical string form ("D") so it round-trips cleanly through the
// TEXT column; null when not a cached call / not threaded.
cmd.Parameters.AddWithValue("@executionId",
message.ExecutionId.HasValue ? message.ExecutionId.Value.ToString("D") : DBNull.Value);
cmd.Parameters.AddWithValue("@sourceScript", (object?)message.SourceScript ?? DBNull.Value);
await cmd.ExecuteNonQueryAsync(); await cmd.ExecuteNonQueryAsync();
} }
@@ -137,7 +181,8 @@ public class StoreAndForwardStorage
await using var cmd = connection.CreateCommand(); await using var cmd = connection.CreateCommand();
cmd.CommandText = @" cmd.CommandText = @"
SELECT id, category, target, payload_json, retry_count, max_retries, SELECT id, category, target, payload_json, retry_count, max_retries,
retry_interval_ms, created_at, last_attempt_at, status, last_error, origin_instance retry_interval_ms, created_at, last_attempt_at, status, last_error, origin_instance,
execution_id, source_script
FROM sf_messages FROM sf_messages
WHERE status = @pending WHERE status = @pending
AND (last_attempt_at IS NULL AND (last_attempt_at IS NULL
@@ -268,7 +313,8 @@ public class StoreAndForwardStorage
var categoryFilter = category.HasValue ? " AND category = @category" : ""; var categoryFilter = category.HasValue ? " AND category = @category" : "";
pageCmd.CommandText = $@" pageCmd.CommandText = $@"
SELECT id, category, target, payload_json, retry_count, max_retries, SELECT id, category, target, payload_json, retry_count, max_retries,
retry_interval_ms, created_at, last_attempt_at, status, last_error, origin_instance retry_interval_ms, created_at, last_attempt_at, status, last_error, origin_instance,
execution_id, source_script
FROM sf_messages FROM sf_messages
WHERE status = @parked{categoryFilter} WHERE status = @parked{categoryFilter}
ORDER BY created_at ASC ORDER BY created_at ASC
@@ -389,7 +435,8 @@ public class StoreAndForwardStorage
await using var cmd = connection.CreateCommand(); await using var cmd = connection.CreateCommand();
cmd.CommandText = @" cmd.CommandText = @"
SELECT id, category, target, payload_json, retry_count, max_retries, SELECT id, category, target, payload_json, retry_count, max_retries,
retry_interval_ms, created_at, last_attempt_at, status, last_error, origin_instance retry_interval_ms, created_at, last_attempt_at, status, last_error, origin_instance,
execution_id, source_script
FROM sf_messages FROM sf_messages
WHERE id = @id"; WHERE id = @id";
cmd.Parameters.AddWithValue("@id", messageId); cmd.Parameters.AddWithValue("@id", messageId);
@@ -446,7 +493,12 @@ public class StoreAndForwardStorage
LastAttemptAt = reader.IsDBNull(8) ? null : DateTimeOffset.Parse(reader.GetString(8)), LastAttemptAt = reader.IsDBNull(8) ? null : DateTimeOffset.Parse(reader.GetString(8)),
Status = (StoreAndForwardMessageStatus)reader.GetInt32(9), Status = (StoreAndForwardMessageStatus)reader.GetInt32(9),
LastError = reader.IsDBNull(10) ? null : reader.GetString(10), LastError = reader.IsDBNull(10) ? null : reader.GetString(10),
OriginInstanceName = reader.IsDBNull(11) ? null : reader.GetString(11) OriginInstanceName = reader.IsDBNull(11) ? null : reader.GetString(11),
// Audit Log #23 (ExecutionId Task 4): rows persisted before the
// additive migration have no execution_id / source_script value;
// IsDBNull guards keep those reading back as null (back-compat).
ExecutionId = reader.IsDBNull(12) ? null : Guid.Parse(reader.GetString(12)),
SourceScript = reader.IsDBNull(13) ? null : reader.GetString(13)
}); });
} }
return results; return results;

View File

@@ -31,7 +31,9 @@ public class CachedCallLifecycleBridgeTests
string channel = "ApiOutbound", string channel = "ApiOutbound",
int retryCount = 1, int retryCount = 1,
string? lastError = null, string? lastError = null,
int? httpStatus = null) => int? httpStatus = null,
Guid? executionId = null,
string? sourceScript = null) =>
new( new(
TrackedOperationId: _id, TrackedOperationId: _id,
Channel: channel, Channel: channel,
@@ -44,7 +46,9 @@ public class CachedCallLifecycleBridgeTests
CreatedAtUtc: new DateTime(2026, 5, 20, 9, 0, 0, DateTimeKind.Utc), CreatedAtUtc: new DateTime(2026, 5, 20, 9, 0, 0, DateTimeKind.Utc),
OccurredAtUtc: new DateTime(2026, 5, 20, 10, 0, 0, DateTimeKind.Utc), OccurredAtUtc: new DateTime(2026, 5, 20, 10, 0, 0, DateTimeKind.Utc),
DurationMs: 42, DurationMs: 42,
SourceInstanceId: "Plant.Pump42"); SourceInstanceId: "Plant.Pump42",
ExecutionId: executionId,
SourceScript: sourceScript);
[Fact] [Fact]
public async Task TransientFailure_EmitsOneAttemptedRow_NoResolve() public async Task TransientFailure_EmitsOneAttemptedRow_NoResolve()
@@ -184,4 +188,75 @@ public class CachedCallLifecycleBridgeTests
Assert.Equal(42, captured.Audit.DurationMs); Assert.Equal(42, captured.Audit.DurationMs);
Assert.Equal(_id.Value, captured.Audit.CorrelationId); Assert.Equal(_id.Value, captured.Audit.CorrelationId);
} }
// ── Audit Log #23 (ExecutionId Task 4): ExecutionId / SourceScript ──
[Fact]
public async Task RetryLoopAttemptedRow_CarriesExecutionIdAndSourceScript_FromContext()
{
// Task 4: the ExecutionId + SourceScript threaded through the S&F
// buffer arrive on the CachedCallAttemptContext; the bridge must stamp
// both onto the per-attempt ApiCallCached row (previously SourceScript
// was hard-coded null with a "not threaded through S&F" comment).
var executionId = Guid.NewGuid();
var captured = new List<CachedCallTelemetry>();
_forwarder.ForwardAsync(Arg.Do<CachedCallTelemetry>(t => captured.Add(t)), Arg.Any<CancellationToken>())
.Returns(Task.CompletedTask);
var sut = CreateSut();
await sut.OnAttemptCompletedAsync(Ctx(
CachedCallAttemptOutcome.TransientFailure,
executionId: executionId,
sourceScript: "Plant.Pump42/OnTick"));
var packet = Assert.Single(captured);
Assert.Equal(AuditKind.ApiCallCached, packet.Audit.Kind);
Assert.Equal(executionId, packet.Audit.ExecutionId);
Assert.Equal("Plant.Pump42/OnTick", packet.Audit.SourceScript);
}
[Fact]
public async Task RetryLoopCachedResolveRow_CarriesExecutionIdAndSourceScript_FromContext()
{
// The terminal CachedResolve row must also carry the threaded
// provenance so the whole retry-loop lifecycle is correlated.
var executionId = Guid.NewGuid();
var captured = new List<CachedCallTelemetry>();
_forwarder.ForwardAsync(Arg.Do<CachedCallTelemetry>(t => captured.Add(t)), Arg.Any<CancellationToken>())
.Returns(Task.CompletedTask);
var sut = CreateSut();
await sut.OnAttemptCompletedAsync(Ctx(
CachedCallAttemptOutcome.Delivered,
channel: "DbOutbound",
executionId: executionId,
sourceScript: "Plant.Tank/OnAlarm"));
Assert.Equal(2, captured.Count);
var resolve = Assert.Single(captured, p => p.Audit.Kind == AuditKind.CachedResolve);
Assert.Equal(executionId, resolve.Audit.ExecutionId);
Assert.Equal("Plant.Tank/OnAlarm", resolve.Audit.SourceScript);
var attempted = Assert.Single(captured, p => p.Audit.Kind == AuditKind.DbWriteCached);
Assert.Equal(executionId, attempted.Audit.ExecutionId);
Assert.Equal("Plant.Tank/OnAlarm", attempted.Audit.SourceScript);
}
[Fact]
public async Task RetryLoopRow_NullExecutionIdAndSourceScript_RemainNull()
{
// Back-compat: a pre-Task-4 buffered row has no ExecutionId /
// SourceScript; the bridge must leave the audit row's fields null
// rather than throwing.
CachedCallTelemetry? captured = null;
_forwarder.ForwardAsync(Arg.Do<CachedCallTelemetry>(t => captured = t), Arg.Any<CancellationToken>())
.Returns(Task.CompletedTask);
var sut = CreateSut();
await sut.OnAttemptCompletedAsync(Ctx(CachedCallAttemptOutcome.TransientFailure));
Assert.NotNull(captured);
Assert.Null(captured!.Audit.ExecutionId);
Assert.Null(captured.Audit.SourceScript);
}
} }

View File

@@ -72,7 +72,8 @@ public class DatabaseCachedWriteEmissionTests
It.IsAny<IReadOnlyDictionary<string, object?>?>(), It.IsAny<IReadOnlyDictionary<string, object?>?>(),
InstanceName, InstanceName,
It.IsAny<CancellationToken>(), It.IsAny<CancellationToken>(),
It.IsAny<TrackedOperationId?>())) It.IsAny<TrackedOperationId?>(),
It.IsAny<Guid?>(), It.IsAny<string?>()))
.Returns(Task.CompletedTask); .Returns(Task.CompletedTask);
var forwarder = new CapturingForwarder(); var forwarder = new CapturingForwarder();
@@ -110,7 +111,8 @@ public class DatabaseCachedWriteEmissionTests
It.IsAny<IReadOnlyDictionary<string, object?>?>(), It.IsAny<IReadOnlyDictionary<string, object?>?>(),
It.IsAny<string?>(), It.IsAny<string?>(),
It.IsAny<CancellationToken>(), It.IsAny<CancellationToken>(),
It.IsAny<TrackedOperationId?>())) It.IsAny<TrackedOperationId?>(),
It.IsAny<Guid?>(), It.IsAny<string?>()))
.Returns(Task.CompletedTask); .Returns(Task.CompletedTask);
var forwarder = new CapturingForwarder(); var forwarder = new CapturingForwarder();
@@ -134,7 +136,8 @@ public class DatabaseCachedWriteEmissionTests
It.IsAny<IReadOnlyDictionary<string, object?>?>(), It.IsAny<IReadOnlyDictionary<string, object?>?>(),
It.IsAny<string?>(), It.IsAny<string?>(),
It.IsAny<CancellationToken>(), It.IsAny<CancellationToken>(),
It.IsAny<TrackedOperationId?>())) It.IsAny<TrackedOperationId?>(),
It.IsAny<Guid?>(), It.IsAny<string?>()))
.Returns(Task.CompletedTask); .Returns(Task.CompletedTask);
var forwarder = new CapturingForwarder(); var forwarder = new CapturingForwarder();
@@ -147,7 +150,8 @@ public class DatabaseCachedWriteEmissionTests
It.IsAny<IReadOnlyDictionary<string, object?>?>(), It.IsAny<IReadOnlyDictionary<string, object?>?>(),
InstanceName, InstanceName,
It.IsAny<CancellationToken>(), It.IsAny<CancellationToken>(),
trackedId), trackedId,
It.IsAny<Guid?>(), It.IsAny<string?>()),
Times.Once); Times.Once);
} }
@@ -161,7 +165,8 @@ public class DatabaseCachedWriteEmissionTests
It.IsAny<IReadOnlyDictionary<string, object?>?>(), It.IsAny<IReadOnlyDictionary<string, object?>?>(),
It.IsAny<string?>(), It.IsAny<string?>(),
It.IsAny<CancellationToken>(), It.IsAny<CancellationToken>(),
It.IsAny<TrackedOperationId?>())) It.IsAny<TrackedOperationId?>(),
It.IsAny<Guid?>(), It.IsAny<string?>()))
.Returns(Task.CompletedTask); .Returns(Task.CompletedTask);
var forwarder = new CapturingForwarder var forwarder = new CapturingForwarder
{ {
@@ -177,7 +182,8 @@ public class DatabaseCachedWriteEmissionTests
It.IsAny<IReadOnlyDictionary<string, object?>?>(), It.IsAny<IReadOnlyDictionary<string, object?>?>(),
InstanceName, InstanceName,
It.IsAny<CancellationToken>(), It.IsAny<CancellationToken>(),
trackedId), trackedId,
It.IsAny<Guid?>(), It.IsAny<string?>()),
Times.Once); Times.Once);
} }
} }

View File

@@ -75,7 +75,8 @@ public class ExternalSystemCachedCallEmissionTests
It.IsAny<IReadOnlyDictionary<string, object?>?>(), It.IsAny<IReadOnlyDictionary<string, object?>?>(),
InstanceName, InstanceName,
It.IsAny<CancellationToken>(), It.IsAny<CancellationToken>(),
It.IsAny<TrackedOperationId?>())) It.IsAny<TrackedOperationId?>(),
It.IsAny<Guid?>(), It.IsAny<string?>()))
.ReturnsAsync(new ExternalCallResult(true, null, null, WasBuffered: true)); .ReturnsAsync(new ExternalCallResult(true, null, null, WasBuffered: true));
var forwarder = new CapturingForwarder(); var forwarder = new CapturingForwarder();
@@ -117,7 +118,8 @@ public class ExternalSystemCachedCallEmissionTests
It.IsAny<IReadOnlyDictionary<string, object?>?>(), It.IsAny<IReadOnlyDictionary<string, object?>?>(),
InstanceName, InstanceName,
It.IsAny<CancellationToken>(), It.IsAny<CancellationToken>(),
It.IsAny<TrackedOperationId?>())) It.IsAny<TrackedOperationId?>(),
It.IsAny<Guid?>(), It.IsAny<string?>()))
.ReturnsAsync(new ExternalCallResult(true, "{\"ok\":true}", null, WasBuffered: false)); .ReturnsAsync(new ExternalCallResult(true, "{\"ok\":true}", null, WasBuffered: false));
var forwarder = new CapturingForwarder(); var forwarder = new CapturingForwarder();
@@ -153,7 +155,8 @@ public class ExternalSystemCachedCallEmissionTests
It.IsAny<IReadOnlyDictionary<string, object?>?>(), It.IsAny<IReadOnlyDictionary<string, object?>?>(),
It.IsAny<string?>(), It.IsAny<string?>(),
It.IsAny<CancellationToken>(), It.IsAny<CancellationToken>(),
It.IsAny<TrackedOperationId?>())) It.IsAny<TrackedOperationId?>(),
It.IsAny<Guid?>(), It.IsAny<string?>()))
.ReturnsAsync(new ExternalCallResult(true, null, null, WasBuffered: true)); .ReturnsAsync(new ExternalCallResult(true, null, null, WasBuffered: true));
var forwarder = new CapturingForwarder(); var forwarder = new CapturingForwarder();
@@ -172,14 +175,16 @@ public class ExternalSystemCachedCallEmissionTests
It.IsAny<IReadOnlyDictionary<string, object?>?>(), It.IsAny<IReadOnlyDictionary<string, object?>?>(),
InstanceName, InstanceName,
It.IsAny<CancellationToken>(), It.IsAny<CancellationToken>(),
id1), id1,
It.IsAny<Guid?>(), It.IsAny<string?>()),
Times.Once); Times.Once);
client.Verify(c => c.CachedCallAsync( client.Verify(c => c.CachedCallAsync(
"ERP", "GetOrder", "ERP", "GetOrder",
It.IsAny<IReadOnlyDictionary<string, object?>?>(), It.IsAny<IReadOnlyDictionary<string, object?>?>(),
InstanceName, InstanceName,
It.IsAny<CancellationToken>(), It.IsAny<CancellationToken>(),
id2), id2,
It.IsAny<Guid?>(), It.IsAny<string?>()),
Times.Once); Times.Once);
} }
@@ -193,7 +198,8 @@ public class ExternalSystemCachedCallEmissionTests
It.IsAny<IReadOnlyDictionary<string, object?>?>(), It.IsAny<IReadOnlyDictionary<string, object?>?>(),
It.IsAny<string?>(), It.IsAny<string?>(),
It.IsAny<CancellationToken>(), It.IsAny<CancellationToken>(),
It.IsAny<TrackedOperationId?>())) It.IsAny<TrackedOperationId?>(),
It.IsAny<Guid?>(), It.IsAny<string?>()))
.ReturnsAsync(new ExternalCallResult(true, null, null, WasBuffered: true)); .ReturnsAsync(new ExternalCallResult(true, null, null, WasBuffered: true));
var forwarder = new CapturingForwarder var forwarder = new CapturingForwarder
{ {
@@ -212,7 +218,8 @@ public class ExternalSystemCachedCallEmissionTests
It.IsAny<IReadOnlyDictionary<string, object?>?>(), It.IsAny<IReadOnlyDictionary<string, object?>?>(),
InstanceName, InstanceName,
It.IsAny<CancellationToken>(), It.IsAny<CancellationToken>(),
trackedId), trackedId,
It.IsAny<Guid?>(), It.IsAny<string?>()),
Times.Once); Times.Once);
} }
@@ -226,7 +233,8 @@ public class ExternalSystemCachedCallEmissionTests
It.IsAny<IReadOnlyDictionary<string, object?>?>(), It.IsAny<IReadOnlyDictionary<string, object?>?>(),
It.IsAny<string?>(), It.IsAny<string?>(),
It.IsAny<CancellationToken>(), It.IsAny<CancellationToken>(),
It.IsAny<TrackedOperationId?>())) It.IsAny<TrackedOperationId?>(),
It.IsAny<Guid?>(), It.IsAny<string?>()))
.ReturnsAsync(new ExternalCallResult(true, null, null, WasBuffered: true)); .ReturnsAsync(new ExternalCallResult(true, null, null, WasBuffered: true));
var forwarder = new CapturingForwarder(); var forwarder = new CapturingForwarder();
@@ -252,7 +260,8 @@ public class ExternalSystemCachedCallEmissionTests
It.IsAny<IReadOnlyDictionary<string, object?>?>(), It.IsAny<IReadOnlyDictionary<string, object?>?>(),
It.IsAny<string?>(), It.IsAny<string?>(),
It.IsAny<CancellationToken>(), It.IsAny<CancellationToken>(),
It.IsAny<TrackedOperationId?>())) It.IsAny<TrackedOperationId?>(),
It.IsAny<Guid?>(), It.IsAny<string?>()))
.ReturnsAsync(new ExternalCallResult(true, null, null, WasBuffered: true)); .ReturnsAsync(new ExternalCallResult(true, null, null, WasBuffered: true));
var helper = CreateHelper(client.Object, forwarder: null); var helper = CreateHelper(client.Object, forwarder: null);
@@ -264,7 +273,8 @@ public class ExternalSystemCachedCallEmissionTests
It.IsAny<IReadOnlyDictionary<string, object?>?>(), It.IsAny<IReadOnlyDictionary<string, object?>?>(),
InstanceName, InstanceName,
It.IsAny<CancellationToken>(), It.IsAny<CancellationToken>(),
trackedId), trackedId,
It.IsAny<Guid?>(), It.IsAny<string?>()),
Times.Once); Times.Once);
} }
@@ -293,7 +303,8 @@ public class ExternalSystemCachedCallEmissionTests
It.IsAny<IReadOnlyDictionary<string, object?>?>(), It.IsAny<IReadOnlyDictionary<string, object?>?>(),
InstanceName, InstanceName,
It.IsAny<CancellationToken>(), It.IsAny<CancellationToken>(),
It.IsAny<TrackedOperationId?>())) It.IsAny<TrackedOperationId?>(),
It.IsAny<Guid?>(), It.IsAny<string?>()))
// WasBuffered=false — the immediate HTTP attempt succeeded; S&F // WasBuffered=false — the immediate HTTP attempt succeeded; S&F
// is bypassed entirely. // is bypassed entirely.
.ReturnsAsync(new ExternalCallResult(true, "{\"ok\":true}", null, WasBuffered: false)); .ReturnsAsync(new ExternalCallResult(true, "{\"ok\":true}", null, WasBuffered: false));
@@ -354,7 +365,8 @@ public class ExternalSystemCachedCallEmissionTests
It.IsAny<IReadOnlyDictionary<string, object?>?>(), It.IsAny<IReadOnlyDictionary<string, object?>?>(),
InstanceName, InstanceName,
It.IsAny<CancellationToken>(), It.IsAny<CancellationToken>(),
It.IsAny<TrackedOperationId?>())) It.IsAny<TrackedOperationId?>(),
It.IsAny<Guid?>(), It.IsAny<string?>()))
.ReturnsAsync(new ExternalCallResult( .ReturnsAsync(new ExternalCallResult(
false, null, "Permanent error: HTTP 422 bad payload", WasBuffered: false)); false, null, "Permanent error: HTTP 422 bad payload", WasBuffered: false));
var forwarder = new CapturingForwarder(); var forwarder = new CapturingForwarder();
@@ -396,7 +408,8 @@ public class ExternalSystemCachedCallEmissionTests
It.IsAny<IReadOnlyDictionary<string, object?>?>(), It.IsAny<IReadOnlyDictionary<string, object?>?>(),
InstanceName, InstanceName,
It.IsAny<CancellationToken>(), It.IsAny<CancellationToken>(),
It.IsAny<TrackedOperationId?>())) It.IsAny<TrackedOperationId?>(),
It.IsAny<Guid?>(), It.IsAny<string?>()))
// S&F took ownership — Attempted + Resolve come from the // S&F took ownership — Attempted + Resolve come from the
// CachedCallLifecycleBridge driven by the retry loop, not the helper. // CachedCallLifecycleBridge driven by the retry loop, not the helper.
.ReturnsAsync(new ExternalCallResult(true, null, null, WasBuffered: true)); .ReturnsAsync(new ExternalCallResult(true, null, null, WasBuffered: true));

View File

@@ -277,6 +277,86 @@ public class CachedCallAttemptEmissionTests : IAsyncLifetime, IDisposable
Assert.Equal(trackedId, _observer.Notifications[1].TrackedOperationId); Assert.Equal(trackedId, _observer.Notifications[1].TrackedOperationId);
} }
// ── Audit Log #23 (ExecutionId Task 4): ExecutionId / SourceScript ──
[Fact]
public async Task Attempt_CarriesExecutionIdAndSourceScript_FromBufferedMessage()
{
// A buffered cached call carries the originating script execution's
// ExecutionId + SourceScript. The retry sweep must surface both on the
// CachedCallAttemptContext handed to the observer so the audit bridge
// can stamp them on the retry-loop cached rows.
var executionId = Guid.NewGuid();
_service.RegisterDeliveryHandler(StoreAndForwardCategory.ExternalSystem,
_ => throw new HttpRequestException("HTTP 503"));
var trackedId = TrackedOperationId.New();
await _service.EnqueueAsync(
StoreAndForwardCategory.ExternalSystem,
"ERP",
"""{"payload":"x"}""",
originInstanceName: "Plant.Pump42",
maxRetries: 5,
retryInterval: TimeSpan.Zero,
attemptImmediateDelivery: false,
messageId: trackedId.ToString(),
executionId: executionId,
sourceScript: "Plant.Pump42/OnTick");
await _service.RetryPendingMessagesAsync();
var notification = Assert.Single(_observer.Notifications);
Assert.Equal(executionId, notification.ExecutionId);
Assert.Equal("Plant.Pump42/OnTick", notification.SourceScript);
}
[Fact]
public async Task Attempt_NullExecutionIdAndSourceScript_SurfaceAsNull()
{
// Back-compat: a row buffered without ExecutionId / SourceScript (legacy
// enqueue path) must surface them as null on the context, not throw.
_service.RegisterDeliveryHandler(StoreAndForwardCategory.ExternalSystem,
_ => Task.FromResult(true));
var trackedId = await EnqueueBufferedAsync(
StoreAndForwardCategory.ExternalSystem, "ERP");
await _service.RetryPendingMessagesAsync();
var notification = Assert.Single(_observer.Notifications);
Assert.Null(notification.ExecutionId);
Assert.Null(notification.SourceScript);
}
[Fact]
public async Task TerminalResolve_CarriesExecutionIdAndSourceScript()
{
// The terminal Delivered notification must also carry the threaded
// provenance so the CachedResolve audit row is correlated.
var executionId = Guid.NewGuid();
_service.RegisterDeliveryHandler(StoreAndForwardCategory.CachedDbWrite,
_ => Task.FromResult(true));
var trackedId = TrackedOperationId.New();
await _service.EnqueueAsync(
StoreAndForwardCategory.CachedDbWrite,
"myDb",
"""{"payload":"x"}""",
originInstanceName: "Plant.Tank",
maxRetries: 3,
retryInterval: TimeSpan.Zero,
attemptImmediateDelivery: false,
messageId: trackedId.ToString(),
executionId: executionId,
sourceScript: "Plant.Tank/OnAlarm");
await _service.RetryPendingMessagesAsync();
var notification = Assert.Single(_observer.Notifications);
Assert.Equal(CachedCallAttemptOutcome.Delivered, notification.Outcome);
Assert.Equal(executionId, notification.ExecutionId);
Assert.Equal("Plant.Tank/OnAlarm", notification.SourceScript);
}
// ── Best-effort contract: observer throws must NOT corrupt retry bookkeeping ── // ── Best-effort contract: observer throws must NOT corrupt retry bookkeeping ──
[Fact] [Fact]

View File

@@ -293,6 +293,125 @@ public class StoreAndForwardStorageTests : IAsyncLifetime, IDisposable
Assert.True(count >= 1); Assert.True(count >= 1);
} }
// ── Audit Log #23 (ExecutionId Task 4): execution_id / source_script ──
[Fact]
public async Task EnqueueAsync_RoundTripsExecutionIdAndSourceScript()
{
// A cached call buffered on a transient failure carries the originating
// script execution's ExecutionId + SourceScript; both must survive a
// persist + read-back so the retry loop can stamp them on audit rows.
var executionId = Guid.NewGuid();
var message = CreateMessage("exec1", StoreAndForwardCategory.ExternalSystem);
message.ExecutionId = executionId;
message.SourceScript = "Plant.Pump42/OnTick";
await _storage.EnqueueAsync(message);
var retrieved = await _storage.GetMessageByIdAsync("exec1");
Assert.NotNull(retrieved);
Assert.Equal(executionId, retrieved!.ExecutionId);
Assert.Equal("Plant.Pump42/OnTick", retrieved.SourceScript);
}
[Fact]
public async Task EnqueueAsync_NullExecutionIdAndSourceScript_RoundTripAsNull()
{
// Non-cached-call enqueues (notifications) supply neither field — they
// must round-trip as null rather than throwing or coercing.
var message = CreateMessage("noexec1", StoreAndForwardCategory.Notification);
Assert.Null(message.ExecutionId);
Assert.Null(message.SourceScript);
await _storage.EnqueueAsync(message);
var retrieved = await _storage.GetMessageByIdAsync("noexec1");
Assert.NotNull(retrieved);
Assert.Null(retrieved!.ExecutionId);
Assert.Null(retrieved.SourceScript);
}
[Fact]
public async Task ExecutionIdAndSourceScript_SurviveRetrySweepRead()
{
// The retry sweep reads due rows via GetMessagesForRetryAsync; the new
// fields must be present on that read path too (it is the path that
// feeds the CachedCallAttemptContext).
var executionId = Guid.NewGuid();
var message = CreateMessage("sweep1", StoreAndForwardCategory.CachedDbWrite);
message.ExecutionId = executionId;
message.SourceScript = "Plant.Tank/OnAlarm";
message.LastAttemptAt = null; // due immediately
await _storage.EnqueueAsync(message);
var due = await _storage.GetMessagesForRetryAsync();
var row = Assert.Single(due, m => m.Id == "sweep1");
Assert.Equal(executionId, row.ExecutionId);
Assert.Equal("Plant.Tank/OnAlarm", row.SourceScript);
}
[Fact]
public async Task LegacyRowWithoutNewColumns_ReadsBackAsNull()
{
// Back-compat: a row persisted by a build that pre-dates the
// execution_id / source_script columns must still deserialize, with
// ExecutionId / SourceScript reading back as null. Simulate the legacy
// schema by dropping the table and recreating it without the columns,
// inserting directly, then running InitializeAsync (which ALTER-adds
// the columns) and reading the row back.
await using (var setup = new SqliteConnection($"Data Source={_dbName};Mode=Memory;Cache=Shared"))
{
await setup.OpenAsync();
await using var drop = setup.CreateCommand();
drop.CommandText = @"
DROP TABLE IF EXISTS sf_messages;
CREATE TABLE sf_messages (
id TEXT PRIMARY KEY,
category INTEGER NOT NULL,
target TEXT NOT NULL,
payload_json TEXT NOT NULL,
retry_count INTEGER NOT NULL DEFAULT 0,
max_retries INTEGER NOT NULL DEFAULT 50,
retry_interval_ms INTEGER NOT NULL DEFAULT 30000,
created_at TEXT NOT NULL,
last_attempt_at TEXT,
status INTEGER NOT NULL DEFAULT 0,
last_error TEXT,
origin_instance TEXT
);
INSERT INTO sf_messages (id, category, target, payload_json, created_at, status)
VALUES ('legacy1', 0, 'ERP', '{}', '2026-01-01T00:00:00.0000000+00:00', 0);";
await drop.ExecuteNonQueryAsync();
}
// InitializeAsync must additively ALTER-in the new columns without
// disturbing the pre-existing legacy row.
await _storage.InitializeAsync();
var retrieved = await _storage.GetMessageByIdAsync("legacy1");
Assert.NotNull(retrieved);
Assert.Equal("legacy1", retrieved!.Id);
Assert.Null(retrieved.ExecutionId);
Assert.Null(retrieved.SourceScript);
}
[Fact]
public async Task InitializeAsync_IsIdempotent_WhenColumnsAlreadyExist()
{
// The additive ALTER must not fail on a second InitializeAsync call
// (SQLite has no ADD COLUMN IF NOT EXISTS — the probe must skip it).
await _storage.InitializeAsync();
await _storage.InitializeAsync();
var message = CreateMessage("idem1", StoreAndForwardCategory.ExternalSystem);
message.ExecutionId = Guid.NewGuid();
await _storage.EnqueueAsync(message);
var retrieved = await _storage.GetMessageByIdAsync("idem1");
Assert.NotNull(retrieved);
Assert.Equal(message.ExecutionId, retrieved!.ExecutionId);
}
private static StoreAndForwardMessage CreateMessage(string id, StoreAndForwardCategory category) private static StoreAndForwardMessage CreateMessage(string id, StoreAndForwardCategory category)
{ {
return new StoreAndForwardMessage return new StoreAndForwardMessage