fix(cli): resolve CLI-001 — honor SCADALINK_FORMAT and config-file format precedence
This commit is contained in:
@@ -8,7 +8,7 @@
|
||||
| Last reviewed | 2026-05-16 |
|
||||
| Reviewer | claude-agent |
|
||||
| Commit reviewed | `9c60592` |
|
||||
| Open findings | 13 |
|
||||
| Open findings | 12 |
|
||||
|
||||
## Summary
|
||||
|
||||
@@ -54,7 +54,7 @@ argument parsing, and the command-tree wiring are untested.
|
||||
|--|--|
|
||||
| Severity | High |
|
||||
| Category | Correctness & logic bugs |
|
||||
| Status | Open |
|
||||
| Status | Resolved |
|
||||
| Location | `src/ScadaLink.CLI/Commands/CommandHelpers.cs:18`, `src/ScadaLink.CLI/Commands/DebugCommands.cs:45`, `src/ScadaLink.CLI/CliConfig.cs:37-39` |
|
||||
|
||||
**Description**
|
||||
@@ -79,7 +79,12 @@ only then override the config value. Apply the same fix to `DebugCommands.BuildS
|
||||
|
||||
**Resolution**
|
||||
|
||||
_Unresolved._
|
||||
Resolved 2026-05-16 (commit `<pending>`). Removed the `--format` option's
|
||||
`DefaultValueFactory` in `Program.cs` and added `CommandHelpers.ResolveFormat`, which uses
|
||||
`ParseResult.GetResult(formatOption)` to detect an explicitly supplied flag and resolves
|
||||
precedence explicitly: explicit `--format` → `CliConfig.DefaultFormat` (env var / config
|
||||
file) → `"json"`. Both `CommandHelpers.ExecuteCommandAsync` and `DebugCommands.BuildStream`
|
||||
now call `ResolveFormat`. Regression tests added in `FormatResolutionTests`.
|
||||
|
||||
### CLI-002 — Empty success body crashes table rendering with an unhandled exception
|
||||
|
||||
|
||||
Reference in New Issue
Block a user