dohertj2/scadalink-design
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(deployment): instance delete fully removes the record

Browse Source 
Deleting an instance only undeployed it from the site and set the state
to NotDeployed, leaving an orphan record that could never be removed —
the state-transition matrix rejected delete from NotDeployed.

Delete now removes the instance record entirely (deployment history,
snapshot, attribute/alarm overrides, and connection bindings go with
it), and is permitted from any state.
This commit is contained in:
Joseph Doherty
2026-05-15 12:05:13 -04:00
parent 17e24ddd20
commit 1d5465f31c
6 changed files with 45 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/ScadaLink.DeploymentManager.Tests/StateTransitionValidatorTests.cs
View File

@@ -73,9 +73,9 @@ public class StateTransitionValidatorTests
}
[Fact]
public void CanDelete_WhenNotDeployed_ReturnsFalse()
public void CanDelete_WhenNotDeployed_ReturnsTrue()
{
Assert.False(StateTransitionValidator.CanDelete(InstanceState.NotDeployed));
Assert.True(StateTransitionValidator.CanDelete(InstanceState.NotDeployed));
}
// ── ValidateTransition ──
@@ -103,10 +103,10 @@ public class StateTransitionValidatorTests
}
[Fact]
public void ValidateTransition_InvalidDeleteOnNotDeployed_ReturnsError()
public void ValidateTransition_ValidDeleteOnNotDeployed_ReturnsNull()
{
var error = StateTransitionValidator.ValidateTransition(InstanceState.NotDeployed, "delete");
Assert.NotNull(error);
Assert.Null(error);
}
[Fact]