natsdotnet

dohertj2/natsdotnet

Fork 0

Commit Graph

Author	SHA1	Message	Date
Joseph Doherty	18a6d0f478	fix: address code review findings for WebSocket implementation - Convert WsReadInfo from mutable struct to class (prevents silent copy bugs) - Add handshake timeout enforcement via CancellationToken in WsUpgrade - Use buffered reading (512 bytes) in ReadHttpRequestAsync instead of byte-at-a-time - Add IAsyncDisposable to WsConnection for proper async cleanup - Simplify redundant mask bit check in WsReadInfo - Remove unused WsGuid and CompressLastBlock dead code from WsConstants - Document single-reader assumption on WsConnection read-side state	2026-02-23 05:27:36 -05:00
Joseph Doherty	72f60054ed	feat: add WebSocket protocol constants (RFC 6455) Port WsConstants from golang/nats-server/server/websocket.go lines 41-106. Includes opcodes, frame header bits, close status codes, compression constants, header names, path routing, and the WsClientKind enum.	2026-02-23 04:33:04 -05:00

Author

SHA1

Message

Date

Joseph Doherty

18a6d0f478

fix: address code review findings for WebSocket implementation

- Convert WsReadInfo from mutable struct to class (prevents silent copy bugs)
- Add handshake timeout enforcement via CancellationToken in WsUpgrade
- Use buffered reading (512 bytes) in ReadHttpRequestAsync instead of byte-at-a-time
- Add IAsyncDisposable to WsConnection for proper async cleanup
- Simplify redundant mask bit check in WsReadInfo
- Remove unused WsGuid and CompressLastBlock dead code from WsConstants
- Document single-reader assumption on WsConnection read-side state

2026-02-23 05:27:36 -05:00

Joseph Doherty

72f60054ed

feat: add WebSocket protocol constants (RFC 6455)

Port WsConstants from golang/nats-server/server/websocket.go lines 41-106.
Includes opcodes, frame header bits, close status codes, compression
constants, header names, path routing, and the WsClientKind enum.

2026-02-23 04:33:04 -05:00

2 Commits