dohertj2/natsdotnet
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix E2E test gaps and add comprehensive E2E + parity test suites

Browse Source 
- Fix pull consumer fetch: send original stream subject in HMSG (not inbox)
  so NATS client distinguishes data messages from control messages
- Fix MaxAge expiry: add background timer in StreamManager for periodic pruning
- Fix JetStream wire format: Go-compatible anonymous objects with string enums,
  proper offset-based pagination for stream/consumer list APIs
- Add 42 E2E black-box tests (core messaging, auth, TLS, accounts, JetStream)
- Add ~1000 parity tests across all subsystems (gaps closure)
- Update gap inventory docs to reflect implementation status
This commit is contained in:
Joseph Doherty
2026-03-12 14:09:23 -04:00
parent 79c1ee8776
commit c30e67a69d
226 changed files with 17801 additions and 709 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
tests/NATS.Server.Tests/Server/UtilitiesAndRateCounterParityBatch1Tests.cs Normal file
View File

@@ -0,0 +1,53 @@
using System.Net.Sockets;
using NATS.Server.Routes;
using NATS.Server.Server;
namespace NATS.Server.Tests.Server;
public class UtilitiesAndRateCounterParityBatch1Tests
{
[Fact]
public void ParseHostPort_uses_default_port_for_missing_zero_and_minus_one()
{
ServerUtilities.ParseHostPort("127.0.0.1", 4222).ShouldBe(("127.0.0.1", 4222));
ServerUtilities.ParseHostPort("127.0.0.1:0", 4222).ShouldBe(("127.0.0.1", 4222));
ServerUtilities.ParseHostPort("127.0.0.1:-1", 4222).ShouldBe(("127.0.0.1", 4222));
ServerUtilities.ParseHostPort(":4333", 4222).ShouldBe(("", 4333));
}
[Fact]
public void RedactUrl_helpers_redact_password_for_single_and_list_inputs()
{
ServerUtilities.RedactUrlString("nats://foo:bar@example.com:4222")
.ShouldBe("nats://foo:xxxxx@example.com:4222");
ServerUtilities.RedactUrlString("nats://example.com:4222")
.ShouldBe("nats://example.com:4222");
var redacted = ServerUtilities.RedactUrlList(
["nats://a:b@one:4222", "nats://noauth:4223"]);
redacted[0].ShouldBe("nats://a:xxxxx@one:4222");
redacted[1].ShouldBe("nats://noauth:4223");
}
[Fact]
public void RateCounter_allow_and_count_blocked_match_go_behavior()
{
var rc = new RateCounter(2);
rc.Allow().ShouldBeTrue();
rc.Allow().ShouldBeTrue();
rc.Allow().ShouldBeFalse();
rc.Allow().ShouldBeFalse();
rc.CountBlocked().ShouldBe((ulong)2);
rc.CountBlocked().ShouldBe((ulong)0); // reset on read
}
[Fact]
public void CreateRouteDialSocket_disables_keepalive()
{
using var socket = RouteManager.CreateRouteDialSocket();
var keepAlive = Convert.ToInt32(socket.GetSocketOption(SocketOptionLevel.Socket, SocketOptionName.KeepAlive));
keepAlive.ShouldBe(0);
}
}