dohertj2/natsdotnet
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: move stale connection stat increments to detection site in RunPingTimerAsync

Browse Source
This commit is contained in:
Joseph Doherty
2026-02-23 00:41:12 -05:00
parent cd4ae3cce6
commit b7c0e321d9
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/NATS.Server/NatsClient.cs
View File

@@ -642,6 +642,8 @@ public sealed class NatsClient : IDisposable
if (Volatile.Read(ref _pingsOut) + 1 > _options.MaxPingsOut) if (Volatile.Read(ref _pingsOut) + 1 > _options.MaxPingsOut)
{ {
_logger.LogDebug("Client {ClientId} stale connection -- closing", Id); _logger.LogDebug("Client {ClientId} stale connection -- closing", Id);
Interlocked.Increment(ref _serverStats.StaleConnections);
Interlocked.Increment(ref _serverStats.StaleConnectionClients);
await SendErrAndCloseAsync(NatsProtocol.ErrStaleConnection, ClientClosedReason.StaleConnection); await SendErrAndCloseAsync(NatsProtocol.ErrStaleConnection, ClientClosedReason.StaleConnection);
return; return;
} }
@@ -682,12 +684,6 @@ public sealed class NatsClient : IDisposable
break; break;
} }
if (reason == ClientClosedReason.StaleConnection)
{
Interlocked.Increment(ref _serverStats.StaleConnections);
Interlocked.Increment(ref _serverStats.StaleConnectionClients);
}
_logger.LogDebug("Client {ClientId} connection closed: {CloseReason}", Id, reason); _logger.LogDebug("Client {ClientId} connection closed: {CloseReason}", Id, reason);
} }