refactor: rename remaining tests to NATS.Server.Core.Tests

- Rename tests/NATS.Server.Tests -> tests/NATS.Server.Core.Tests - Update solution file, InternalsVisibleTo, and csproj references - Remove JETSTREAM_INTEGRATION_MATRIX and NATS.NKeys from csproj (moved to JetStream.Tests and Auth.Tests) - Update all namespaces from NATS.Server.Tests.* to NATS.Server.Core.Tests.* - Replace private GetFreePort/ReadUntilAsync helpers with TestUtilities calls - Fix stale namespace in Transport.Tests/NetworkingGoParityTests.cs
2026-03-12 16:14:02 -04:00
parent 78b4bc2486
commit 7fbffffd05
114 changed files with 576 additions and 1121 deletions
--- a/tests/NATS.Server.Core.Tests/VerboseModeTests.cs
+++ b/tests/NATS.Server.Core.Tests/VerboseModeTests.cs
@@ -0,0 +1,119 @@
+using System.Net;
+using System.Net.Sockets;
+using System.Text;
+using Microsoft.Extensions.Logging.Abstractions;
+using NATS.Server;
+using NATS.Server.TestUtilities;
+
+namespace NATS.Server.Core.Tests;
+
+public class VerboseModeTests : IAsyncLifetime
+{
+    private readonly NatsServer _server;
+    private readonly int _port;
+    private readonly CancellationTokenSource _cts = new();
+
+    public VerboseModeTests()
+    {
+        _port = TestPortAllocator.GetFreePort();
+        _server = new NatsServer(new NatsOptions { Port = _port }, NullLoggerFactory.Instance);
+    }
+
+    public async Task InitializeAsync()
+    {
+        _ = _server.StartAsync(_cts.Token);
+        await _server.WaitForReadyAsync();
+    }
+
+    public async Task DisposeAsync()
+    {
+        await _cts.CancelAsync();
+        _server.Dispose();
+    }
+
+
+    private async Task<Socket> ConnectClientAsync()
+    {
+        var sock = new Socket(AddressFamily.InterNetwork, SocketType.Stream, ProtocolType.Tcp);
+        await sock.ConnectAsync(IPAddress.Loopback, _port);
+        return sock;
+    }
+
+
+    [Fact]
+    public async Task Verbose_mode_sends_OK_after_CONNECT()
+    {
+        using var client = await ConnectClientAsync();
+
+        // Read INFO
+        await SocketTestHelper.ReadUntilAsync(client, "\r\n");
+
+        // Send CONNECT with verbose:true
+        await client.SendAsync(Encoding.ASCII.GetBytes("CONNECT {\"verbose\":true}\r\n"));
+
+        // Should receive +OK after CONNECT
+        var response = await SocketTestHelper.ReadUntilAsync(client, "+OK\r\n");
+        response.ShouldContain("+OK\r\n");
+    }
+
+    [Fact]
+    public async Task Verbose_mode_sends_OK_after_SUB()
+    {
+        using var client = await ConnectClientAsync();
+
+        // Read INFO
+        await SocketTestHelper.ReadUntilAsync(client, "\r\n");
+
+        // Send CONNECT with verbose:true, then SUB
+        await client.SendAsync(Encoding.ASCII.GetBytes("CONNECT {\"verbose\":true}\r\n"));
+
+        // Read +OK from CONNECT
+        await SocketTestHelper.ReadUntilAsync(client, "+OK\r\n");
+
+        // Send SUB
+        await client.SendAsync(Encoding.ASCII.GetBytes("SUB foo 1\r\n"));
+
+        // Should receive +OK after SUB
+        var response = await SocketTestHelper.ReadUntilAsync(client, "+OK\r\n");
+        response.ShouldContain("+OK\r\n");
+    }
+
+    [Fact]
+    public async Task Verbose_mode_sends_OK_after_PUB()
+    {
+        using var client = await ConnectClientAsync();
+
+        // Read INFO
+        await SocketTestHelper.ReadUntilAsync(client, "\r\n");
+
+        // Send CONNECT with verbose:true
+        await client.SendAsync(Encoding.ASCII.GetBytes("CONNECT {\"verbose\":true}\r\n"));
+
+        // Read +OK from CONNECT
+        await SocketTestHelper.ReadUntilAsync(client, "+OK\r\n");
+
+        // Send PUB
+        await client.SendAsync(Encoding.ASCII.GetBytes("PUB foo 5\r\nHello\r\n"));
+
+        // Should receive +OK after PUB
+        var response = await SocketTestHelper.ReadUntilAsync(client, "+OK\r\n");
+        response.ShouldContain("+OK\r\n");
+    }
+
+    [Fact]
+    public async Task Non_verbose_mode_does_not_send_OK()
+    {
+        using var client = await ConnectClientAsync();
+
+        // Read INFO
+        await SocketTestHelper.ReadUntilAsync(client, "\r\n");
+
+        // Send CONNECT without verbose (default false), then SUB, then PING
+        await client.SendAsync(Encoding.ASCII.GetBytes("CONNECT {}\r\nSUB foo 1\r\nPING\r\n"));
+
+        // Should receive PONG but NOT +OK
+        var response = await SocketTestHelper.ReadUntilAsync(client, "PONG\r\n");
+        response.ShouldContain("PONG\r\n");
+        response.ShouldNotContain("+OK");
+    }
+}