refactor: rename remaining tests to NATS.Server.Core.Tests

- Rename tests/NATS.Server.Tests -> tests/NATS.Server.Core.Tests - Update solution file, InternalsVisibleTo, and csproj references - Remove JETSTREAM_INTEGRATION_MATRIX and NATS.NKeys from csproj (moved to JetStream.Tests and Auth.Tests) - Update all namespaces from NATS.Server.Tests.* to NATS.Server.Core.Tests.* - Replace private GetFreePort/ReadUntilAsync helpers with TestUtilities calls - Fix stale namespace in Transport.Tests/NetworkingGoParityTests.cs
2026-03-12 16:14:02 -04:00
parent 78b4bc2486
commit 7fbffffd05
114 changed files with 576 additions and 1121 deletions
--- a/tests/NATS.Server.Core.Tests/ClientTests.cs
+++ b/tests/NATS.Server.Core.Tests/ClientTests.cs
@@ -0,0 +1,135 @@
+using System.IO.Pipelines;
+using System.Net;
+using System.Net.Sockets;
+using System.Text;
+using System.Text.Json;
+using Microsoft.Extensions.Logging;
+using Microsoft.Extensions.Logging.Abstractions;
+using NATS.Server;
+using NATS.Server.Auth;
+using NATS.Server.Protocol;
+
+namespace NATS.Server.Core.Tests;
+
+public class ClientTests : IAsyncDisposable
+{
+    private readonly Socket _serverSocket;
+    private readonly Socket _clientSocket;
+    private readonly NatsClient _natsClient;
+    private readonly CancellationTokenSource _cts = new();
+
+    public ClientTests()
+    {
+        // Create connected socket pair via loopback
+        var listener = new Socket(AddressFamily.InterNetwork, SocketType.Stream, ProtocolType.Tcp);
+        listener.Bind(new IPEndPoint(IPAddress.Loopback, 0));
+        listener.Listen(1);
+        var port = ((IPEndPoint)listener.LocalEndPoint!).Port;
+
+        _clientSocket = new Socket(AddressFamily.InterNetwork, SocketType.Stream, ProtocolType.Tcp);
+        _clientSocket.Connect(IPAddress.Loopback, port);
+        _serverSocket = listener.Accept();
+        listener.Dispose();
+
+        var serverInfo = new ServerInfo
+        {
+            ServerId = "test",
+            ServerName = "test",
+            Version = "0.1.0",
+            Host = "127.0.0.1",
+            Port = 4222,
+        };
+
+        var authService = AuthService.Build(new NatsOptions());
+        _natsClient = new NatsClient(1, new NetworkStream(_serverSocket, ownsSocket: false), _serverSocket, new NatsOptions(), serverInfo, authService, null, NullLogger.Instance, new ServerStats());
+    }
+
+    public async ValueTask DisposeAsync()
+    {
+        await _cts.CancelAsync();
+        _natsClient.Dispose();
+        _clientSocket.Dispose();
+    }
+
+    [Fact]
+    public async Task Client_sends_INFO_on_start()
+    {
+        var runTask = _natsClient.RunAsync(_cts.Token);
+
+        // Read from client socket -- should get INFO
+        var buf = new byte[4096];
+        var n = await _clientSocket.ReceiveAsync(buf, SocketFlags.None);
+        var response = Encoding.ASCII.GetString(buf, 0, n);
+
+        response.ShouldStartWith("INFO ");
+        response.ShouldContain("server_id");
+        response.ShouldContain("\r\n");
+
+        await _cts.CancelAsync();
+    }
+
+    [Fact]
+    public async Task Client_responds_PONG_to_PING()
+    {
+        var runTask = _natsClient.RunAsync(_cts.Token);
+
+        // Read INFO
+        var buf = new byte[4096];
+        await _clientSocket.ReceiveAsync(buf, SocketFlags.None);
+
+        // Send CONNECT then PING
+        await _clientSocket.SendAsync(Encoding.ASCII.GetBytes("CONNECT {}\r\nPING\r\n"));
+
+        // Read response -- should get PONG
+        var n = await _clientSocket.ReceiveAsync(buf, SocketFlags.None);
+        var response = Encoding.ASCII.GetString(buf, 0, n);
+
+        response.ShouldContain("PONG\r\n");
+
+        await _cts.CancelAsync();
+    }
+
+    [Fact]
+    public async Task Client_SendErrAsync_writes_correct_wire_format()
+    {
+        var runTask = _natsClient.RunAsync(_cts.Token);
+
+        // Read INFO first
+        var buf = new byte[4096];
+        using var readCts = new CancellationTokenSource(TimeSpan.FromSeconds(5));
+        await _clientSocket.ReceiveAsync(buf, SocketFlags.None, readCts.Token);
+
+        // Trigger SendErr
+        _natsClient.SendErr("Invalid Subject");
+
+        var n = await _clientSocket.ReceiveAsync(buf, SocketFlags.None, readCts.Token);
+        var response = Encoding.ASCII.GetString(buf, 0, n);
+
+        response.ShouldBe("-ERR 'Invalid Subject'\r\n");
+
+        await _cts.CancelAsync();
+    }
+
+    [Fact]
+    public async Task Client_SendErrAndCloseAsync_sends_error_then_disconnects()
+    {
+        var runTask = _natsClient.RunAsync(_cts.Token);
+
+        // Read INFO first
+        var buf = new byte[4096];
+        using var readCts = new CancellationTokenSource(TimeSpan.FromSeconds(5));
+        await _clientSocket.ReceiveAsync(buf, SocketFlags.None, readCts.Token);
+
+        // Trigger SendErrAndCloseAsync
+        await _natsClient.SendErrAndCloseAsync("maximum connections exceeded");
+
+        var n = await _clientSocket.ReceiveAsync(buf, SocketFlags.None, readCts.Token);
+        var response = Encoding.ASCII.GetString(buf, 0, n);
+
+        response.ShouldBe("-ERR 'maximum connections exceeded'\r\n");
+
+        // Connection should be closed -- next read returns 0
+        n = await _clientSocket.ReceiveAsync(buf, SocketFlags.None, readCts.Token);
+        n.ShouldBe(0);
+    }
+}