feat: phase B distributed substrate test parity — 39 new tests across 5 subsystems

FileStore basics (4), MemStore/retention (10), RAFT election/append (16),
config reload parity (3), monitoring endpoints varz/connz/healthz (6).
972 total tests passing, 0 failures.
This commit is contained in:
Joseph Doherty
2026-02-23 19:41:30 -05:00
parent 7ffee8741f
commit 28d379e6b7
9 changed files with 1552 additions and 0 deletions

View File

@@ -0,0 +1,176 @@
// Ported from golang/nats-server/server/monitor_test.go
// TestMonitorConnz — verify /connz lists active connections with correct fields.
// TestMonitorConnzSortedByBytesAndMsgs — verify /connz?sort=bytes_to ordering.
using System.Net;
using System.Net.Http.Json;
using System.Net.Sockets;
using Microsoft.Extensions.Logging.Abstractions;
using NATS.Server.Monitoring;
namespace NATS.Server.Tests;
public class ConnzParityTests : IAsyncLifetime
{
private readonly NatsServer _server;
private readonly int _natsPort;
private readonly int _monitorPort;
private readonly CancellationTokenSource _cts = new();
private readonly HttpClient _http = new();
public ConnzParityTests()
{
_natsPort = GetFreePort();
_monitorPort = GetFreePort();
_server = new NatsServer(
new NatsOptions { Port = _natsPort, MonitorPort = _monitorPort },
NullLoggerFactory.Instance);
}
public async Task InitializeAsync()
{
_ = _server.StartAsync(_cts.Token);
await _server.WaitForReadyAsync();
for (var i = 0; i < 50; i++)
{
try
{
var probe = await _http.GetAsync($"http://127.0.0.1:{_monitorPort}/healthz");
if (probe.IsSuccessStatusCode) break;
}
catch (HttpRequestException) { }
await Task.Delay(50);
}
}
public async Task DisposeAsync()
{
_http.Dispose();
await _cts.CancelAsync();
_server.Dispose();
}
/// <summary>
/// Corresponds to Go TestMonitorConnz.
/// Verifies /connz lists active connections and that per-connection fields
/// (ip, port, lang, version, uptime) are populated once 2 clients are connected.
/// </summary>
[Fact]
public async Task Connz_lists_active_connections()
{
var sockets = new List<Socket>();
try
{
// Connect 2 named clients
for (var i = 0; i < 2; i++)
{
var sock = new Socket(AddressFamily.InterNetwork, SocketType.Stream, ProtocolType.Tcp);
await sock.ConnectAsync(new IPEndPoint(IPAddress.Loopback, _natsPort));
var ns = new NetworkStream(sock);
var buf = new byte[4096];
_ = await ns.ReadAsync(buf); // consume INFO
var connect = $"CONNECT {{\"name\":\"client-{i}\",\"lang\":\"csharp\",\"version\":\"1.0\"}}\r\n";
await ns.WriteAsync(System.Text.Encoding.ASCII.GetBytes(connect));
await ns.FlushAsync();
sockets.Add(sock);
}
await Task.Delay(200);
var response = await _http.GetAsync($"http://127.0.0.1:{_monitorPort}/connz");
response.StatusCode.ShouldBe(HttpStatusCode.OK);
var connz = await response.Content.ReadFromJsonAsync<Connz>();
connz.ShouldNotBeNull();
// Both clients must appear
connz.NumConns.ShouldBeGreaterThanOrEqualTo(2);
connz.Conns.Length.ShouldBeGreaterThanOrEqualTo(2);
// Verify per-connection identity fields on one of our named connections
var conn = connz.Conns.First(c => c.Name == "client-0");
conn.Ip.ShouldNotBeNullOrEmpty();
conn.Port.ShouldBeGreaterThan(0);
conn.Lang.ShouldBe("csharp");
conn.Version.ShouldBe("1.0");
conn.Uptime.ShouldNotBeNullOrEmpty();
}
finally
{
foreach (var s in sockets) s.Dispose();
}
}
/// <summary>
/// Corresponds to Go TestMonitorConnzSortedByBytesAndMsgs (bytes_to / out_bytes ordering).
/// Connects a high-traffic client that publishes 100 messages and 3 baseline clients,
/// then verifies /connz?sort=bytes_to returns connections in descending out_bytes order.
/// </summary>
[Fact]
public async Task Connz_sort_by_bytes()
{
var sockets = new List<(Socket Sock, NetworkStream Ns)>();
try
{
// Connect a subscriber first so that published messages are delivered (and counted as out_bytes)
var subSock = new Socket(AddressFamily.InterNetwork, SocketType.Stream, ProtocolType.Tcp);
await subSock.ConnectAsync(new IPEndPoint(IPAddress.Loopback, _natsPort));
var subNs = new NetworkStream(subSock);
var subBuf = new byte[4096];
_ = await subNs.ReadAsync(subBuf);
await subNs.WriteAsync("CONNECT {}\r\nSUB foo 1\r\n"u8.ToArray());
await subNs.FlushAsync();
sockets.Add((subSock, subNs));
// High-traffic publisher: publish 100 messages to "foo"
var highSock = new Socket(AddressFamily.InterNetwork, SocketType.Stream, ProtocolType.Tcp);
await highSock.ConnectAsync(new IPEndPoint(IPAddress.Loopback, _natsPort));
var highNs = new NetworkStream(highSock);
var highBuf = new byte[4096];
_ = await highNs.ReadAsync(highBuf);
await highNs.WriteAsync("CONNECT {}\r\n"u8.ToArray());
await highNs.FlushAsync();
for (var i = 0; i < 100; i++)
await highNs.WriteAsync("PUB foo 11\r\nHello World\r\n"u8.ToArray());
await highNs.FlushAsync();
sockets.Add((highSock, highNs));
// 3 baseline clients — no traffic beyond CONNECT
for (var i = 0; i < 3; i++)
{
var sock = new Socket(AddressFamily.InterNetwork, SocketType.Stream, ProtocolType.Tcp);
await sock.ConnectAsync(new IPEndPoint(IPAddress.Loopback, _natsPort));
var ns = new NetworkStream(sock);
var buf = new byte[4096];
_ = await ns.ReadAsync(buf);
await ns.WriteAsync("CONNECT {}\r\n"u8.ToArray());
await ns.FlushAsync();
sockets.Add((sock, ns));
}
await Task.Delay(300);
var response = await _http.GetAsync($"http://127.0.0.1:{_monitorPort}/connz?sort=bytes_to");
response.StatusCode.ShouldBe(HttpStatusCode.OK);
var connz = await response.Content.ReadFromJsonAsync<Connz>();
connz.ShouldNotBeNull();
connz.Conns.Length.ShouldBeGreaterThanOrEqualTo(2);
// The first entry must have at least as many out_bytes as the second (descending order)
connz.Conns[0].OutBytes.ShouldBeGreaterThanOrEqualTo(connz.Conns[1].OutBytes);
}
finally
{
foreach (var (s, _) in sockets) s.Dispose();
}
}
private static int GetFreePort()
{
using var sock = new Socket(AddressFamily.InterNetwork, SocketType.Stream, ProtocolType.Tcp);
sock.Bind(new IPEndPoint(IPAddress.Loopback, 0));
return ((IPEndPoint)sock.LocalEndPoint!).Port;
}
}

View File

@@ -0,0 +1,82 @@
// Ported from golang/nats-server/server/monitor_test.go
// TestMonitorHealthzStatusOK — verify /healthz returns HTTP 200 with status "ok".
using System.Net;
using System.Net.Sockets;
using Microsoft.Extensions.Logging.Abstractions;
namespace NATS.Server.Tests;
public class HealthzParityTests : IAsyncLifetime
{
private readonly NatsServer _server;
private readonly int _monitorPort;
private readonly CancellationTokenSource _cts = new();
private readonly HttpClient _http = new();
public HealthzParityTests()
{
_monitorPort = GetFreePort();
_server = new NatsServer(
new NatsOptions { Port = 0, MonitorPort = _monitorPort },
NullLoggerFactory.Instance);
}
public async Task InitializeAsync()
{
_ = _server.StartAsync(_cts.Token);
await _server.WaitForReadyAsync();
for (var i = 0; i < 50; i++)
{
try
{
var probe = await _http.GetAsync($"http://127.0.0.1:{_monitorPort}/healthz");
if (probe.IsSuccessStatusCode) break;
}
catch (HttpRequestException) { }
await Task.Delay(50);
}
}
public async Task DisposeAsync()
{
_http.Dispose();
await _cts.CancelAsync();
_server.Dispose();
}
/// <summary>
/// Corresponds to Go TestMonitorHealthzStatusOK.
/// Verifies GET /healthz returns HTTP 200 OK, indicating the server is healthy.
/// </summary>
[Fact]
public async Task Healthz_returns_ok()
{
var response = await _http.GetAsync($"http://127.0.0.1:{_monitorPort}/healthz");
response.StatusCode.ShouldBe(HttpStatusCode.OK);
}
/// <summary>
/// Corresponds to Go TestMonitorHealthzStatusOK / checkHealthStatus.
/// Verifies the /healthz response body contains the "ok" status string,
/// matching the Go server's HealthStatus.Status = "ok" field.
/// </summary>
[Fact]
public async Task Healthz_returns_status_ok_json()
{
var response = await _http.GetAsync($"http://127.0.0.1:{_monitorPort}/healthz");
response.StatusCode.ShouldBe(HttpStatusCode.OK);
var body = await response.Content.ReadAsStringAsync();
// The .NET monitoring server returns Results.Ok("ok") which serializes as the JSON string "ok".
// This corresponds to the Go server's HealthStatus.Status = "ok".
body.ShouldContain("ok");
}
private static int GetFreePort()
{
using var sock = new Socket(AddressFamily.InterNetwork, SocketType.Stream, ProtocolType.Tcp);
sock.Bind(new IPEndPoint(IPAddress.Loopback, 0));
return ((IPEndPoint)sock.LocalEndPoint!).Port;
}
}

View File

@@ -0,0 +1,137 @@
// Ported from golang/nats-server/server/monitor_test.go
// TestMonitorHandleVarz — verify /varz returns valid server identity fields and tracks message stats.
using System.Net;
using System.Net.Http.Json;
using System.Net.Sockets;
using Microsoft.Extensions.Logging.Abstractions;
using NATS.Server.Monitoring;
namespace NATS.Server.Tests;
public class VarzParityTests : IAsyncLifetime
{
private readonly NatsServer _server;
private readonly int _natsPort;
private readonly int _monitorPort;
private readonly CancellationTokenSource _cts = new();
private readonly HttpClient _http = new();
public VarzParityTests()
{
_natsPort = GetFreePort();
_monitorPort = GetFreePort();
_server = new NatsServer(
new NatsOptions { Port = _natsPort, MonitorPort = _monitorPort },
NullLoggerFactory.Instance);
}
public async Task InitializeAsync()
{
_ = _server.StartAsync(_cts.Token);
await _server.WaitForReadyAsync();
for (var i = 0; i < 50; i++)
{
try
{
var probe = await _http.GetAsync($"http://127.0.0.1:{_monitorPort}/healthz");
if (probe.IsSuccessStatusCode) break;
}
catch (HttpRequestException) { }
await Task.Delay(50);
}
}
public async Task DisposeAsync()
{
_http.Dispose();
await _cts.CancelAsync();
_server.Dispose();
}
/// <summary>
/// Corresponds to Go TestMonitorHandleVarz (first block, mode=0).
/// Verifies the /varz endpoint returns valid JSON containing required server identity fields:
/// server_id, version, now, start, host, port, max_payload, mem, cores.
/// </summary>
[Fact]
public async Task Varz_returns_valid_json_with_server_info()
{
var response = await _http.GetAsync($"http://127.0.0.1:{_monitorPort}/varz");
response.StatusCode.ShouldBe(HttpStatusCode.OK);
var varz = await response.Content.ReadFromJsonAsync<Varz>();
varz.ShouldNotBeNull();
// server_id must be present and non-empty
varz.Id.ShouldNotBeNullOrEmpty();
// version must be present
varz.Version.ShouldNotBeNullOrEmpty();
// now must be a plausible timestamp (not default DateTime.MinValue)
varz.Now.ShouldBeGreaterThan(DateTime.MinValue);
// start must be within a reasonable window of now
(DateTime.UtcNow - varz.Start).ShouldBeLessThan(TimeSpan.FromSeconds(30));
// host and port must reflect server configuration
varz.Host.ShouldNotBeNullOrEmpty();
varz.Port.ShouldBe(_natsPort);
// max_payload is 1 MB by default (Go reference: defaultMaxPayload = 1MB)
varz.MaxPayload.ShouldBe(1024 * 1024);
// uptime must be non-empty
varz.Uptime.ShouldNotBeNullOrEmpty();
// runtime metrics must be populated
varz.Mem.ShouldBeGreaterThan(0L);
varz.Cores.ShouldBeGreaterThan(0);
}
/// <summary>
/// Corresponds to Go TestMonitorHandleVarz (second block after connecting a client).
/// Verifies /varz correctly tracks connections, total_connections, in_msgs, in_bytes
/// after a client connects, subscribes, and publishes a message.
/// </summary>
[Fact]
public async Task Varz_tracks_connections_and_messages()
{
using var sock = new Socket(AddressFamily.InterNetwork, SocketType.Stream, ProtocolType.Tcp);
await sock.ConnectAsync(new IPEndPoint(IPAddress.Loopback, _natsPort));
var buf = new byte[4096];
_ = await sock.ReceiveAsync(buf, SocketFlags.None); // consume INFO
// CONNECT + SUB + PUB "hello" (5 bytes) to "test"
var cmd = "CONNECT {}\r\nSUB test 1\r\nPUB test 5\r\nhello\r\n"u8.ToArray();
await sock.SendAsync(cmd, SocketFlags.None);
await Task.Delay(200);
var response = await _http.GetAsync($"http://127.0.0.1:{_monitorPort}/varz");
response.StatusCode.ShouldBe(HttpStatusCode.OK);
var varz = await response.Content.ReadFromJsonAsync<Varz>();
varz.ShouldNotBeNull();
// At least 1 active connection
varz.Connections.ShouldBeGreaterThanOrEqualTo(1);
// Total connections must have been counted
varz.TotalConnections.ShouldBeGreaterThanOrEqualTo(1UL);
// in_msgs: at least the 1 PUB we sent
varz.InMsgs.ShouldBeGreaterThanOrEqualTo(1L);
// in_bytes: at least 5 bytes ("hello")
varz.InBytes.ShouldBeGreaterThanOrEqualTo(5L);
}
private static int GetFreePort()
{
using var sock = new Socket(AddressFamily.InterNetwork, SocketType.Stream, ProtocolType.Tcp);
sock.Bind(new IPEndPoint(IPAddress.Loopback, 0));
return ((IPEndPoint)sock.LocalEndPoint!).Port;
}
}