Joseph Doherty
dc7fd16dd5
CLI-40: port the exact-secret credential scrub to Rust/Java/.NET (Go/Python
already did it). AuthenticateUser/WriteSecured(2) helpers now redact the exact
caller-supplied secret from any surfaced error, as defense-in-depth on top of the
by-construction guarantee. Rust hand-writes a redacting Debug (derived Debug would
leak the reply); Java/.NET rebuild the same exception type with the redacted
message and do not carry the secret-bearing original forward (so ToString/stack
traces stay clean too).
CLI-41: uniform malformed-reply contract for AuthenticateUser/ArchestrAUserToId/
AddBufferedItem across all five clients — typed payload, else a present int32
return_value, else a typed malformed-reply error. Fixes Go/Java silent-0, .NET
NRE, and Rust's own internal inconsistency.
CLI-44: the Go event goroutine's Recv-error path now uses a non-blocking
sendTerminalEventResult on the reserved slot, so a genuine terminal stream error
is reported as itself instead of being mislabeled ErrSlowConsumer under overflow.
Riders from the CLI-37/38 review: (a) .NET ToDiagnosticSummary and Python
_mxaccess_message surface the raw success member (diagnostics-only parity with
Rust); (b) the status-conversion fixture carries an independent wantSuccess
boolean and the Go/.NET fixture tests assert against it instead of recomputing
the formula under test.
Shared fixtures (authenticate-user.{echoed-credential,missing-payload,
return-value-only}.reply.json) + manifest + ClientBehaviorFixtures.md +
ClientLibrariesDesign.md updated in the same change. Tracking: CLI-40/41/44 -> Done.
75 lines
2.1 KiB
Go
75 lines
2.1 KiB
Go
package mxgateway
|
|
|
|
import (
|
|
"encoding/json"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
pb "gitea.dohertylan.com/dohertj2/mxaccessgw/clients/go/internal/generated"
|
|
"google.golang.org/protobuf/encoding/protojson"
|
|
)
|
|
|
|
func TestValueConversionFixtures(t *testing.T) {
|
|
data, err := os.ReadFile(filepath.Join("..", "..", "proto", "fixtures", "behavior", "values", "value-conversion-cases.json"))
|
|
if err != nil {
|
|
t.Fatalf("read fixture: %v", err)
|
|
}
|
|
|
|
var fixture struct {
|
|
Cases []struct {
|
|
ID string `json:"id"`
|
|
ExpectedKind string `json:"expectedKind"`
|
|
Value json.RawMessage `json:"value"`
|
|
} `json:"cases"`
|
|
}
|
|
if err := json.Unmarshal(data, &fixture); err != nil {
|
|
t.Fatalf("parse fixture manifest: %v", err)
|
|
}
|
|
|
|
for _, tc := range fixture.Cases {
|
|
t.Run(tc.ID, func(t *testing.T) {
|
|
var value pb.MxValue
|
|
if err := protojson.Unmarshal(tc.Value, &value); err != nil {
|
|
t.Fatalf("parse value: %v", err)
|
|
}
|
|
if _, err := NativeValue(&value); err != nil {
|
|
t.Fatalf("NativeValue() error = %v", err)
|
|
}
|
|
if got := value.ProtoReflect().WhichOneof(value.ProtoReflect().Descriptor().Oneofs().ByName("kind")).JSONName(); got != tc.ExpectedKind {
|
|
t.Fatalf("kind = %q, want %q", got, tc.ExpectedKind)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestStatusConversionFixtures(t *testing.T) {
|
|
data, err := os.ReadFile(filepath.Join("..", "..", "proto", "fixtures", "behavior", "statuses", "status-conversion-cases.json"))
|
|
if err != nil {
|
|
t.Fatalf("read fixture: %v", err)
|
|
}
|
|
|
|
var fixture struct {
|
|
Cases []struct {
|
|
ID string `json:"id"`
|
|
WantSuccess bool `json:"wantSuccess"`
|
|
Status json.RawMessage `json:"status"`
|
|
} `json:"cases"`
|
|
}
|
|
if err := json.Unmarshal(data, &fixture); err != nil {
|
|
t.Fatalf("parse fixture manifest: %v", err)
|
|
}
|
|
|
|
for _, tc := range fixture.Cases {
|
|
t.Run(tc.ID, func(t *testing.T) {
|
|
var status pb.MxStatusProxy
|
|
if err := protojson.Unmarshal(tc.Status, &status); err != nil {
|
|
t.Fatalf("parse status: %v", err)
|
|
}
|
|
if got := StatusSucceeded(&status); got != tc.WantSuccess {
|
|
t.Fatalf("StatusSucceeded() = %v, want %v", got, tc.WantSuccess)
|
|
}
|
|
})
|
|
}
|
|
}
|