Joseph Doherty
8023eccfa6
Client.Dotnet-001: MapRpcException typed only Unauthenticated and PermissionDenied; every other gRPC status collapsed to an untyped exception with the status code discarded. Added a nullable StatusCode to MxGatewayException, extracted the duplicated mappers into a shared RpcExceptionMapper that records the code for every status, and documented it. Client.Dotnet-002: the production retry branch (MxGatewayException wrapping RpcException) was never exercised. FakeGatewayTransport gained a MapTransportExceptions mode that runs thrown RpcExceptions through RpcExceptionMapper exactly as the production transport does. Client.Dotnet-003: MxGatewaySession.DisposeAsync disposed _closeLock while a concurrent CloseAsync could be parked in WaitAsync. DisposeAsync now drains in-flight CloseAsync callers before disposing the semaphore; the client's _disposed flag is accessed via Interlocked. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
56 lines
2.1 KiB
C#
56 lines
2.1 KiB
C#
using Grpc.Core;
|
|
|
|
namespace MxGateway.Client;
|
|
|
|
/// <summary>
|
|
/// Maps low-level <see cref="RpcException"/>s raised by the gRPC stack to the client's
|
|
/// native exception hierarchy. Shared by every gateway and Galaxy Repository transport
|
|
/// so the gRPC-to-native translation has exactly one implementation.
|
|
/// </summary>
|
|
internal static class RpcExceptionMapper
|
|
{
|
|
/// <summary>
|
|
/// Translates a <see cref="RpcException"/> into the most specific native exception type.
|
|
/// </summary>
|
|
/// <param name="exception">The gRPC exception to translate.</param>
|
|
/// <param name="cancellationToken">
|
|
/// The cancellation token of the originating call; used to distinguish a caller-driven
|
|
/// cancellation from a server-side <see cref="StatusCode.Cancelled"/> status.
|
|
/// </param>
|
|
/// <returns>
|
|
/// An <see cref="OperationCanceledException"/> when the call was cancelled, a typed
|
|
/// authentication/authorization exception for auth statuses, or an
|
|
/// <see cref="MxGatewayException"/> carrying the originating gRPC <see cref="StatusCode"/>.
|
|
/// </returns>
|
|
public static Exception Map(
|
|
RpcException exception,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
ArgumentNullException.ThrowIfNull(exception);
|
|
|
|
if (cancellationToken.IsCancellationRequested || exception.StatusCode == StatusCode.Cancelled)
|
|
{
|
|
return new OperationCanceledException(
|
|
exception.Status.Detail,
|
|
exception,
|
|
cancellationToken);
|
|
}
|
|
|
|
return exception.StatusCode switch
|
|
{
|
|
StatusCode.Unauthenticated => new MxGatewayAuthenticationException(
|
|
exception.Status.Detail,
|
|
statusCode: exception.StatusCode,
|
|
innerException: exception),
|
|
StatusCode.PermissionDenied => new MxGatewayAuthorizationException(
|
|
exception.Status.Detail,
|
|
statusCode: exception.StatusCode,
|
|
innerException: exception),
|
|
_ => new MxGatewayException(
|
|
exception.Status.Detail,
|
|
exception.StatusCode,
|
|
exception),
|
|
};
|
|
}
|
|
}
|