Joseph Doherty
ae164ea34f
Set up the code review process scaffolding adapted to mxaccessgw and
record a full per-module review of every src/MxGateway.* project at
commit 6c64030.
- code-reviews/_template/findings.md: per-module findings template
- code-reviews/regen-readme.py: generates README.md from findings.md
files; --check fails if stale
- code-reviews/<Module>/findings.md: reviews for Contracts, Server,
Worker, Tests, Worker.Tests, IntegrationTests (74 findings:
1 Critical, 10 High, 23 Medium, 40 Low; all Open)
- code-reviews/README.md: generated cross-module index
- REVIEW-PROCESS.md: review process document
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1.8 KiB
1.8 KiB
Code Review — <Module>
| Field | Value |
|---|---|
| Module | src/MxGateway.<Module> |
| Reviewer | |
| Review date | |
| Commit reviewed | <short-sha> |
| Status | Not started |
| Open findings | 0 |
Checklist coverage
A comprehensive review completes every category, recording "No issues found" where a category produced nothing rather than leaving it blank.
| # | Category | Result |
|---|---|---|
| 1 | Correctness & logic bugs | pending |
| 2 | mxaccessgw conventions | pending |
| 3 | Concurrency & thread safety | pending |
| 4 | Error handling & resilience | pending |
| 5 | Security | pending |
| 6 | Performance & resource management | pending |
| 7 | Design-document adherence | pending |
| 8 | Code organization & conventions | pending |
| 9 | Testing coverage | pending |
| 10 | Documentation & comments | pending |
Findings
-001
| Field | Value |
|---|---|
| Severity | Critical / High / Medium / Low |
| Category | one of the 10 checklist categories |
| Location | path/to/File.cs:NN |
| Status | Open / In Progress / Resolved / Won't Fix / Deferred |
Description: What is wrong and why it matters.
Recommendation: Concrete suggested fix.
Resolution: (empty until closed; on close, record the fixing commit SHA, the date, and a one-line description of the fix)