Joseph Doherty
dc7fd16dd5
CLI-40: port the exact-secret credential scrub to Rust/Java/.NET (Go/Python
already did it). AuthenticateUser/WriteSecured(2) helpers now redact the exact
caller-supplied secret from any surfaced error, as defense-in-depth on top of the
by-construction guarantee. Rust hand-writes a redacting Debug (derived Debug would
leak the reply); Java/.NET rebuild the same exception type with the redacted
message and do not carry the secret-bearing original forward (so ToString/stack
traces stay clean too).
CLI-41: uniform malformed-reply contract for AuthenticateUser/ArchestrAUserToId/
AddBufferedItem across all five clients — typed payload, else a present int32
return_value, else a typed malformed-reply error. Fixes Go/Java silent-0, .NET
NRE, and Rust's own internal inconsistency.
CLI-44: the Go event goroutine's Recv-error path now uses a non-blocking
sendTerminalEventResult on the reserved slot, so a genuine terminal stream error
is reported as itself instead of being mislabeled ErrSlowConsumer under overflow.
Riders from the CLI-37/38 review: (a) .NET ToDiagnosticSummary and Python
_mxaccess_message surface the raw success member (diagnostics-only parity with
Rust); (b) the status-conversion fixture carries an independent wantSuccess
boolean and the Go/.NET fixture tests assert against it instead of recomputing
the formula under test.
Shared fixtures (authenticate-user.{echoed-credential,missing-payload,
return-value-only}.reply.json) + manifest + ClientBehaviorFixtures.md +
ClientLibrariesDesign.md updated in the same change. Tracking: CLI-40/41/44 -> Done.
75 lines
2.5 KiB
C#
75 lines
2.5 KiB
C#
using System.Text.Json;
|
|
using Google.Protobuf;
|
|
using ZB.MOM.WW.MxGateway.Client;
|
|
using ZB.MOM.WW.MxGateway.Contracts.Proto;
|
|
|
|
namespace ZB.MOM.WW.MxGateway.Client.Tests;
|
|
|
|
public sealed class MxStatusProxyExtensionsTests
|
|
{
|
|
/// <summary>Verifies that fixture statuses correctly project success and preserve raw integer fields.</summary>
|
|
[Fact]
|
|
public void FixtureStatuses_ProjectSuccessAndPreserveRawFields()
|
|
{
|
|
using JsonDocument document = JsonDocument.Parse(ReadFixture(
|
|
"statuses",
|
|
"status-conversion-cases.json"));
|
|
|
|
foreach (JsonElement testCase in document.RootElement.GetProperty("cases").EnumerateArray())
|
|
{
|
|
MxStatusProxy status = JsonParser.Default.Parse<MxStatusProxy>(
|
|
testCase.GetProperty("status").GetRawText());
|
|
|
|
bool wantSuccess = testCase.GetProperty("wantSuccess").GetBoolean();
|
|
Assert.Equal(wantSuccess, status.IsSuccess());
|
|
Assert.Equal(
|
|
testCase.GetProperty("status").GetProperty("rawCategory").GetInt32(),
|
|
status.RawCategory);
|
|
Assert.Equal(
|
|
testCase.GetProperty("status").GetProperty("rawDetectedBy").GetInt32(),
|
|
status.RawDetectedBy);
|
|
}
|
|
}
|
|
|
|
/// <summary>Verifies that the raw success member never overrides the authoritative category.</summary>
|
|
[Theory]
|
|
[InlineData(MxStatusCategory.Ok, 0, true)]
|
|
[InlineData(MxStatusCategory.Ok, 1, true)]
|
|
[InlineData(MxStatusCategory.CommunicationError, 1, false)]
|
|
[InlineData(MxStatusCategory.Unspecified, 1, false)]
|
|
public void IsSuccess_BranchesOnCategoryOnly(
|
|
MxStatusCategory category,
|
|
int success,
|
|
bool expected)
|
|
{
|
|
MxStatusProxy status = new() { Category = category, Success = success };
|
|
|
|
Assert.Equal(expected, status.IsSuccess());
|
|
}
|
|
|
|
private static string ReadFixture(string category, string fileName)
|
|
{
|
|
DirectoryInfo directory = new(AppContext.BaseDirectory);
|
|
while (directory is not null)
|
|
{
|
|
string path = Path.Combine(
|
|
directory.FullName,
|
|
"clients",
|
|
"proto",
|
|
"fixtures",
|
|
"behavior",
|
|
category,
|
|
fileName);
|
|
|
|
if (File.Exists(path))
|
|
{
|
|
return File.ReadAllText(path);
|
|
}
|
|
|
|
directory = directory.Parent!;
|
|
}
|
|
|
|
throw new FileNotFoundException(fileName);
|
|
}
|
|
}
|