Joseph Doherty
01033d7aaf
Family-wide admin-UI cleanup pass (scadaproj admin_ui_cleanup.md) applied to the Blazor dashboard. Behaviour is unchanged throughout — no @onclick, disabled, binding, auth gate, or arm->confirm flow was touched. Uncontrolled error text is now truncated at the render site. Fault messages, Galaxy load errors, and browse-tree load failures were rendered in full into fixed-width table cells, where a long exception string blows out the column. Each site gets DashboardDisplay.Abbreviate plus a title attribute carrying the untruncated text, so nothing becomes unreachable. Abbreviate is length-checked rather than a bare range slice: `value[..n]` on a shorter string throws and takes the whole page render down with it. The two detail views whose entire purpose is to show one fault in full — SessionDetailsPage and GalaxyPage's Last Error — are deliberately left untruncated. Two classes referenced from markup had no definition anywhere in the sheet. .browse-stale-banner was inert; .tree-load-status was a real visual defect — loading and failed-to-load rows sit among .tree-row siblings and carry the same leading .tree-toggle-empty spacer, but that spacer only takes its width as a flex item, so without a flex container those rows lost their indent. Confirm/cancel pairs in ConfirmDialog and the API-key create form are now btn-groups with role="group" and an aria-label, replacing margin-spaced loose buttons. Removes a paragraph on GalaxyPage naming internal RPCs (DiscoverHierarchy, GetLastDeployTime) — implementation detail with no meaning to a dashboard operator. Verified in a real browser, not bUnit: full build clean, 879/879 tests, and a live gate against a running dashboard with a genuine ~250-char SqlClient exception as the erroring row. Results per check, including the checks that could NOT be exercised without an x86 worker, are recorded in docs/plans/2026-08-11-dashboard-ui-sweeps.md. That plan doc also records a correction: this app is NOT Bootstrap-free. The sweep brief said it was, citing the scadaproj index; libman.json pins bootstrap 5.3.3 and App.razor:7 links it ahead of the theme. The stale claim had already cost this app one skipped family sweep (scadaproj#2, the /admin/secrets modal), so that modal was live-gated here too and passes.
62 lines
2.0 KiB
Plaintext
62 lines
2.0 KiB
Plaintext
@if (IsOpen)
|
|
{
|
|
<div class="modal-backdrop fade show"></div>
|
|
<div class="modal fade show" role="dialog" aria-modal="true" aria-labelledby="@TitleId" tabindex="-1" style="display: block;">
|
|
<div class="modal-dialog modal-dialog-centered">
|
|
<div class="modal-content">
|
|
<div class="modal-header">
|
|
<h2 class="modal-title h5" id="@TitleId">@Title</h2>
|
|
<button type="button" class="btn-close" aria-label="Close"
|
|
disabled="@IsBusy"
|
|
@onclick="OnCancel"></button>
|
|
</div>
|
|
<div class="modal-body">
|
|
<p class="mb-0">@Message</p>
|
|
</div>
|
|
<div class="modal-footer">
|
|
<div class="btn-group" role="group" aria-label="Confirm or cancel">
|
|
<button type="button" class="btn btn-outline-secondary"
|
|
disabled="@IsBusy"
|
|
@onclick="OnCancel">
|
|
Cancel
|
|
</button>
|
|
<button type="button" class="btn @ConfirmButtonClass"
|
|
disabled="@IsBusy"
|
|
@onclick="OnConfirm">
|
|
@ConfirmLabel
|
|
</button>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
}
|
|
|
|
@code {
|
|
private readonly string TitleId = $"confirm-dialog-{Guid.NewGuid():N}";
|
|
|
|
[Parameter]
|
|
public bool IsOpen { get; set; }
|
|
|
|
[Parameter]
|
|
public string Title { get; set; } = "Confirm";
|
|
|
|
[Parameter]
|
|
public string Message { get; set; } = string.Empty;
|
|
|
|
[Parameter]
|
|
public string ConfirmLabel { get; set; } = "Confirm";
|
|
|
|
[Parameter]
|
|
public string ConfirmButtonClass { get; set; } = "btn-primary";
|
|
|
|
[Parameter]
|
|
public bool IsBusy { get; set; }
|
|
|
|
[Parameter]
|
|
public EventCallback OnConfirm { get; set; }
|
|
|
|
[Parameter]
|
|
public EventCallback OnCancel { get; set; }
|
|
}
|