Files
Joseph Doherty 24de7e21d9 Regenerate code-reviews index after Low findings Batch 3
Reflects resolution of Contracts-001/004/005/006/007/008 (and Contracts-003
re-triaged Won't Fix). All code-review findings across every module are now
closed. Also normalizes the Contracts-003 Status to the canonical
`Won't Fix` value the index generator expects.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-18 23:12:34 -04:00
..

Code Reviews

Cross-module code review index for the mxaccessgw codebase. The review process is defined in ../REVIEW-PROCESS.md.

Each module's findings.md is the source of truth; this file is generated from them by regen-readme.py and must not be edited by hand.

Module status

Module Reviewer Date Commit Status Open Total
Client.Dotnet Claude Code 2026-05-18 3cc53a8 Reviewed 0 8
Client.Go Claude Code 2026-05-18 3cc53a8 Reviewed 0 10
Client.Java Claude Code 2026-05-18 3cc53a8 Reviewed 0 12
Client.Python Claude Code 2026-05-18 3cc53a8 Reviewed 0 12
Client.Rust Claude Code 2026-05-18 3cc53a8 Reviewed 0 12
Contracts Claude Code 2026-05-18 6c64030 Reviewed 0 8
IntegrationTests Claude Code 2026-05-18 6c64030 Reviewed 0 10
Server Claude Code 2026-05-18 6c64030 Reviewed 0 14
Tests Claude Code 2026-05-18 6c64030 Reviewed 0 12
Worker Claude Code 2026-05-18 6c64030 Reviewed 0 15
Worker.Tests Claude Code 2026-05-18 6c64030 Reviewed 0 15

Pending findings

Findings with status Open or In Progress, ordered by severity.

No pending findings.

Closed findings

Findings with status Resolved, Won't Fix, or Deferred.

ID Severity Status Category Location
Server-001 Critical Resolved Security src/MxGateway.Server/GatewayApplication.cs:147-149, src/MxGateway.Server/Dashboard/DashboardEndpointRouteBuilderExtensions.cs:55-58, src/MxGateway.Server/Dashboard/Components/Routes.razor:1-15
Client.Go-001 High Resolved Correctness & logic bugs clients/go/mxgateway/errors.go:88-93, clients/go/mxgateway/errors.go:117-128
Client.Rust-001 High Resolved mxaccessgw conventions clients/rust/src/options.rs:98,143
Client.Rust-002 High Resolved mxaccessgw conventions clients/rust/src/session.rs:522
Client.Rust-003 High Resolved Correctness & logic bugs clients/rust/crates/mxgw-cli/src/main.rs:1051
Client.Rust-012 High Resolved mxaccessgw conventions clients/rust/src/galaxy.rs:282
IntegrationTests-001 High Resolved Design-document adherence src/MxGateway.IntegrationTests/Galaxy/LiveGalaxyRepositoryFactAttribute.cs:7, src/MxGateway.IntegrationTests/Galaxy/GalaxyRepositoryLiveTests.cs
IntegrationTests-002 High Resolved Design-document adherence src/MxGateway.IntegrationTests/DashboardLdapLiveTests.cs:13, src/MxGateway.Server/Configuration/LdapOptions.cs:27
Server-003 High Resolved Security src/MxGateway.Server/Dashboard/DashboardAuthorizationHandler.cs:39,54-59, src/MxGateway.Server/Dashboard/DashboardAuthenticator.cs:236-258
Tests-001 High Resolved Testing coverage src/MxGateway.Tests/Gateway/Grpc/MxAccessGatewayServiceTests.cs:483-489
Tests-002 High Resolved Security src/MxGateway.Tests/Gateway/Grpc/GalaxyRepositoryGrpcServiceTests.cs:198-210
Worker-001 High Resolved Concurrency & thread safety src/MxGateway.Worker/MxAccess/WnWrapAlarmConsumer.cs:204-207
Worker-002 High Resolved Correctness & logic bugs src/MxGateway.Worker/Ipc/WorkerPipeSession.cs:545-549
Worker-003 High Resolved Correctness & logic bugs src/MxGateway.Worker/Ipc/WorkerPipeSession.cs:399-403, :416-419
Worker.Tests-001 High Resolved Testing coverage src/MxGateway.Worker.Tests/Sta/ (no StaMessagePumpTests.cs)
Worker.Tests-002 High Resolved Testing coverage src/MxGateway.Worker.Tests/MxAccess/MxAccessStaSessionTests.cs, src/MxGateway.Worker.Tests/MxAccess/MxAccessEventMapperTests.cs
Client.Dotnet-001 Medium Resolved Error handling & resilience clients/dotnet/MxGateway.Client/GrpcMxGatewayClientTransport.cs:190-199, clients/dotnet/MxGateway.Client/GrpcGalaxyRepositoryClientTransport.cs:131-140
Client.Dotnet-002 Medium Resolved Testing coverage clients/dotnet/MxGateway.Client.Tests/FakeGatewayTransport.cs:145-148, clients/dotnet/MxGateway.Client.Tests/MxGatewayClientSessionTests.cs:236-256
Client.Dotnet-003 Medium Resolved Concurrency & thread safety clients/dotnet/MxGateway.Client/MxGatewaySession.cs:659-663, clients/dotnet/MxGateway.Client/MxGatewayClient.cs:230-240
Client.Go-002 Medium Resolved Error handling & resilience clients/go/mxgateway/session.go:440-516
Client.Go-003 Medium Resolved Correctness & logic bugs clients/go/cmd/mxgw-go/main.go:517-532
Client.Java-001 Medium Resolved Security clients/java/mxgateway-client/src/main/java/com/dohertylan/mxgateway/client/MxGatewaySecrets.java:30-32
Client.Java-002 Medium Resolved Concurrency & thread safety clients/java/mxgateway-client/src/main/java/com/dohertylan/mxgateway/client/MxEventStream.java:31,66-92
Client.Java-003 Medium Resolved mxaccessgw conventions clients/java/mxgateway-client/src/main/java/com/dohertylan/mxgateway/client/MxGatewayClient.java:119-140
Client.Java-004 Medium Resolved Correctness & logic bugs clients/java/mxgateway-client/src/main/java/com/dohertylan/mxgateway/client/MxGatewaySession.java:114-120,157-163,191-197
Client.Java-005 Medium Resolved Error handling & resilience clients/java/mxgateway-client/src/main/java/com/dohertylan/mxgateway/client/MxGatewaySession.java:92-105
Client.Python-003 Medium Resolved Error handling & resilience clients/python/src/mxgateway/client.py:125-137,155-173
Client.Python-005 Medium Resolved Performance & resource management clients/python/src/mxgateway/galaxy.py:117-140
Client.Python-009 Medium Resolved Testing coverage clients/python/tests/
Client.Rust-005 Medium Resolved Correctness & logic bugs clients/rust/src/session.rs:489-520
Client.Rust-006 Medium Resolved Error handling & resilience clients/rust/src/session.rs:531-555
Contracts-002 Medium Resolved Error handling & resilience src/MxGateway.Contracts/Protos/mxaccess_gateway.proto:384-385, :95
IntegrationTests-003 Medium Resolved Correctness & logic bugs src/MxGateway.IntegrationTests/WorkerLiveMxAccessSmokeTests.cs:89-97
IntegrationTests-004 Medium Resolved Error handling & resilience src/MxGateway.IntegrationTests/WorkerLiveMxAccessSmokeTests.cs:108-111
IntegrationTests-005 Medium Resolved Testing coverage src/MxGateway.IntegrationTests/WorkerLiveMxAccessSmokeTests.cs
IntegrationTests-006 Medium Resolved Testing coverage src/MxGateway.IntegrationTests/DashboardLdapLiveTests.cs
Server-002 Medium Resolved Design-document adherence src/MxGateway.Server/Program.cs:24, src/MxGateway.Server/GatewayApplication.cs
Server-004 Medium Resolved Code organization & conventions src/MxGateway.Server/Security/Authentication/ApiKeyAdminCommandLineParser.cs:227-233, src/MxGateway.Server/Security/Authentication/ApiKeyAdminCliRunner.cs:53-77, src/MxGateway.Server/Dashboard/DashboardApiKeyManagementService.cs:21-67
Server-005 Medium Resolved Error handling & resilience src/MxGateway.Server/Galaxy/GalaxyHierarchyRefreshService.cs:22-28, src/MxGateway.Server/Galaxy/GalaxyHierarchyCache.cs:184
Server-006 Medium Resolved Correctness & logic bugs src/MxGateway.Server/Sessions/SessionManager.cs:84-114
Tests-003 Medium Resolved Performance & resource management src/MxGateway.Tests/Security/Authentication/SqliteAuthStoreTests.cs:170-176, src/MxGateway.Tests/Security/Authentication/ApiKeyAdminCliRunnerTests.cs:252-258
Tests-004 Medium Resolved Testing coverage src/MxGateway.Tests/Security/Authorization/GatewayGrpcAuthorizationInterceptorTests.cs
Tests-005 Medium Resolved Testing coverage src/MxGateway.Tests/Gateway/Grpc/EventStreamServiceTests.cs:239-261, src/MxGateway.Tests/Gateway/Sessions/SessionManagerTests.cs
Tests-006 Medium Resolved Concurrency & thread safety src/MxGateway.Tests/Gateway/Workers/WorkerClientTests.cs:76, src/MxGateway.Tests/Gateway/Workers/FakeWorkerHarnessTests.cs:122
Worker-004 Medium Resolved Correctness & logic bugs src/MxGateway.Worker/Ipc/WorkerPipeSession.cs:565-588
Worker-005 Medium Resolved Error handling & resilience src/MxGateway.Worker/MxAccess/MxAccessStaSession.cs:205-258 (production alarm poll loop)
Worker-006 Medium Resolved Correctness & logic bugs src/MxGateway.Worker/Ipc/WorkerPipeSession.cs:117-124, src/MxGateway.Worker/MxAccess/MxAccessStaSession.cs:386-491
Worker-007 Medium Resolved mxaccessgw conventions src/MxGateway.Worker/MxAccess/MxAccessComServer.cs:130-150
Worker-008 Medium Resolved Concurrency & thread safety src/MxGateway.Worker/MxAccess/MxAccessStaSession.cs:205-249, :429-447
Worker.Tests-003 Medium Resolved Concurrency & thread safety src/MxGateway.Worker.Tests/Sta/StaRuntimeTests.cs:46-48
Worker.Tests-004 Medium Resolved Concurrency & thread safety src/MxGateway.Worker.Tests/MxAccess/MxAccessStaSessionTests.cs:281-329
Worker.Tests-005 Medium Resolved Performance & resource management src/MxGateway.Worker.Tests/Ipc/WorkerFrameProtocolTests.cs:20-31,103-105, src/MxGateway.Worker.Tests/Ipc/WorkerPipeSessionTests.cs:28-31
Worker.Tests-006 Medium Resolved Performance & resource management src/MxGateway.Worker.Tests/MxAccess/MxAccessStaSessionTests.cs:282,305,315,323
Worker.Tests-007 Medium Resolved Design-document adherence docs/WorkerFrameProtocol.md:38-49
Client.Dotnet-004 Low Resolved Error handling & resilience clients/dotnet/MxGateway.Client/MxGatewayClient.cs:283-294, clients/dotnet/MxGateway.Client/GalaxyRepositoryClient.cs:392-403
Client.Dotnet-005 Low Resolved Correctness & logic bugs clients/dotnet/MxGateway.Client/MxGatewaySession.cs:82,124,175
Client.Dotnet-006 Low Resolved Code organization & conventions clients/dotnet/MxGateway.Client/MxGatewayClientOptions.cs:50, clients/dotnet/MxGateway.Client/MxGatewayClientContractInfo.cs:10-14
Client.Dotnet-007 Low Resolved Documentation & comments clients/dotnet/MxGateway.Client/MxGatewayClient.cs:185-192
Client.Dotnet-008 Low Resolved Correctness & logic bugs clients/dotnet/MxGateway.Client.Cli/MxGatewayCliSecretRedactor.cs:9-17
Client.Go-004 Low Resolved mxaccessgw conventions clients/go/mxgateway/alarms_test.go:153-154, clients/go/mxgateway/galaxy_test.go:58-59
Client.Go-005 Low Resolved Design-document adherence clients/go/mxgateway/client.go:64,68, clients/go/mxgateway/galaxy.go:83,87
Client.Go-006 Low Resolved Error handling & resilience clients/go/mxgateway/errors.go:9-130
Client.Go-007 Low Resolved Correctness & logic bugs clients/go/mxgateway/session.go:526-532
Client.Go-008 Low Resolved Testing coverage clients/go/mxgateway/ (test files)
Client.Go-009 Low Resolved Code organization & conventions clients/go/mxgateway/galaxy.go:60-93,241-256, clients/go/mxgateway/client.go:41-74,190-205
Client.Go-010 Low Resolved Documentation & comments clients/go/mxgateway/client.go:39-40
Client.Java-006 Low Resolved Performance & resource management clients/java/mxgateway-client/src/main/java/com/dohertylan/mxgateway/client/MxGatewayClient.java:323-328, clients/java/mxgateway-client/src/main/java/com/dohertylan/mxgateway/client/GalaxyRepositoryClient.java:279-284
Client.Java-007 Low Resolved Testing coverage clients/java/mxgateway-client/src/test/java/com/dohertylan/mxgateway/client/
Client.Java-008 Low Resolved Error handling & resilience clients/java/mxgateway-client/src/main/java/com/dohertylan/mxgateway/client/MxGatewayClient.java:298-304
Client.Java-009 Low Resolved Code organization & conventions clients/java/mxgateway-client/src/main/java/com/dohertylan/mxgateway/client/GalaxyRepositoryClient.java:310-391, clients/java/mxgateway-client/src/main/java/com/dohertylan/mxgateway/client/MxGatewayClient.java:346-413
Client.Java-010 Low Resolved Documentation & comments clients/java/mxgateway-client/src/main/java/com/dohertylan/mxgateway/client/MxGatewayClient.java:269-272, clients/java/README.md:76
Client.Java-011 Low Resolved Performance & resource management clients/java/mxgateway-client/src/main/java/com/dohertylan/mxgateway/client/MxEventStream.java:37-63
Client.Java-012 Low Resolved Correctness & logic bugs clients/java/mxgateway-cli/src/main/java/com/dohertylan/mxgateway/cli/MxGatewayCli.java:667-674
Client.Python-001 Low Resolved Documentation & comments clients/python/pyproject.toml:8,25, clients/python/src/mxgateway_cli/commands.py:25
Client.Python-002 Low Resolved Code organization & conventions clients/python/src/mxgateway/__init__.py:27
Client.Python-004 Low Resolved Correctness & logic bugs clients/python/src/mxgateway_cli/commands.py:386,402-404
Client.Python-006 Low Resolved Concurrency & thread safety clients/python/src/mxgateway/client.py:74-82, clients/python/src/mxgateway/galaxy.py:85-93, clients/python/src/mxgateway/session.py:38-55
Client.Python-007 Low Resolved Error handling & resilience clients/python/src/mxgateway/client.py:204-213
Client.Python-008 Low Resolved Correctness & logic bugs clients/python/src/mxgateway/values.py:62-67,83-88
Client.Python-010 Low Resolved Code organization & conventions clients/python/src/mxgateway/session.py:404, clients/python/src/mxgateway_cli/commands.py:422-425
Client.Python-011 Low Resolved Error handling & resilience clients/python/src/mxgateway/errors.py:122-148
Client.Python-012 Low Won't Fix mxaccessgw conventions clients/python/src/mxgateway/client.py:84-108, clients/python/src/mxgateway/session.py:57-77
Client.Rust-004 Low Resolved Documentation & comments clients/rust/src/version.rs:7
Client.Rust-007 Low Resolved Design-document adherence clients/rust/RustClientDesign.md:14-55
Client.Rust-008 Low Resolved Performance & resource management clients/rust/src/value.rs:161-261
Client.Rust-009 Low Resolved Testing coverage clients/rust/tests/client_behavior.rs, clients/rust/src/galaxy.rs
Client.Rust-010 Low Resolved Error handling & resilience clients/rust/src/client.rs:255-268, clients/rust/src/galaxy.rs:204-216
Client.Rust-011 Low Resolved mxaccessgw conventions clients/rust/src/session.rs:469
Contracts-001 Low Resolved Design-document adherence docs/Grpc.md:13 (and :3, :32, :39)
Contracts-003 Low Won't Fix Code organization & conventions src/MxGateway.Contracts/MxGateway.Contracts.csproj:10
Contracts-004 Low Resolved Documentation & comments src/MxGateway.Contracts/GatewayContractInfo.cs:3-6
Contracts-005 Low Resolved mxaccessgw conventions src/MxGateway.Contracts/Protos/mxaccess_gateway.proto, src/MxGateway.Contracts/Protos/mxaccess_worker.proto
Contracts-006 Low Resolved Correctness & logic bugs src/MxGateway.Contracts/Protos/mxaccess_gateway.proto:647
Contracts-007 Low Resolved Testing coverage src/MxGateway.Tests/Contracts/ProtobufContractRoundTripTests.cs
Contracts-008 Low Resolved Design-document adherence src/MxGateway.Contracts/Protos/mxaccess_gateway.proto:451-459, :627-636
IntegrationTests-007 Low Resolved Concurrency & thread safety src/MxGateway.IntegrationTests/WorkerLiveMxAccessSmokeTests.cs:20, src/MxGateway.IntegrationTests/Galaxy/GalaxyRepositoryLiveTests.cs:5, src/MxGateway.IntegrationTests/DashboardLdapLiveTests.cs:9
IntegrationTests-008 Low Resolved Code organization & conventions src/MxGateway.IntegrationTests/LiveLdapFactAttribute.cs, src/MxGateway.IntegrationTests/Galaxy/LiveGalaxyRepositoryFactAttribute.cs, src/MxGateway.IntegrationTests/LiveMxAccessFactAttribute.cs
IntegrationTests-009 Low Resolved Documentation & comments src/MxGateway.IntegrationTests/WorkerLiveMxAccessSmokeTests.cs:372-375
IntegrationTests-010 Low Resolved Correctness & logic bugs src/MxGateway.IntegrationTests/WorkerLiveMxAccessSmokeTests.cs:366-369
Server-007 Low Resolved Performance & resource management src/MxGateway.Server/Galaxy/GalaxyHierarchyProjector.cs:55-70
Server-008 Low Resolved Performance & resource management src/MxGateway.Server/Grpc/GalaxyRepositoryGrpcService.cs:111-134,160-189
Server-009 Low Resolved Error handling & resilience src/MxGateway.Server/Security/Authentication/AuthSqliteConnectionFactory.cs:15-32
Server-010 Low Resolved Security src/MxGateway.Server/Security/Authentication/SqliteApiKeyAdminStore.cs:91-114, src/MxGateway.Server/Dashboard/Components/Pages/ApiKeysPage.razor:168-172
Server-011 Low Resolved Code organization & conventions src/MxGateway.Server/Sessions/WorkerAlarmRpcDispatcher.cs:1-46
Server-012 Low Resolved Documentation & comments CLAUDE.md (Authentication section and apikey create example)
Server-013 Low Resolved Testing coverage src/MxGateway.Tests/Gateway/Dashboard/DashboardAuthorizationHandlerTests.cs, src/MxGateway.Tests/Gateway/GatewayApplicationTests.cs
Server-014 Low Resolved Documentation & comments src/MxGateway.Server/Grpc/MxAccessGatewayService.cs:162-171,191-198,206-214,229-237
Tests-007 Low Resolved Code organization & conventions src/MxGateway.Tests/Gateway/Grpc/MxAccessGatewayServiceTests.cs:682, src/MxGateway.Tests/Gateway/Grpc/GalaxyRepositoryGrpcServiceTests.cs:324, src/MxGateway.Tests/Gateway/GatewayEndToEndFakeWorkerSmokeTests.cs:460, src/MxGateway.Tests/Security/Authorization/GatewayGrpcAuthorizationInterceptorTests.cs:233
Tests-008 Low Resolved mxaccessgw conventions src/MxGateway.Tests/Gateway/Sessions/WorkerAlarmRpcDispatcherTests.cs:1-9, src/MxGateway.Tests/Gateway/Sessions/NotWiredAlarmRpcDispatcherTests.cs:1-3, src/MxGateway.Tests/Gateway/Sessions/SessionManagerAlarmAutoSubscribeTests.cs:1
Tests-009 Low Resolved Documentation & comments src/MxGateway.Tests/Gateway/Sessions/SessionManagerTests.cs:36-37,99,365
Tests-010 Low Resolved Security src/MxGateway.Tests/Gateway/Dashboard/DashboardAuthorizationHandlerTests.cs:26-36
Tests-011 Low Resolved Correctness & logic bugs src/MxGateway.Tests/Gateway/GatewayEndToEndFakeWorkerSmokeTests.cs:233-301
Tests-012 Low Resolved Concurrency & thread safety src/MxGateway.Tests/Gateway/Workers/Fakes/FakeWorkerHarness.cs:62, src/MxGateway.Tests/Gateway/Workers/WorkerClientTests.cs:472
Worker-009 Low Resolved Performance & resource management src/MxGateway.Worker/Ipc/WorkerFrameReader.cs:31,49, src/MxGateway.Worker/Ipc/WorkerFrameWriter.cs:57-58
Worker-010 Low Resolved Correctness & logic bugs src/MxGateway.Worker/Conversion/VariantConverter.cs:204-226
Worker-011 Low Resolved Correctness & logic bugs src/MxGateway.Worker/Ipc/WorkerPipeClient.cs:169-171
Worker-012 Low Resolved Documentation & comments src/MxGateway.Worker/MxAccess/MxAccessAlarmEventSink.cs:44-55, src/MxGateway.Worker/MxAccess/WnWrapAlarmConsumer.cs:38-43, src/MxGateway.Worker/MxAccess/MxAccessEventMapper.cs:106-112
Worker-013 Low Resolved Testing coverage src/MxGateway.Worker/Sta/StaMessagePump.cs
Worker-014 Low Resolved Code organization & conventions src/MxGateway.Worker/MxAccess/AlarmCommandHandler.cs:33, :202
Worker-015 Low Resolved Correctness & logic bugs src/MxGateway.Worker/MxAccess/MxAccessEventQueue.cs:115-145
Worker.Tests-008 Low Resolved Documentation & comments src/MxGateway.Worker.Tests/Conversion/VariantConverterTests.cs:175-182
Worker.Tests-009 Low Resolved Code organization & conventions src/MxGateway.Worker.Tests/MxAccess/AlarmCommandHandlerTests.cs, AlarmDispatcherTests.cs, AlarmCommandExecutorTests.cs, AlarmRecordTransitionMapperTests.cs, WnWrapAlarmConsumerXmlTests.cs
Worker.Tests-010 Low Resolved Correctness & logic bugs src/MxGateway.Worker.Tests/MxAccess/MxAccessStaSessionTests.cs:230-258
Worker.Tests-011 Low Resolved Documentation & comments src/MxGateway.Worker.Tests/Sta/StaCommandDispatcherTests.cs:92-112
Worker.Tests-012 Low Resolved Testing coverage src/MxGateway.Worker.Tests/Ipc/WorkerFrameProtocolTests.cs
Worker.Tests-013 Low Resolved Concurrency & thread safety src/MxGateway.Worker.Tests/Ipc/WorkerPipeSessionTests.cs:539-546
Worker.Tests-014 Low Resolved Code organization & conventions src/MxGateway.Worker.Tests/Ipc/WorkerPipeClientTests.cs:194, WorkerPipeSessionTests.cs:622, Sta/StaCommandDispatcherTests.cs:348, MxAccess/MxAccessStaSessionTests.cs:334, MxAccess/MxAccessCommandExecutorTests.cs:1124
Worker.Tests-015 Low Resolved Testing coverage src/MxGateway.Worker.Tests/MxAccess/MxAccessEventQueueTests.cs