dohertj2/mxaccessgw
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Implement Graceful Shutdown #33

New Issue
Closed
opened 2026-04-26 15:22:35 -04:00 by dohertj2 · 2 comments
dohertj2 commented 2026-04-26 15:22:35 -04:00
Owner
Copy Link
Copy Source

Source: $file
Milestone: $currentMilestone

Labels: area:worker, type:feature, priority:p0

Deliverables:

  • handle WorkerShutdown,
  • reject new commands,
  • let current command finish within timeout,
  • best-effort UnAdvise, RemoveItem, Unregister,
  • detach event handlers,
  • release COM object,
  • exit process.

Acceptance criteria:

  • cleanup order follows design,
  • cleanup failures are logged but do not hang shutdown,
  • gateway can kill after timeout,
  • worker exits with success on graceful shutdown.

Tests:

  • fake cleanup order,
  • cleanup failure,
  • command in progress,
  • shutdown timeout.
Source: $file Milestone: $currentMilestone Labels: `area:worker`, `type:feature`, `priority:p0` Deliverables: - handle `WorkerShutdown`, - reject new commands, - let current command finish within timeout, - best-effort `UnAdvise`, `RemoveItem`, `Unregister`, - detach event handlers, - release COM object, - exit process. Acceptance criteria: - cleanup order follows design, - cleanup failures are logged but do not hang shutdown, - gateway can kill after timeout, - worker exits with success on graceful shutdown. Tests: - fake cleanup order, - cleanup failure, - command in progress, - shutdown timeout.
dohertj2 added this to the mxaccess-worker-parity-slice milestone 2026-04-26 15:22:35 -04:00
dohertj2 added the area:workertype:featurepriority:p0 labels 2026-04-26 15:22:35 -04:00
dohertj2 added a new dependency 2026-04-26 15:28:39 -04:00
#25 Implement STA Command Dispatcher
dohertj2 added a new dependency 2026-04-26 15:28:39 -04:00
#26 Implement Register And Unregister
dohertj2 added a new dependency 2026-04-26 15:28:39 -04:00
#27 Implement AddItem, AddItem2, RemoveItem
dohertj2 added a new dependency 2026-04-26 15:28:39 -04:00
#28 Implement Advise, UnAdvise, AdviseSupervisory
dohertj2 added a new dependency 2026-04-26 15:28:39 -04:00
#29 Implement Event Sink And Event Queue
dohertj2 added a new dependency 2026-04-26 15:28:40 -04:00
#34 Worker Live MXAccess Smoke Test
dohertj2 commented 2026-04-26 19:09:45 -04:00
Author
Owner
Copy Link
Copy Source

Worker 2 is taking this issue. Branch: agent-2/issue-33-implement-graceful-shutdown. Worktree: C:\Users\dohertj2\Desktop\mxaccessgw-agent-2.

Worker 2 is taking this issue. Branch: agent-2/issue-33-implement-graceful-shutdown. Worktree: C:\Users\dohertj2\Desktop\mxaccessgw-agent-2.
dohertj2 commented 2026-04-26 19:44:25 -04:00
Author
Owner
Copy Link
Copy Source

Verified and merged by orchestrator in PR #88.

Implementation commit: d890efff068118295b0a158f921ef5d998abf811
Merge/update commit on branch: f7929cc0f8c19a40cd56a997f929937714d0cdfa
Merge commit: ec4e2f687e
Branch: agent-2/issue-33-implement-graceful-shutdown

Independent verification:

  • dotnet build src\MxGateway.sln
  • dotnet test src\MxGateway.Worker.Tests\MxGateway.Worker.Tests.csproj -p:Platform=x86 --no-build --filter "FullyQualifiedNameWorkerPipeSessionTests|FullyQualifiedNameWorkerPipeClientTests|FullyQualifiedNameStaCommandDispatcherTests|FullyQualifiedNameMxAccessCommandExecutorTests"
  • dotnet test src\MxGateway.sln --no-build

Result: all tests passed (29 targeted x86 worker tests; full suite 1 integration, 179 gateway, 114 worker).

Verified and merged by orchestrator in PR #88. Implementation commit: d890efff068118295b0a158f921ef5d998abf811 Merge/update commit on branch: f7929cc0f8c19a40cd56a997f929937714d0cdfa Merge commit: ec4e2f687e6f9a0fb94a155d3f3d411b9d7bb09b Branch: agent-2/issue-33-implement-graceful-shutdown Independent verification: - dotnet build src\MxGateway.sln - dotnet test src\MxGateway.Worker.Tests\MxGateway.Worker.Tests.csproj -p:Platform=x86 --no-build --filter "FullyQualifiedName~WorkerPipeSessionTests|FullyQualifiedName~WorkerPipeClientTests|FullyQualifiedName~StaCommandDispatcherTests|FullyQualifiedName~MxAccessCommandExecutorTests" - dotnet test src\MxGateway.sln --no-build Result: all tests passed (29 targeted x86 worker tests; full suite 1 integration, 179 gateway, 114 worker).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area:auth
Authentication and authorization
 area:client-dotnet
.NET client library
 area:client-go
Go client library
 area:client-java
Java client library
 area:client-python
Python client library
 area:client-rust
Rust client library
 area:contracts
Protocol and generated contract work
 area:dashboard
Blazor dashboard work
 area:docs
Documentation
 area:gateway
Gateway server work
 area:tests
Automated and live tests
 area:worker
MXAccess worker process work
 blocked
Blocked by dependency
 priority:p0
Must-have / blocking
 priority:p1
High priority
 priority:p2
Normal priority
 type:docs
Documentation work
 type:feature
Feature implementation
 type:infra
Infrastructure and scaffolding
 type:test
Test work
No Label area:worker priority:p0 type:feature
Milestone
No items
No Milestone mxaccess-worker-parity-slice
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Blocks
#34 Worker Live MXAccess Smoke Test
dohertj2/mxaccessgw
Depends on
#25 Implement STA Command Dispatcher
dohertj2/mxaccessgw
#26 Implement Register And Unregister
dohertj2/mxaccessgw
#27 Implement AddItem, AddItem2, RemoveItem
dohertj2/mxaccessgw
#28 Implement Advise, UnAdvise, AdviseSupervisory
dohertj2/mxaccessgw
#29 Implement Event Sink And Event Queue
dohertj2/mxaccessgw
Reference: dohertj2/mxaccessgw#33
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?