dohertj2/mxaccessgw
1
0
Fork 0
Code Issues 43 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Audit: populate CorrelationId on dashboard/API-key admin audit events (Audit GAP #6 residual) #213

New Issue
Open
opened 2026-11-06 15:26:23 -05:00 by dohertj2 · 0 comments
dohertj2 commented 2026-11-06 15:26:23 -05:00
Owner
Copy Link
Copy Source

Audit normalization backlog item #6 asked mxaccessgw to (a) capture CorrelationId at constraint denial and dashboard paths and (b) emit a structured Target instead of embedding it in Details text.

Current state (code check on local main 8c0a51d, 2026-11-06):

  • Constraint-denial path: DONE. ConstraintEnforcer now emits Target = "<commandKind>:<target>" (bulk: "<commandKind>:bulk") and a typed CorrelationId when the client id parses as a GUID, with the raw client id kept in DetailsJson["clientCorrelationId"] (commits 8415f35, 55526d5; stillpending.md 1.2).
  • Dashboard / API-key admin path: CanonicalForwardingApiKeyAuditStore.AppendAsync still sets CorrelationId = null (Target = key id is structured). Dashboard actions (DashboardApiKeyManagementService create/revoke/rotate) therefore carry no correlation id.

Ask: decide whether dashboard-originated audit events should carry a correlation id (for example the request TraceIdentifier or a per-action GUID) and populate it, or record that the dashboard path has no meaningful correlation source and close. Verify still open. Low priority: nice-to-have parity, not required for adoption.

Source: ~/Desktop/scadaproj/components/audit/GAPS.md (Adoption backlog #6; field table rows Target/CorrelationId).

Audit normalization backlog item #6 asked mxaccessgw to (a) capture CorrelationId at constraint denial and dashboard paths and (b) emit a structured Target instead of embedding it in Details text. Current state (code check on local main 8c0a51d, 2026-11-06): - Constraint-denial path: DONE. ConstraintEnforcer now emits `Target = "<commandKind>:<target>"` (bulk: `"<commandKind>:bulk"`) and a typed CorrelationId when the client id parses as a GUID, with the raw client id kept in DetailsJson["clientCorrelationId"] (commits 8415f35, 55526d5; stillpending.md 1.2). - Dashboard / API-key admin path: CanonicalForwardingApiKeyAuditStore.AppendAsync still sets CorrelationId = null (Target = key id is structured). Dashboard actions (DashboardApiKeyManagementService create/revoke/rotate) therefore carry no correlation id. Ask: decide whether dashboard-originated audit events should carry a correlation id (for example the request TraceIdentifier or a per-action GUID) and populate it, or record that the dashboard path has no meaningful correlation source and close. Verify still open. Low priority: nice-to-have parity, not required for adoption. Source: ~/Desktop/scadaproj/components/audit/GAPS.md (Adoption backlog #6; field table rows Target/CorrelationId).
dohertj2 added the area:dashboardarea:authtype:followuppriority:p3migrated labels 2026-11-06 15:26:23 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area:auth
Authentication and authorization
 area:client-dotnet
.NET client library
 area:client-go
Go client library
 area:client-java
Java client library
 area:client-python
Python client library
 area:client-rust
Rust client library
 area:contracts
Protocol and generated contract work
 area:dashboard
Blazor dashboard work
 area:docs
Documentation
 area:gateway
Gateway server work
 area:tests
Automated and live tests
 area:worker
MXAccess worker process work
 blocked
Blocked by dependency
 cross-repo
Needs coordinated change in another family repo (wire contract etc.)
 migrated
Migrated from a markdown backlog (2026-11 standardization)
 priority:p0
Must-have / blocking
 priority:p1
High priority
 priority:p2
Normal priority
 priority:p3
Low priority / nice to have
 type:bug
Defect in shipped behaviour
 type:debt
Technical debt / hygiene
 type:deploy-gate
Rollout/deploy/migration step not yet done on an environment
 type:docs
Documentation work
 type:feature
Feature implementation
 type:followup
Follow-up deferred from a plan, PR or gate
 type:infra
Infrastructure and scaffolding
 type:review-finding
Unfixed finding from an architecture/code review
 type:test
Test work
No Label area:auth area:dashboard migrated priority:p3 type:followup
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/mxaccessgw#213
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?